Re: RFR: 8022718 : Runtime accessibility checking: protected class, if extended, should be accessible from another package

Further revised after consulting with John Rose on details of fix: webrev: http://cr.openjdk.java.net/~drchase/8022718/webrev.02/ tests: jtreg of jdk/lambda java/lang/invoke java/util/stream defmeth (a/b testing) jprt in progress (assuming I got the incantation right) David

hg: jdk8/tl: 8025796: hgforest.sh could trigger unbuffered output from hg without complicated machinations

Changeset: 3f9873789d44 Author:mduigou Date: 2013-10-11 15:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/3f9873789d44 8025796: hgforest.sh could trigger unbuffered output from hg without complicated machinations Reviewed-by: mduigou Contributed-by: Dmitry Samersoff ! commo

hg: jdk8/tl/jdk: 8026213: Reflection support for private interface methods

Changeset: 4561460bf570 Author:rfield Date: 2013-10-11 15:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4561460bf570 8026213: Reflection support for private interface methods Reviewed-by: forax, psandoz, dholmes, jfranck Contributed-by: karen.kinn...@oracle.com ! src/sha

hg: jdk8/tl/jdk: 2 new changesets

Changeset: d23247aa7462 Author:vinnie Date: 2013-10-11 20:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d23247aa7462 8026301: DomainKeyStore doesn't cleanup correctly when storing to keystore Reviewed-by: mullan ! src/share/classes/sun/security/provider/DomainKeyStore.ja

Re: RFR: 8008733: Psr:perf:osb performance regression (18%) in wss_bodyenc

On 10/11/2013 11:57 PM, Alan Bateman wrote: > (this might be a question for Aleksey as ideally we should be > building up a suite a good micro benchmarks as we fix or improve > things). Working on it separately for some time now. It would help to have the benchmark for particular issue anyway. -A

Re: RFR: 8025255: (tz) Support tzdata2013g

Hi Aleksej, Yes, you are right. They can be handled separately. Thanks! Regards, Michael Sent from my iPhone On Oct 11, 2013, at 12:20 PM, Aleksej Efimov wrote: > Hi Michael, > As I can see this topic was touched a little here: > http://mail.openjdk.java.net/pipermail/threeten-dev/2012-Decem

hg: jdk8/tl/jdk: 8019526: (fs) Files.lines, etc without Charset parameter

Changeset: 9632de07d963 Author:alanb Date: 2013-10-11 20:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9632de07d963 8019526: (fs) Files.lines, etc without Charset parameter Reviewed-by: psandoz, henryjen ! src/share/classes/java/nio/file/Files.java ! test/java/nio/file/F

Re: RFR: 8008733: Psr:perf:osb performance regression (18%) in wss_bodyenc

On 11/10/2013 15:30, Aleksey Shipilev wrote: : While I agree with the fix, profiling is the no-go way to confirm the performance regression and the fix, especially with the broken test you have in [3]. You need to build targeted benchmarks, see e.g. jmh: http://openjdk.java.net/projects/code-tool

Re: RFR: 8024688: j.u.Map.merge doesn't work as specified if contains key:null pair

On Oct 10 2013, at 06:37 , Paul Sandoz wrote: > Hi Mike, > > This looks like a good direction. Need to look more closely. > > I wonder if we even require such detailed support to throw CME? Some additional CME will be thrown indirectly by iteration. This applies to forEach/replaceAll. Virtua

RFR [8024521] (process) Async close issues with Process InputStream

Hello all! Would you please help review a fix? http://bugs.sun.com/view_bug.do?bug_id=8024521 As of JDK 1.7, ProcessPipeInputStream tries to drain the InputStream when the process exits. However, it is racing with application code that could be closing the inputstream at the same time. This c

Re: Label for JDK 8 issue affecting JCK?

Wrong mailing list - please ignore. On Oct 11, 2013, at 12:17 PM, Brian Burkhalter wrote: > On Oct 11, 2013, at 12:15 PM, Alan Bateman wrote: > >> Is there a CCC for this? > > Literally typing in that request now. > >> If so then JCK will create a bug in the JCK project (you don't have to do

Re: RFR: 8025255: (tz) Support tzdata2013g

Hi Michael, As I can see this topic was touched a little here: http://mail.openjdk.java.net/pipermail/threeten-dev/2012-December/000314.html. AFAIU from the above discussion the CLDR generic names were translated in all locales, but the legacy JRE time zone names doesn't contain this translati

Re: Label for JDK 8 issue affecting JCK?

On Oct 11, 2013, at 12:15 PM, Alan Bateman wrote: > Is there a CCC for this? Literally typing in that request now. > If so then JCK will create a bug in the JCK project (you don't have to do it). OK - thanks. Brian

Re: RFR: JDK-8025712, , (props) Possible memory leak in java_props_md.c / ParseLocale

Looks good. Thank you for fixing this. Naoto On 10/10/13 7:46 PM, Dan Xu wrote: Thanks for your clarification, Naoto. Here is the updated webrev, http://cr.openjdk.java.net/~dxu/8025712/webrev.01/. Please help review it. -Dan On 10/10/2013 03:14 PM, Naoto Sato wrote: You could, but that par

Re: RFR: 8025255: (tz) Support tzdata2013g

Hi Aleksej, I took a look at the localized TimeZoneNames_*.java files. They do not contain generic time zone names for JSR310... I think we can file a separate bug to track that issue. thanks, -michael On 13年10月10日 09:54 下午, Masayoshi Okutsu wrote: Hi Aleksej, Here are my review comments.

hg: jdk8/tl/jdk: 8025712: (props) Possible memory leak in java_props_md.c / ParseLocale

Changeset: cb373cf43294 Author:dxu Date: 2013-10-11 09:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb373cf43294 8025712: (props) Possible memory leak in java_props_md.c / ParseLocale Reviewed-by: naoto, chegar ! src/solaris/native/java/lang/java_props_md.c

Re: JDK 8 RFR 7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with NPE

On Oct 11, 2013, at 8:42 AM, Alan Bateman wrote: > On 11/10/2013 16:15, Brian Burkhalter wrote: >> Thanks. >> >> Any further comments from anyone else? >> >> Brian >> > I'm happy to see getPermissions changed to just specify long standing > behavior (the original proposal was unlikely to break

Re: JDK 8 RFR 7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with NPE

On 11/10/2013 16:15, Brian Burkhalter wrote: Thanks. Any further comments from anyone else? Brian I'm happy to see getPermissions changed to just specify long standing behavior (the original proposal was unlikely to break anyone but it was surprising). So I think what you have is fine now.

Re: JDK 8 RFR 7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with NPE

Looks fine to me. Michael On 11/10/13 16:15, Brian Burkhalter wrote: Thanks. Any further comments from anyone else? Brian On Oct 10, 2013, at 9:04 PM, David Holmes wrote: Ship it! :) Thanks, David On 11/10/2013 5:24 AM, Brian Burkhalter wrote: On Oct 10, 2013, at 11:21 AM, Brian Burkhal

Re: JDK 8 RFR 7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with NPE

On 11/10/2013 05:04, David Holmes wrote: Ship it! :) +1 -Chris. Thanks, David On 11/10/2013 5:24 AM, Brian Burkhalter wrote: On Oct 10, 2013, at 11:21 AM, Brian Burkhalter wrote: On Oct 10, 2013, at 11:05 AM, Brian Burkhalter wrote: Nit: In the test there are a few places where you ha

Re: JDK 8 RFR 7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with NPE

Thanks. Any further comments from anyone else? Brian On Oct 10, 2013, at 9:04 PM, David Holmes wrote: > Ship it! :) > > Thanks, > David > > On 11/10/2013 5:24 AM, Brian Burkhalter wrote: >> >> On Oct 10, 2013, at 11:21 AM, Brian Burkhalter wrote: >> >>> On Oct 10, 2013, at 11:05 AM, Brian B

Re: Review: demos for jdk8

I think there may be a problem with Console::close(). Even though the Console instance will be disposed in a try-with-resources construct, that doesn't the reader and writer are guaranteed to close together. Currently, if the reader fails to close, the writer will be left dangling. What do you thin

Review: demos for jdk8

Hi guys, Did you have a chance to review our jdk8 demos? http://cr.openjdk.java.net/~anazarov/try-with-resources/ http://cr.openjdk.java.net/~anazarov/repeating-annotations/ http://cr.openjdk.java.net/~anazarov/jdk8-demo-bulkoperations/ http://cr.openjdk.java.net/~anazarov/extension-methods/ -

Re: RFR: 8008733: Psr:perf:osb performance regression (18%) in wss_bodyenc

On 10/11/2013 06:06 PM, Aleksej Efimov wrote: > I don't think we need a regression test for it, but we need to make sure > the regression is gone. In attempt to prove it, I have done two simple > hprof run [2] on a test app [3] that creates 10 instances of > XPathContext in a cycle. While I a

RFR: 8008733: Psr:perf:osb performance regression (18%) in wss_bodyenc

Hi, I need help in reviewing the fix for this one bug: 8008733. It was firstly observed in JDK 6 and already fixed there. The problem and the fix [1] looks trivial: There is a performance regression in XPathContext class constructor and it's caused by double initialization of 'm_dtmManager' fie

hg: jdk8/tl/langtools: 6278240: Exception from AnnotationValue.getValue() should list the found type not the required type

Changeset: 872c4a898b38 Author:jlahoda Date: 2013-10-11 15:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/872c4a898b38 6278240: Exception from AnnotationValue.getValue() should list the found type not the required type Reviewed-by: darcy, jfranck, jjg ! src/share/c

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 4ad76262bac8 Author:mullan Date: 2013-10-11 08:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ad76262bac8 8007292: Add JavaFX internal packages to package.access Summary: build hooks to allow closed restricted packages to be added to java.security file Reviewe

Re: RFR: 8025255: (tz) Support tzdata2013g

Hi Masayoshi, The new webrev with addressed review comments: http://cr.openjdk.java.net/~aefimov/8025255/8/webrev.01/ The list of changes: 1. "Middle Europe Time" remained untouched. 2. The copyright headers were added. Best Regards

hg: jdk8/tl/nashorn: 4 new changesets

Changeset: 1c154cee43d9 Author:hannesw Date: 2013-10-11 10:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1c154cee43d9 8026292: Megamorphic setter fails with boolean value Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/MethodEmitter.java + test/script

Re: RFR: 7044282: (reflect) Class.forName and Array.newInstance are inconsistent regarding multidimensional arrays

Thanks for the reviews, fix has been pushed. cheers /Joel On 2013-10-10, Joe Darcy wrote: > Looks fine; thanks, > > -Joe > > On 10/10/2013 5:56 AM, Paul Sandoz wrote: > >On Oct 10, 2013, at 2:46 PM, Joel Borggren-Franck > >wrote: > > > >>Hi, > >> > >>Joe, Paul, agreed the test could be better

Re: RFR: Lambda 8026213: Reflection support for private methods in interfaces

Thank you David - that will be helpful. And thanks for the re-review. thanks, Karen On Oct 11, 2013, at 12:56 AM, David Holmes wrote: > Karen, > > You can set the system property sun.reflect.inflationThreshold=N to change > the magic value from 15. That makes testing easier. > > David > > On

Re: RFR: JDK-8025712, , (props) Possible memory leak in java_props_md.c / ParseLocale

Thanks Dan, looks good to me. -Chris. On 11/10/2013 03:46, Dan Xu wrote: Thanks for your clarification, Naoto. Here is the updated webrev, http://cr.openjdk.java.net/~dxu/8025712/webrev.01/. Please help review it. -Dan On 10/10/2013 03:14 PM, Naoto Sato wrote: You could, but that part only

Re: RFR: 8011638 - Remove deprecated methods in sun.util.logging.PlatformLogger

Looks good to me Daniel. -Chris. On 10/10/2013 14:11, Daniel Fuchs wrote: Hi, Please find below a patch for 8011638 - Remove deprecated methods in sun.util.logging.PlatformLogger https://bugs.openjdk.java.net/browse/JDK-8011638 b

Re: RFR: 8025255: (tz) Support tzdata2013g

Hi Masayoshi, Thank you for your comments. Replies are below. On 10/11/2013 08:54 AM, Masayoshi Okutsu wrote: Hi Aleksej, Here are my review comments. - The copyright header of the data files shouldn't be removed. The copyright header is absent in raw tzdata2013g release (in tzdata2013g.tar.g

Re: RFR: 8013839: Enhance Logger API for handling of resource bundles

On 10/4/13 4:44 PM, Daniel Fuchs wrote: Hi Mandy, On 10/3/13 9:29 PM, Mandy Chung wrote: test/java/util/ResourceBundle/getBaseBundleName/TestGetBaseBundleName.java 109 return new Vector(java.util.Arrays.asList( 110 new String[] {"dummy"})).elements

Re: RFR: Lambda 8026213: Reflection support for private methods in interfaces

On Oct 10, 2013, at 6:02 PM, Karen Kinnear wrote: > Updated webrev: webrev: http://cr.openjdk.java.net/~acorn/8026213.2/webrev/ bug: https://bugs.openjdk.java.net/browse/JDK-8026213 > > +1 Paul. > Testing: > Specific test for private methods (attached to bug) > jtreg jdk java.lan

hg: jdk8/tl/nashorn: 5 new changesets

Changeset: 34f7a699cdef Author:sundar Date: 2013-10-10 14:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/34f7a699cdef 8026162: "this" in SAM adapter functions is wrong Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nasho

Re: RFR: Lambda 8026213: Reflection support for private methods in interfaces

On 10/11/2013 06:56 AM, David Holmes wrote: Karen, You can set the system property sun.reflect.inflationThreshold=N to change the magic value from 15. That makes testing easier. Or, alternatively, you can set sun.reflect.noInflation=true, which generates code straight away, so that even 1st

Review request for jdeps option rename to Java-style and enhancements to output dot file format

There were some discussion of jdeps CLI to follow GNU style option or the traditional Java style. As there will be plans to upgrade the JDK tools to GNU style options, it'd be desirable to keep jdeps be consistent with other langtools and be upgraded to GNU style in a unified manner. This patch