The security tests look fine.
--Sean
On 11/01/2013 07:18 AM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 8.
Most of tests in the sound area, and some tests in the client,
java.lang, security, jmx etc has incorrect copyright.
According to the http://openjdk.java.net/faq
GPL v2 +
Hi Everyone
http://cr.openjdk.java.net/~pzhang/Tristan/7190106/webrev/
Description:
1. Convert shell script test to Java program test.
2. Using random server port by reusing Darryl Mocek's work to replace
fixed server port.
3. Using java Process class to start client process.
4. Also convert
On 10/31/13 10:22 PM, Tristan Yan wrote:
I am working on bug https://bugs.openjdk.java.net/browse/JDK-7190106. Based
on my research, it looks like the issue of fixed port was already addressed
by Stuart Marks in other RMI tests which are Java based. I would like to
reuse his solution, however it
/Hi Everyone
/
/I am working on bug https://bugs.openjdk.java.net/browse/JDK-8025198.
Root cause for this bug is //there is a race condition on below code.
//there is a very small chance that when 11th thread finishes
allStarted.countDown() and before check the count, 10th thread does
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027351/webrev.00/
This fixes the finalization implementation to invoke the finalize method
via shared secret so that it will call the same method as the bytecode
invocation.
The current implementation uses JNI_GetMethodID to find
Change looks good to me(not a reviewer).
Cheers,
Henry
On 11/01/2013 10:57 AM, Paul Sandoz wrote:
Hi,
This is a eating humble pie and should of correctly listened to Henry in
review kind of email :-)
The changes to DistinctOpTest recently committed result in a test failure,
since one of
Hi Tristan,
Without commenting on the specifics of this test, in my estimation we
should strongly favor rewriting shell tests as Java programs, as has
already largely been done in the langtools area:
Shelling Tests
https://blogs.oracle.com/jjg/entry/shelling_tests
-Joe
On
Changeset: cc80c03c41e4
Author:vromero
Date: 2013-11-01 19:08 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cc80c03c41e4
8027660: javac crash while creating LVT entry for a local variable defined in
an inner block
Reviewed-by: jjg
Contributed-by:
2013/11/1 4:15 -0700, mandy.ch...@oracle.com:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027351/webrev.00/
Looks good.
Just one question: In Finalizer.java, at line 97 you look up the
JavaLangAccess object every single time. Is it worth caching that
earlier, maybe when the finalize
Changeset: 8b4e1421a9b7
Author:jlahoda
Date: 2013-11-01 21:43 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8b4e1421a9b7
8027310: Annotation Processor crashes with NPE
Summary: JCAnnotation.attribute is null when annotation type is unavailable
Reviewed-by: jjg,
Changeset: 6a6faa00acc4
Author:dxu
Date: 2013-11-01 14:40 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a6faa00acc4
8027624: com/sun/crypto/provider/KeyFactory/TestProviderLeak.java unstable again
Reviewed-by: wetmore
!
Please review at your convenience:
Issue:
https://bugs.openjdk.java.net/browse/JDK-8027625
Patch:
--- a/test/java/math/BigInteger/ExtremeShiftingTests.java Fri Nov 01
14:40:03 2013 -0700
+++ b/test/java/math/BigInteger/ExtremeShiftingTests.java Fri Nov 01
17:03:04 2013 -0700
@@
Looks good to me.
-Dan
On 11/01/2013 05:07 PM, Brian Burkhalter wrote:
Please review at your convenience:
Issue:
https://bugs.openjdk.java.net/browse/JDK-8027625
Patch:
--- a/test/java/math/BigInteger/ExtremeShiftingTests.java Fri Nov 01
14:40:03 2013 -0700
+++
Changeset: c35f6df5bce9
Author:sla
Date: 2013-11-01 10:08 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c35f6df5bce9
8027692: Remove java/lang/management/MemoryMXBean/LowMemoryTest2.sh from
ProblemList.txt
Reviewed-by: stefank, alanb
! test/ProblemList.txt
Hi,
Please review the fix for JDK-8006730 below.
Description:
Several tests have been added in test/tools/doclint/{html,tidy,tool} making the
dummy-tests, AAA.java obsolete.
This patch removes the AAA.java tests.
Link to web review:
http://cr.openjdk.java.net/~alundblad/8006730
Link to bug
Hello.
Please review the fix for jdk 8.
Most of tests in the sound area, and some tests in the client,
java.lang, security, jmx etc has incorrect copyright.
According to the http://openjdk.java.net/faq
GPL v2 + the Classpath exception for the class libraries and those
parts of the virtual
Changeset: c59ccad6eb72
Author:sla
Date: 2013-11-01 15:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c59ccad6eb72
8027705: com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is
generating events.
Reviewed-by: dcubed
! test/com/sun/jdi/JdbMethodExitTest.sh
17 matches
Mail list logo
