Assorted annotation optimizations

2013-11-02 Thread Peter Levart
Hi, I propose a set of straightforward optimizations of annotations in the field of minimizing garbage creation and execution performance. Here's a webrev containing the changes: http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationOptimizations/webrev.01/ Changes grouped by class/method:

Re: [8] Review Request: 8027696 Incorrect copyright header in the tests

2013-11-02 Thread Sergey Bylokhov
On 02.11.2013 15:37, Alan Bateman wrote: On 01/11/2013 11:18, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 8. Most of tests in the sound area, and some tests in the client, java.lang, security, jmx etc has incorrect copyright. According to the http://openjdk.java.net/faq "GPL v2

Re: [8] Review Request: 8027696 Incorrect copyright header in the tests

2013-11-02 Thread Alan Bateman
On 01/11/2013 11:18, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 8. Most of tests in the sound area, and some tests in the client, java.lang, security, jmx etc has incorrect copyright. According to the http://openjdk.java.net/faq "GPL v2 + the Classpath exception for the class l

Re: JDK-8027351: (ref) Base's class finalize method not invoked if a private finalize method exists in its subclass

2013-11-02 Thread Peter Levart
On 11/01/2013 10:11 PM, Mandy Chung wrote: On 11/1/13 1:37 PM, [email protected] wrote: 2013/11/1 4:15 -0700, [email protected]: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027351/webrev.00/ Looks good. Just one question: In Finalizer.java, at line 97 you look up the JavaLan

Re: [test-only] JDK 8 RFR 8027625: test/java/math/BigInteger/ExtremeShiftingTests.java needs @run tag to specify heap size

2013-11-02 Thread Alan Bateman
On 02/11/2013 00:07, Brian Burkhalter wrote: Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8027625 Patch: Thanks for that, this test has been failing with OOME in some environments since the recent change. -Alan.

Re: JDK-8027351: (ref) Base's class finalize method not invoked if a private finalize method exists in its subclass

2013-11-02 Thread Alan Bateman
On 01/11/2013 21:11, Mandy Chung wrote: I was expecting that would get optimized during runtime and it's a simple getter method. It's a good suggestion to cache it at the finalize thread start time and here is the revised webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027351/webrev

RE: JDK-8027351: (ref) Base's class finalize method not invoked if a private finalize method exists in its subclass

2013-11-02 Thread Jeroen Frijters
Hi Mandy (and Mark), The getter can be optimized away, the static field can't, so this is probably a tiny bit more expensive. Regards, Jeroen > -Original Message- > From: [email protected] [mailto:core-libs-dev- > [email protected]] On Behalf Of Mandy Chung >

RE: JDK-8027351: (ref) Base's class finalize method not invoked if a private finalize method exists in its subclass

2013-11-02 Thread Jeroen Frijters
Hi Mandy, Thank you. Patch looks good. Regards, Jeroen > -Original Message- > From: [email protected] [mailto:core-libs-dev- > [email protected]] On Behalf Of Mandy Chung > Sent: Friday, November 1, 2013 19:16 > To: [email protected] > Subject: JD