+1
Paul.
On Nov 23, 2013, at 8:06 AM, Joe Darcy joe.da...@oracle.com wrote:
Hello Mike and Paul,
Thanks for reviewing the earlier versions of the change; I've posted an
update revision for your consideration at
http://cr.openjdk.java.net/~darcy/8006572.4/
Two numerical aspects of
Changeset: 1f45b24ffe4b
Author:psandoz
Date: 2013-11-25 09:55 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f45b24ffe4b
8028516: Java doc error in Int/Long/Double/Stream.peek
Reviewed-by: chegar
! src/share/classes/java/util/stream/DoubleStream.java
!
HI David,
Just curious: why did you chose to add the method, throwIllegalAccessError, to
s.m.Unsafe and add Unsafe to the list pre-loaded classes rather than modifying
an existing pre-loaded class?
Paul.
Sherman can answer this best. The 8008386 fix for 8 differs from earlier
updates since alot of the code was rewritten in this area. The initial
report was identified as a regression in JDK6. Back in 2005, the 6227339
fix changed behaviour which meant that invalid single byte characters
were
Hi Peter,
I filed: https://bugs.openjdk.java.net/browse/JDK-8029100
Thanks!
cheers
/Joel
On 2013-11-05, Peter Levart wrote:
Hi John,
Speaking of names, the following test:
package pkg;
public class Test {
public static void main(String[] args)
{
Runnable r = () -
On Nov 23, 2013, at 3:00 AM, Andrew Haley wrote:
We've been doing fairly extensive micro-benchmark testing of the
effect of adjusting the various algorithm crossover thresholds in
BigInteger (cf. https://bugs.openjdk.java.net/browse/JDK-8022181).
Out of interest, is this x86, sparc, or
On Nov 23, 2013, at 4:04 AM, Dmitry Nadezhin wrote:
Time complexity of Knuth divide a/b=q approximately the same as
complexity of school multiplication b*q and is
length(b)*length(q) = length(b) * (length(a) - length(b)).
So the new heuristic seems reasonable for me.
Thanks, Dima.
Brian
On 10/16, I wrote:
If you look at the current classes (b111) that have documented
annotations,
the first annotation is correctly left-aligned but all others are indented
by one space. If this is already reported, my apologies; if not, please
confirm.
Example:
Hi, Volker,
just a few very minor comments about the client changes:
1. mlib_sys.c: the change is fine, but it makes the following comment
obsolete.
2. XRBackendNative.c: the same comment here.
3. Awt2dLibraries.gmk: $(JDK_TOPDIR)/src/aix/porting/porting_aix.c would
be better than just
On 25/11/2013 15:43, Paul Benedict wrote:
On 10/16, I wrote:
If you look at the current classes (b111) that have documented
annotations,
the first annotation is correctly left-aligned but all others are indented
by one space. If this is already reported, my apologies; if not, please
confirm.
Changeset: 774c63629870
Author:cl
Date: 2013-11-14 09:05 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/774c63629870
Added tag jdk8-b116 for changeset 0fb1a427fbf6
! .hgtags
Changeset: 1db3d4e4d189
Author:lana
Date: 2013-11-15 07:16 -0800
URL:
Changeset: 7299367c8aa4
Author:cl
Date: 2013-11-14 09:04 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/7299367c8aa4
Added tag jdk8-b116 for changeset 5fdc44652089
! .hgtags
Changeset: e53d1ee4d2ae
Author:lana
Date: 2013-11-14 23:33 -0800
URL:
Changeset: fe56ba456fd3
Author:cl
Date: 2013-11-14 09:05 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/fe56ba456fd3
Added tag jdk8-b116 for changeset 587560c222a2
! .hgtags
Changeset: 76a598cf50c4
Author:cl
Date: 2013-11-21 09:22 -0800
URL:
Changeset: 64d119680f0a
Author:cl
Date: 2013-11-14 09:05 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/64d119680f0a
Added tag jdk8-b116 for changeset 3c040b04af05
! .hgtags
Changeset: 19de039a03a6
Author:lana
Date: 2013-11-15 07:15 -0800
URL:
Changeset: c1029b02ca87
Author:ihse
Date: 2013-11-08 09:36 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/rev/c1029b02ca87
8027836: Webrev should handle files that has been moved from a directory which
now is removed.
Reviewed-by: mduigou, tbell
! make/scripts/webrev.ksh
Changeset: c1d234d4f164
Author:cl
Date: 2013-11-14 09:05 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c1d234d4f164
Added tag jdk8-b116 for changeset e757eb9aee3d
! .hgtags
Changeset: e4e5069250e7
Author:cl
Date: 2013-11-21 09:22 -0800
URL:
No, I didn't know such a list existed. But I do now :-) Thanks. I will send
the message there.
On Mon, Nov 25, 2013 at 1:07 PM, Alan Bateman alan.bate...@oracle.comwrote:
On 25/11/2013 15:43, Paul Benedict wrote:
On 10/16, I wrote:
If you look at the current classes (b111) that have
Changeset: bdcba4854576
Author:erikj
Date: 2013-11-07 10:51 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bdcba4854576
8027698: Platform specific jars are not being signed by the sign-jars target
Reviewed-by: ihse, tbell, wetmore
! makefiles/SignJars.gmk
Changeset:
Hi Volker,
The security changes look fine. I'm not crazy that we now have to
maintain one additional java.security file which is the exact same as
java.security-linux, but this is really an existing issue with
duplicated content across the java.security files which I will try to
fix early in
On 11/23/2013 6:38 AM, Alan Bateman wrote:
On 21/11/2013 10:48, Patrick Zhang wrote:
Hi Alan,
I have renamed jdk8004476 to 8004476. And as Daniel's suggestion,
add some comments to XSLTExFuncTest.java.
I have updated the webrev for review.
http://cr.openjdk.java.net/~pzhang/8027973/webrev/
Hi,
This is a patch to fix an error in StAX factories' newFactory(String
factoryId, ClassLoader classLoader). In the 3 step of the documentation,
it should have stated that the specified ClassLoader is used.
http://cr.openjdk.java.net/~joehw/jdk8/jaxp16MR/webrev/
Thanks,
Joe
On 24/11/2013 17:07, Philippe Marschall wrote:
Hi
The following issue was been bothering me for a while:
When you have an annotation with a value that is an array of classes
[1] and one of those classes can't be loaded with the class loader of
defining class of the element the annotation is
+1
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
On Nov 25, 2013, at 4:51 PM, huizhe wang huizhe.w...@oracle.com wrote:
Hi,
This is a patch to fix an error in
Changeset: abd44ea60dbe
Author:mfang
Date: 2013-11-21 15:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/abd44ea60dbe
8028803: jdk8 l10n resource file translation update 5 - jaxp repo
Reviewed-by: joehw, yhuang
!
Hi Artem,
thanks a lot for your review. Please find my comments inline:
On Monday, November 25, 2013, Artem Ananiev wrote:
Hi, Volker,
just a few very minor comments about the client changes:
1. mlib_sys.c: the change is fine, but it makes the following comment
obsolete.
You're right.
Hi Sean,
thanks a lot for you review.
Please let me know once you start working on 6997010 so I can update the
corresponding AIX file accordingly.
Regards,
Volker
On Monday, November 25, 2013, Sean Mullan wrote:
Hi Volker,
The security changes look fine. I'm not crazy that we now have to
Changeset: 8d5a9245b9ca
Author:valeriep
Date: 2013-11-25 11:56 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d5a9245b9ca
7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to
sign() instead of init()
Summary: Add key length checks to P11Signature
Hi,
I see you've already received a ton of good feedback on this v2.
I have just a few things to add.
I don't know what symlinks might exist on AIX but it seems odd to
me that you have :-
138 static char *fullAixFontPath[] = {
139 /usr/lpp/X11/lib/X11/fonts/Type1,
..
but the paths in the
Changeset: 0bf3a58a1783
Author:joehw
Date: 2013-11-25 16:53 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0bf3a58a1783
8027973: javax/xml/jaxp/transform/jdk8004476/XSLTExFuncTest.java hangs (win)
Reviewed-by: alanb, dfuchs, joehw
Contributed-by: patrick.zh...@oracle.com
+
On Nov 25, 2013, at 1:49 AM, Paul Sandoz paul.san...@oracle.com wrote:
Just curious: why did you chose to add the method, throwIllegalAccessError,
to s.m.Unsafe and add Unsafe to the list pre-loaded classes rather than
modifying an existing pre-loaded class?
Unsafe is used everywhere,
Changeset: a78f51d6bd5e
Author:jjg
Date: 2013-11-25 17:42 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a78f51d6bd5e
8028318: [doclint] doclint will reject existing user-written doc comments using
custom tags that follow the recommended rules
Reviewed-by: darcy
!
On 26/11/2013 11:29 AM, John Rose wrote:
On Nov 25, 2013, at 1:49 AM, Paul Sandoz paul.san...@oracle.com wrote:
Just curious: why did you chose to add the method, throwIllegalAccessError, to
s.m.Unsafe and add Unsafe to the list pre-loaded classes rather than modifying
an existing pre-loaded
Hi Tristan,
Finally getting back to this. Again, sorry for the delay.
The changes look much better now. I've listed a bunch of items below, but
they're all comparatively minor, even nitpicky. But there are a few things that
should be cleaned up before we integrate this.
Items listed below.
On Nov 24 2013, at 16:31 , David Holmes david.hol...@oracle.com wrote:
Hi Mike,
There is still no clear spec for what should happen if the param value is
null.
I feel very uncomfortable the status quo of with null being ignored, used for a
sentinel and also as value. The relations
Hi Stuart
Thanks for your code review. I updated the webrev according your
suggestion. Could you review it again?
http://cr.openjdk.java.net/~ewang/tristan/JDK-7190106/webrev.00/
Tristan
On 11/26/2013 10:36 AM, Stuart Marks wrote:
Hi Tristan,
Finally getting back to this. Again, sorry for
35 matches
Mail list logo
