Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2014-01-20 Thread Peter Levart
On 01/20/2014 02:51 AM, David Holmes wrote: Hi Peter, On 17/01/2014 11:24 PM, Peter Levart wrote: On 01/17/2014 02:13 PM, Peter Levart wrote: // Fast path for cleaners boolean isCleaner = false; try { isCleaner = r instanceof Cleaner; } catch (OutofMemoryError oome) { continue; } if

Re: Review request for JDK-6760902: inconsistent behavior in bootstrap class loader for classes and resources

2014-01-20 Thread Paul Sandoz
On Jan 17, 2014, at 10:10 PM, Mandy Chung mandy.ch...@oracle.com wrote: Paul, Here is the updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6760902/webrev.01/ This cleans up GetResource.sh and merges with GetResource2.sh. Also fixed if (pos - lastPoc 0) line and javadoc

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

2014-01-20 Thread Volker Simonis
On Fri, Jan 17, 2014 at 10:15 PM, Volker Simonis volker.simo...@gmail.com wrote: On Tue, Jan 14, 2014 at 10:19 AM, Alan Bateman alan.bate...@oracle.com wrote: On 14/01/2014 08:40, Volker Simonis wrote: Hi, could you please review the following changes for the ppc-aix-port stage/stage-9

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

2014-01-20 Thread Alan Bateman
On 20/01/2014 09:59, Volker Simonis wrote: : Hi Alan, yes, that's interesting. Sounds like a very similar problem on Mac. I would suggest the following: I cut out the Async Close AIX FIX stuff from this change (i.e. 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests and

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

2014-01-20 Thread Volker Simonis
On Mon, Jan 20, 2014 at 12:41 PM, Alan Bateman alan.bate...@oracle.com wrote: On 20/01/2014 09:59, Volker Simonis wrote: : Hi Alan, yes, that's interesting. Sounds like a very similar problem on Mac. I would suggest the following: I cut out the Async Close AIX FIX stuff from this change

Re: RFR: 8032190 It's unclear that flatMap will ensure each stream will be closed.

2014-01-20 Thread Chris Hegarty
It is good to clarify that the streams are closed. I find the following updated wording a little odd, If a mapped stream is {@code null} then it treated as if it was an empty stream. I thought the previous wording was better, but that could be just me. -Chris. On 20/01/14 10:38, Paul Sandoz

Re: RFR [8027348] (process) Enhancement of handling async close of ProcessInputStream

2014-01-20 Thread Ivan Gerasimov
Hello everybody! Can I consider this change approved for jdk9? Thanks in advance, Ivan Gerasimov On 20.11.2013 0:56, Martin Buchholz wrote: Ivan, Thanks for taking ownership of my proposed change. Looks good to me! (I can't actually push changes like this myself because I only do Linux

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

2014-01-20 Thread Alan Bateman
On 20/01/2014 13:45, Volker Simonis wrote: : Hi everybody, so here's the second version of this webrev: http://cr.openjdk.java.net/~simonis/webrevs/8031581_2/ This looks okay to me. The typo (legel - legal) still exists in zip_util.c and maybe that can be fixed before you push this (no need

Re: RFR: 8032190 It's unclear that flatMap will ensure each stream will be closed.

2014-01-20 Thread Paul Sandoz
On Jan 20, 2014, at 3:18 PM, Chris Hegarty chris.hega...@oracle.com wrote: It is good to clarify that the streams are closed. I find the following updated wording a little odd, If a mapped stream is {@code null} then it treated as if it was an empty stream. I thought the previous wording

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

2014-01-20 Thread Volker Simonis
On Mon, Jan 20, 2014 at 4:24 PM, Alan Bateman alan.bate...@oracle.com wrote: On 20/01/2014 13:45, Volker Simonis wrote: : Hi everybody, so here's the second version of this webrev: http://cr.openjdk.java.net/~simonis/webrevs/8031581_2/ This looks okay to me. Thanks. The typo (legel -

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

2014-01-20 Thread Alan Bateman
On 20/01/2014 16:29, Volker Simonis wrote: : @Alan: on the other hand, the bulk integration from ppc-aix-port/stage-9 to jdk9/dev is planned for next week anyway, so maybe you could wait until that happens? In that case then ignore my request, I assumed it would not be pushed to jdk9/dev

Re: RFR: JDK-8032012, , String.toLowerCase/toUpperCase performance improvement

2014-01-20 Thread Paul Sandoz
On Jan 16, 2014, at 7:08 PM, Xueming Shen xueming.s...@oracle.com wrote: Hi, The proposed changeset is to improve the performance (both speed and memory usage) of String.toLowerCase/toUpperCase, by (1) to separate the most likely use scenario (non supplementary character, no special

Re: JDK 9 RFR for 8031980: Add new j.u.l deadlock test for JDK-8027670 and JDK-8029281

2014-01-20 Thread Mandy Chung
On 1/17/2014 6:51 AM, Daniel Fuchs wrote: Hi, Please find below a webrev for: 8031980: Add new j.u.l deadlock test for JDK-8027670 and JDK-8029281 https://bugs.openjdk.java.net/browse/JDK-8031980 http://cr.openjdk.java.net/~dfuchs/webrev_8031980/webrev.00/ The new test looks reasonable.

Re: JDK 9 RFR for 8031980: Add new j.u.l deadlock test for JDK-8027670 and JDK-8029281

2014-01-20 Thread Daniel Fuchs
On 1/20/14 7:17 PM, Mandy Chung wrote: On 1/17/2014 6:51 AM, Daniel Fuchs wrote: Hi, Please find below a webrev for: 8031980: Add new j.u.l deadlock test for JDK-8027670 and JDK-8029281 https://bugs.openjdk.java.net/browse/JDK-8031980

Re: JDK 9 RFR for 8031980: Add new j.u.l deadlock test for JDK-8027670 and JDK-8029281

2014-01-20 Thread Mandy Chung
On 1/20/2014 10:35 AM, Daniel Fuchs wrote: On 1/20/14 7:17 PM, Mandy Chung wrote: On 1/17/2014 6:51 AM, Daniel Fuchs wrote: Hi, Please find below a webrev for: 8031980: Add new j.u.l deadlock test for JDK-8027670 and JDK-8029281 https://bugs.openjdk.java.net/browse/JDK-8031980

Re: RFR: 8032190 It's unclear that flatMap will ensure each stream will be closed.

2014-01-20 Thread Chris Hegarty
On 20 Jan 2014, at 15:18, Paul Sandoz paul.san...@oracle.com wrote: On Jan 20, 2014, at 3:18 PM, Chris Hegarty chris.hega...@oracle.com wrote: It is good to clarify that the streams are closed. I find the following updated wording a little odd, If a mapped stream is {@code null}

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2014-01-20 Thread Peter Levart
On 01/21/2014 03:22 AM, David Holmes wrote: Hi Peter, I do not see Cleaner being loaded prior to the main class on either Windows or Linux. Which platform are you on? Did you see it loaded before the main class or as part of executing it? Before. The main class is empty: public class Test