On 22/01/2014 01:17, Joe Darcy wrote:
Hi Alan,
Updated webrev at
http://cr.openjdk.java.net/~darcy/8032397.1/
@see in sun.misc.Ref removed.
Regression tests updated to not refer to sun.misc.Ref.
I looked at the use of Ref in jhat and it is only used if
java.lang.ref.Reference is not
Changeset: ff56039c4870
Author:erikj
Date: 2014-01-22 12:13 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff56039c4870
8032217: failure in man page processing
Reviewed-by: dholmes, tbell
! make/Images.gmk
Kumar,
see my notes inline.
On 1/21/14 20:11, Kumar Srinivasan wrote:
Alex,
Thanks for adding the test, few comments:
PackTestZip64.java:
1. compareTwoFile, I would read the entire file into
ByteArrayInputStream, compare
the total first ie. fast fail, but what you have is also ok.
I've
On 01/14/2014 01:26 AM, mark.reinh...@oracle.com wrote:
Posted: http://openjdk.java.net/jeps/187
There's another aspect of the current approach to serialization that is
not mentioned: the type information does not come from the calling
context, but exclusively from the input stream. This
On 22/01/14 13:57, Florian Weimer wrote:
On 01/14/2014 01:26 AM, mark.reinh...@oracle.com wrote:
Posted: http://openjdk.java.net/jeps/187
There's another aspect of the current approach to serialization that is
not mentioned: the type information does not come from the calling
context, but
On 01/22/2014 03:47 PM, Chris Hegarty wrote:
On 22/01/14 13:57, Florian Weimer wrote:
On 01/14/2014 01:26 AM, mark.reinh...@oracle.com wrote:
Posted: http://openjdk.java.net/jeps/187
There's another aspect of the current approach to serialization that is
not mentioned: the type information
On Jan 21, 2014, at 11:05 PM, Xueming Shen xueming.s...@oracle.com wrote:
Hi Paul, thanks for reviewing the changeset, comment inlined below.
On 01/20/2014 09:24 AM, Paul Sandoz wrote:
Some quick comments.
In String.toLowerCase:
- it would be nice to get rid of the pseudo goto using
On 01/13/2014 06:26 PM, mark.reinh...@oracle.com wrote:
Posted: http://openjdk.java.net/jeps/187
The concept of explicit deserialization constructors is interesting and
is something I've explored a little bit in the context of JBoss Marshalling.
The way construction works today (simple
Looks good to me Aleksej. Hopefully you can get a reviewer from the i18n
dev team also.
regards,
Sean.
On 21/01/14 13:17, Aleksej Efimov wrote:
Hi,
Can I have a review for 2013i timezone data integration [1] to JDK9.
There is one change in tzdb that affects naming for Asia/Amman
timezone:
Alex,
I am satisfied.
Thanks
Kumar
Kumar,
see my notes inline.
On 1/21/14 20:11, Kumar Srinivasan wrote:
Alex,
Thanks for adding the test, few comments:
PackTestZip64.java:
1. compareTwoFile, I would read the entire file into
ByteArrayInputStream, compare
the total first ie. fast
Please review this javadoc improvement to add @param tags to readObject
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-time-param-8032502/
Thanks, Roger
looks fine Roger as am sure this will make the doclint warnings less
On Jan 22, 2014, at 4:26 PM, roger riggs wrote:
Please review this javadoc improvement to add @param tags to readObject
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-time-param-8032502/
Thanks, Roger
Lance
On 01/22/2014 01:26 PM, roger riggs wrote:
Please review this javadoc improvement to add @param tags to readObject
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-time-param-8032502/
Thanks, Roger
Hi Roger,
I'll approve this if you either
* replace codeObjectInputStream/code with
Am 22.01.2014 um 17:33 schrieb David M. Lloyd david.ll...@redhat.com:
The concept of explicit deserialization constructors is interesting and is
something I've explored a little bit in the context of JBoss Marshalling.
...
The idea with a serialization-aware constructor is that each
Thanks for the reminder Joe, I updated the webrev with the 2nd, shorter
version.
Roger
On 1/22/2014 4:33 PM, Joe Darcy wrote:
On 01/22/2014 01:26 PM, roger riggs wrote:
Please review this javadoc improvement to add @param tags to readObject
Webrev:
Hi,
I would like to backport this fix from 8 to 7u.
https://bugs.openjdk.java.net/browse/JDK-7199674
The source code changes apply cleanly to 7u from the 8 changeset,
however the makefile changes needed to be tweaked.
makefiles/CompileNativeLibraries.gmk did not exist in 7, so equivalent
On 01/22/2014 01:39 PM, roger riggs wrote:
Thanks for the reminder Joe, I updated the webrev with the 2nd,
shorter version.
Ship it :-)
-Joe
Roger
On 1/22/2014 4:33 PM, Joe Darcy wrote:
On 01/22/2014 01:26 PM, roger riggs wrote:
Please review this javadoc improvement to add @param tags
Am 22.01.2014 16:20, schrieb Paul Sandoz:
On Jan 21, 2014, at 11:05 PM, Xueming Shen xueming.s...@oracle.com wrote:
On 01/20/2014 09:24 AM, Paul Sandoz wrote:
- it would be nice to get rid of the pseudo goto using the scan labelled
block.
webrev has been updated to remove the pseudo goto by
I found another location in OOS code that might be an optimization point:
In java.io.ObjectOutputStream.BlockDataOutputStream#write(byte[], int, int,
boolean) the first lines look like this:
if (!(copy || blkmode)) { // write directly
drain();
Is there any documentation available which optimizations Hotspot can perform
and what collecting a garbage object costs?
I know that these are two completely different areas ;)
I was inspecting whether the following code
for (Object o : someArrayList) { ... }
would be faster than
for
(forgot to include macosx-port-...@openjdk.java.net)
Hi,
I would like to backport this fix from 8 to 7u.
https://bugs.openjdk.java.net/browse/JDK-7199674
The source code changes apply cleanly to 7u from the 8 changeset,
however the makefile changes needed to be tweaked.
You can start here:
wikis.oracle.com/display/hotspotinternals/performancetechniques
Sent from my phone
On Jan 22, 2014 5:37 PM, Robert Stupp sn...@snazy.de wrote:
Is there any documentation available which optimizations Hotspot can
perform and what collecting a garbage object costs?
I know
On 1/21/2014 5:17 PM, Joe Darcy wrote:
Hi Alan,
Updated webrev at
http://cr.openjdk.java.net/~darcy/8032397.1/
Looks good to me.
@see in sun.misc.Ref removed.
Regression tests updated to not refer to sun.misc.Ref.
I looked at the use of Ref in jhat and it is only used if
I need help.
I am trying to do control build in JPRT after I merged latest jdk9 source:
http://hg.openjdk.java.net/jdk9/jdk9
to latest ppc64 sources:
http://hg.openjdk.java.net/ppc-aix-port/stage-9
I have build failure on Mac OS X (on other platforms it passed). See the
output below. I
Changeset: 57c26829deb6
Author:mullan
Date: 2014-01-22 19:06 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/57c26829deb6
8031825: OCSP client can't find responder cert if it uses a different subject
key id algorithm than responderID
Reviewed-by: vinnie, xuelei
!
I haven't tried this, but Tim Bell mentioned this in an email inquiry I
had earlier,
This will be cured when the fix for 8021266 is pushed to JDK 9 (see
attached).
In the meantime, the workaround in JPRT is to submit your JDK 9 jobs
with '-bootproduct jdk7u7' since the 7u51 release can not
Remi,
Regarding your last point - picking correct data structures and algos is of
course step 1 in any optimization. But, provided that's taken care of,
there're plausible reasons to attempt to cater to hotspot as well (if
that's the jvm in use). There are certainly code shapes that it prefers.
Thank you very much, Henry
The suggested workaround helped!
Thanks,
Vladimir
On 1/22/14 4:18 PM, Henry Jen wrote:
I haven't tried this, but Tim Bell mentioned this in an email inquiry I
had earlier,
This will be cured when the fix for 8021266 is pushed to JDK 9 (see
attached).
In the
Hi Aleksej,
I think this one is the first tzdata change for JDK9. So I'd suggest
that all the TimeZoneNames*.properties files, which were temporarily
created for the translation work, be removed.
Thanks,
Masayoshi
On 1/21/2014 10:17 PM, Aleksej Efimov wrote:
Hi,
Can I have a review for
29 matches
Mail list logo
