Hi Martin,
As you might have seen in my later reply to Roger, there's still hope on
that front: setpgid() + wait(-pgid, ...) might be the answer. I'm
exploring in that direction. Shells are doing it, so why can't JDK?
It's a little trickier for Process API, since I imagine that shells form
On Apr 8, 2014, at 9:15 PM, Mike Duigou mike.dui...@oracle.com wrote:
For the case of incorrect signed comparison is it sticking around because
there is code dependent on the current broken behaviour?
Probably even if the dependence is implicit such as expecting a particular
iteration
Hello,
Could you please review the fix for the following bug:
https://bugs.openjdk.java.net/browse/JDK-8039488
Webrev corresponding:
http://cr.openjdk.java.net/~yan/8039488/webrev.00/
Just a minor cleanup of javadoc to avoid tidy warnings; no other code
affected.
Thanks.
Regards,
Alexander
I think this looks ok but a couple of suggestions
src/share/classes/javax/sql/rowset/spi/package.html - The URL links at the
bottom of the page need updated, please address them as part of this putback if
possible
src/share/classes/javax/sql/package.html - I would use trade; as part of the
On Apr 8, 2014, at 4:53 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
Paul, thanks for the feedback!
See my answers inline.
Updated webrevs:
http://cr.openjdk.java.net/~vlivanov/8037209/webrev.03/
http://cr.openjdk.java.net/~vlivanov/8038261/webrev.02/
Both look OK.
Is
Hello Lance,
Thanks; please see the updated webrev:
http://cr.openjdk.java.net/~yan/8039488/webrev.01/
Regards,
Alexander
On 09.04.2014 14:10, Lance @ Oracle wrote:
I think this looks ok but a couple of suggestions
*src/share/classes/javax/sql/rowset/spi/package.html - *The URL links
at
Hi Peter,
On a related topic, the request to be able to destroy a Process and all
of its children
might also want to used the group pid to be able to identify all of the
children.
Roger
On 4/9/2014 2:08 AM, Peter Levart wrote:
Hi Martin,
As you might have seen in my later reply to Roger,
java.util.concurrent.ConcurrentMap contains several broken links to
Collection.html#optional-restrictions. See
http://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ConcurrentMap.html
The issue is caused by the use of '{@inheritDoc}' in many '@throws'
definitions. ConcurrentMap's
Hi Alexander,
looks fine.
Best
Lance
On Apr 9, 2014, at 7:58 AM, alexander stepanov
alexander.v.stepa...@oracle.com wrote:
Hello Lance,
Thanks; please see the updated webrev:
http://cr.openjdk.java.net/~yan/8039488/webrev.01/
Regards,
Alexander
On 09.04.2014 14:10, Lance @ Oracle
Hi.
I'd like to ask for review of this fix:
http://cr.openjdk.java.net/~shurailine/8039438/webrev.00/
Bug:
https://bugs.openjdk.java.net/browse/JDK-8039438
Thank you.
Shura
Hi Shura,
On 4/9/2014 9:00 AM, Alexandre (Shura) Iline wrote:
Hi.
I'd like to ask for review of this fix:
http://cr.openjdk.java.net/~shurailine/8039438/webrev.00/
It's good to see this dependency be removed from the tests. Looks
reasonable. I'll sponsor this change.
Mandy
On re-read, I believe extending the sync block in read(..) to cover the
reading and setting of the rem variable works to resolve this fix. It
should preserve behaviour as well.
http://cr.openjdk.java.net/~coffeys/webrev.8038491.v2/webrev/
regards,
Sean.
On 08/04/14 21:28, Seán Coffey wrote:
Approved. Looks good to me.
-Chris
On 09/04/14 18:39, Seán Coffey wrote:
On re-read, I believe extending the sync block in read(..) to cover the
reading and setting of the rem variable works to resolve this fix. It
should preserve behaviour as well.
On 09/04/14 18:22, Mandy Chung wrote:
Hi Shura,
On 4/9/2014 9:00 AM, Alexandre (Shura) Iline wrote:
Hi.
I'd like to ask for review of this fix:
http://cr.openjdk.java.net/~shurailine/8039438/webrev.00/
It's good to see this dependency be removed from the tests.
+1.
-Chris.
Looks
On 09/04/2014 18:39, Seán Coffey wrote:
On re-read, I believe extending the sync block in read(..) to cover
the reading and setting of the rem variable works to resolve this fix.
It should preserve behaviour as well.
http://cr.openjdk.java.net/~coffeys/webrev.8038491.v2/webrev/
This is
On 09/04/2014 15:07, Chris Hegarty wrote:
java.util.concurrent.ConcurrentMap contains several broken links to
Collection.html#optional-restrictions. See
http://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ConcurrentMap.html
The issue is caused by the use of '{@inheritDoc}' in
On 9 Apr 2014, at 20:10, Seán Coffey sean.cof...@oracle.com wrote:
On 09/04/14 19:36, Alan Bateman wrote:
On 09/04/2014 18:39, Seán Coffey wrote:
On re-read, I believe extending the sync block in read(..) to cover the
reading and setting of the rem variable works to resolve this fix. It
Hi,
Please help review the fix for JDK-8039751.
Issue: https://bugs.openjdk.java.net/browse/JDK-8039751
webrev: http://cr.openjdk.java.net/~sherman/8039751/webrev/
This is the corner case (in 4 bytes sequence) we missed when fixing 7096080 [1].
The UTF_8 decoder correctly returns the
On 09/04/14 22:16, Alan Bateman wrote:
On 09/04/2014 20:10, Seán Coffey wrote:
I played around with adding some skip testing Alan but didn't see it
increase the rate of failure on an unpatched binary. Since
ZipFileInputStream.read(..) is the trouble method and now has better
synchronized
Hello,
Issue: https://bugs.openjdk.java.net/browse/JDK-8039474
Patch: http://cr.openjdk.java.net/~bpb/8039474/webrev.00/
The change is to specify the charset for the String where none had been before.
The extant test sun/misc/Encode/GetBytes.java appears to suffice for this.
Thanks,
Brian
Hello,
I've started looking at cleaning up the fallthrough lint warnings in the
jdk repo. Please review the affected files in the other libs area:
JDK-8039864: Fix fallthrough lint warnings in other libs
http://cr.openjdk.java.net/~darcy/8039864.0/
Thanks,
-Joe
---
21 matches
Mail list logo
