RFR 9: JDK-8040892 Incorrect message in Exception thrown by Collectors.toMap(Function, Function)

2014-04-23 Thread Peter Levart
Hi, I propose a patch for: https://bugs.openjdk.java.net/browse/JDK-8040892 Here's the webrev: http://cr.openjdk.java.net/~plevart/jdk9-dev/Collectors.duplicateKey/webrev.02/ There has already been a discussion on the lambda-dev about this bug:

Re: JDK 9 RFR of 8026236: Add PrimeTest for BigInteger [TEST-ONLY]

2014-04-23 Thread Paul Sandoz
On Apr 23, 2014, at 1:48 AM, Brian Burkhalter brian.burkhal...@oracle.com wrote: Hello, Issue:https://bugs.openjdk.java.net/browse/JDK-8026236 Patch:http://cr.openjdk.java.net/~bpb/8026236/webrev.00/ This test provides a rudimentary verification of isProbablePrime() by:

Re: RFR: 8000975: (process) Merge UNIXProcess.java.bsd UNIXProcess.java.linux ( .solaris .aix)

2014-04-23 Thread Paul Sandoz
Hi Peter, IMHO such security manager usage by the test is v. fragile and we should try and find a safer alternative if possible. However, there may also be an issue with lambda form code. (About a month ago i too was looking, internally, at this kind of issue and thought there was a

Re: JDK 9 RFR of 8026236: Add PrimeTest for BigInteger [TEST-ONLY]

2014-04-23 Thread Peter Levart
Hi Brian, There seems to be a confusion between upperBound and the 1st n primer numbers. You pass upperBound as the parameter n of the parsePrimes() method which returns 1st n primes from the file (it can return less primes if the file is smaller). I suggest doing the following: - make

Re: JDK-8036003: Add variable not to separate debug information.

2014-04-23 Thread Omair Majid
Hi, * Yasumasa Suenaga yasue...@gmail.com [2014-04-04 10:56]: I've succeeded to make binaries which are contained debuginfo as following: http://mail.openjdk.java.net/pipermail/build-dev/2014-March/012037.html $ make images STRIP_POLICY=no_strip POST_STRIP_CMD= I guess that we should run

Re: RFR: JDK-8039751: UTF-8 decoder fails to handle some edge cases correctly

2014-04-23 Thread Mark Thomas
On 09/04/2014 15:51, Xueming Shen wrote: Hi, Please help review the fix for JDK-8039751. Issue: https://bugs.openjdk.java.net/browse/JDK-8039751 webrev: http://cr.openjdk.java.net/~sherman/8039751/webrev/ This is the corner case (in 4 bytes sequence) we missed when fixing

StringBuilder instead of StringBuffer in java.util package

2014-04-23 Thread Otávio Gonçalves de Santana
diff -r 57c1da89ae1a src/share/classes/java/util/prefs/Base64.java --- a/src/share/classes/java/util/prefs/Base64.java Wed Apr 16 12:32:36 2014 -0700 +++ b/src/share/classes/java/util/prefs/Base64.java Mon Apr 21 20:20:57 2014 -0300 @@ -57,7 +57,7 @@ int numFullGroups = aLen/3;

getFirst and getLast on Iterable

2014-04-23 Thread Otávio Gonçalves de Santana
I would to add for news methods on Iterable, I believe it will helpful for many Java Developers. diff -r 3dd165facde7 test/java/util/Iterator/IteratorDefaults.java --- a/test/java/util/Iterator/IteratorDefaults.java Wed Apr 09 12:26:00 2014 -0700 +++

Conditions with that always returns true is 'if' necessary?

2014-04-23 Thread Otávio Gonçalves de Santana
Hello everyone, one question. Conditions that always returns true, is 'if' necessary? I found one. diff -r 57c1da89ae1a src/share/classes/java/lang/invoke/BoundMethodHandle.java --- a/src/share/classes/java/lang/invoke/BoundMethodHandle.java Wed Apr 16 12:32:36 2014 -0700 +++

Re: getFirst and getLast on Iterable

2014-04-23 Thread Brian Goetz
Didn’t we just discuss this like a week ago? http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-April/026506.html On Apr 17, 2014, at 12:30 AM, Otávio Gonçalves de Santana otaviopolianasant...@gmail.com wrote: I would to add for news methods on Iterable, I believe it will helpful

Re: getFirst and getLast on Iterable

2014-04-23 Thread Otávio Gonçalves de Santana
Yes I did a mistake, please ignore. I sent twice but it had one week as delay. Sorry On Apr 23, 2014 2:01 PM, Brian Goetz brian.go...@oracle.com wrote: Didn’t we just discuss this like a week ago? http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-April/026506.html On Apr 17, 2014,

Re: Review request: 8040059 Change default policy for extensions to no permission

2014-04-23 Thread Sean Mullan
Just a few comments: 1. When you write a test that uses the jtreg /policy option, the policy file overrides the system policy file. If the test depends on a standard extension, then you may get SecurityExceptions unless additional perms are granted. Thus, there are quite a few tests that

Re: Review request: 8040059 Change default policy for extensions to no permission

2014-04-23 Thread Mandy Chung
On 4/23/2014 1:10 PM, Sean Mullan wrote: Just a few comments: 1. When you write a test that uses the jtreg /policy option, the policy file overrides the system policy file. If the test depends on a standard extension, then you may get SecurityExceptions unless additional perms are granted.

Re: RFR: 8035584: (s) ArrayList(c) should avoid inflation if c is empty

2014-04-23 Thread Mike Duigou
On Mar 13 2014, at 08:56 , Jason Mehrens jason_mehr...@hotmail.com wrote: Mike, The constructor modification looks good. The only other alternative I can think would be to use 'c.toArray(EMPTY_ELEMENTDATA)' to avoid creating an extra array. I'm guessing that version would not perform

Re: RFR: 8035584: (s) ArrayList(c) should avoid inflation if c is empty

2014-04-23 Thread Mike Duigou
On Mar 13 2014, at 09:53 , Martin Buchholz marti...@google.com wrote: It's time to add general purpose public static final empty arrays to Arrays.java for Object, all the primitive types, and perhaps also String, instead of local copies scattered around the JDK; then have ArrayList use

RFR: 8035584 : (s) ArrayList(c) should avoid inflation if c is empty

2014-04-23 Thread Mike Duigou
Hello all; Revisiting this issue again at long last I have updated the proposed changeset based upon Jason Mehren's most recent feedback. http://cr.openjdk.java.net/~mduigou/JDK-8035584/4/webrev/ This version reverts the prior changes to toArray(). Mike

pre-RFR : 8022854: (s) System.setProperties(null) causes implementation private properties to reappear

2014-04-23 Thread Mike Duigou
At long last I got back to this issue and discovered that there are some lurking issues with property reinitialization. I've created a couple of bugs for some of the shortcomings I discovered. None of these are caused by this changeset. I would like to hold off completing this issue until we