Re: JDK 9 RFR of 8043916: Fix fallthrough lint warnings in java/lang/UNIXProcess.java

2014-05-23 Thread Alan Bateman
On 23/05/2014 20:01, Joe Darcy wrote: Hello, Please review the patch below to address 8043916: Fix fallthrough lint warnings in java/lang/UNIXProcess.java Looks okay. -Alan

Re: JDK 9 RFR of 8043916: Fix fallthrough lint warnings in java/lang/UNIXProcess.java

2014-05-23 Thread Lance Andersen
+1 On May 23, 2014, at 3:01 PM, Joe Darcy wrote: > Hello, > > Please review the patch below to address > >8043916: Fix fallthrough lint warnings in java/lang/UNIXProcess.java > > diff -r f142c0938978 src/solaris/classes/java/lang/UNIXProcess.java > --- a/src/solaris/classes/java/lang/UNIXP

JDK 9 RFR of 8043916: Fix fallthrough lint warnings in java/lang/UNIXProcess.java

2014-05-23 Thread Joe Darcy
Hello, Please review the patch below to address 8043916: Fix fallthrough lint warnings in java/lang/UNIXProcess.java diff -r f142c0938978 src/solaris/classes/java/lang/UNIXProcess.java --- a/src/solaris/classes/java/lang/UNIXProcess.javaFri May 23 09:05:24 2014 -0700 +++ b/src/solaris/

Re: RFR (S) 8035974: Refactor DigestBase.engineUpdate() method for better code generation by JIT compiler

2014-05-23 Thread Vladimir Kozlov
Thank you, Paul, Remi, Anthony, for reviews. I changed "protected final" to "private" as suggested: http://cr.openjdk.java.net/~kvn/8035974/webrev.01 Note, JIT inlines final and private methods without generation a method's class check. So inlined code is the same. Thanks, Vladimir On 5/23/

Re: RFR (S) 8035974: Refactor DigestBase.engineUpdate() method for better code generation by JIT compiler

2014-05-23 Thread james cheng
On 5/23/2014 3:17 AM, Remi Forax wrote: On 05/23/2014 11:06 AM, Paul Sandoz wrote: On May 22, 2014, at 1:34 AM, Vladimir Kozlov wrote: http://cr.openjdk.java.net/~kvn/8035974/webrev https://bugs.openjdk.java.net/browse/JDK-8035974 Contributed by James Cheng and modified by me. Looks good

Re: RFR - 8041451: com.sun.jndi.ldap.Connection:ReadTimeout should abandon ldap request

2014-05-23 Thread Vincent Ryan
That fix looks fine. Thanks. On 23 May 2014, at 18:08, Rob McKenna wrote: > Hi folks, > > Very simple fix to ensure that a slow server isn't left waiting around for a > request we have already given up on. > > http://cr.openjdk.java.net/~robm/8041451/webrev.01/ > >-Rob >

RFR - 8041451: com.sun.jndi.ldap.Connection:ReadTimeout should abandon ldap request

2014-05-23 Thread Rob McKenna
Hi folks, Very simple fix to ensure that a slow server isn't left waiting around for a request we have already given up on. http://cr.openjdk.java.net/~robm/8041451/webrev.01/ -Rob

Re: RFR: 8043666: Remove unused files from jaxp repository

2014-05-23 Thread Alan Bateman
On 23/05/2014 16:23, huizhe wang wrote: Removing unused files in jaxp repository. Most of them are META-INF/services files used by Apache build process. The COPYING files at the bottom came with SAX, but they are included in the THIRD_PARTY_README file already. Please review. http://cr.openj

RFR: 8043666: Remove unused files from jaxp repository

2014-05-23 Thread huizhe wang
Removing unused files in jaxp repository. Most of them are META-INF/services files used by Apache build process. The COPYING files at the bottom came with SAX, but they are included in the THIRD_PARTY_README file already. Please review. http://cr.openjdk.java.net/~joehw/jdk9/8043666/webrev/

Re: RFR (S) 8035974: Refactor DigestBase.engineUpdate() method for better code generation by JIT compiler

2014-05-23 Thread Anthony Scarpino
This looks fine to me Tony > On May 21, 2014, at 4:34 PM, Vladimir Kozlov > wrote: > > http://cr.openjdk.java.net/~kvn/8035974/webrev > https://bugs.openjdk.java.net/browse/JDK-8035974 > > Contributed by James Cheng and modified by me. > > To use intrinsics to accelerate SHA operations on mu

Re: RFR (S) 8035974: Refactor DigestBase.engineUpdate() method for better code generation by JIT compiler

2014-05-23 Thread Remi Forax
On 05/23/2014 11:06 AM, Paul Sandoz wrote: On May 22, 2014, at 1:34 AM, Vladimir Kozlov wrote: http://cr.openjdk.java.net/~kvn/8035974/webrev https://bugs.openjdk.java.net/browse/JDK-8035974 Contributed by James Cheng and modified by me. Looks good to me. Paul. implCompressMultiBlock sh

Re: RFR (S) 8035974: Refactor DigestBase.engineUpdate() method for better code generation by JIT compiler

2014-05-23 Thread Paul Sandoz
On May 22, 2014, at 1:34 AM, Vladimir Kozlov wrote: > http://cr.openjdk.java.net/~kvn/8035974/webrev > https://bugs.openjdk.java.net/browse/JDK-8035974 > > Contributed by James Cheng and modified by me. > Looks good to me. Paul. > To use intrinsics to accelerate SHA operations on multiple b