Hi Eric, Martin,
I'm fine with the re-write. I'm not sure why the re-ordering of y3 will
change the
behavior of the test but it will provide more debugging info.
Roger
On 6/6/2014 9:32 PM, Martin Buchholz wrote:
If you don't want to go with my rewrite, you can conservatively just
check in
Hi Joe,
IIRC name isn’t actually interned with String.intern() but in the VM:s Symbol
table as a name representing a (Java) method. Should be equivalent, as long as
we don’t start comparing it with == with interned Strings. As Andrej wrote,
this is just refactoring of the previous code, to
Hi Joel,
IIRC name isn’t actually interned with String.intern() but in the VM:s Symbol
table as a name representing a (Java) method. Should be equivalent, as long
as we don’t start comparing it with == with interned Strings.
I think that's not true.
The following small test program prints
Hi,
Please review a trivial webrev that provides missing @since tag for
elements under javax.sql,
javax.sql.CommonDataSource was extracted out since 1.6, methods have
@since 1.4 tag because those methods existed in origins since then.
Thanks for the investigation Andrej.
In any case, I'd prefer a comment noting the interned-ness (or mostly
interned-ness, etc.) of the name to let other readers of the code using
== rather than .equals is intentional and not a bug.
Thanks,
-Joe
On 06/09/2014 12:56 PM, Andrej Golovnin
