Re: RFR 9 and 8u: JDK-8029674: (reflect) getMethods returns default methods that are not members of the class

2014-06-10 Thread Peter Levart
Hi Joel, I don't know if this is warranted, since this is on slow path (the resulting methods are cached) and the number of overloaded methods is typically not large, but the following MethodArray method: 2803 private boolean matchesNameAndDescriptor(Method m1, Method m2) { could

Re: RFR 9 and 8u: JDK-8029674: (reflect) getMethods returns default methods that are not members of the class

2014-06-10 Thread Joel Borggrén-Franck
Hi Andrej, On 9 jun 2014, at 21:56, Andrej Golovnin andrej.golov...@gmail.com wrote: Hi Joel, IIRC name isn’t actually interned with String.intern() but in the VM:s Symbol table as a name representing a (Java) method. Should be equivalent, as long as we don’t start comparing it with ==

RFR: 8046485: Add missing @since tag under javax.swing.*

2014-06-10 Thread Henry Jen
Hi, Please review a trivial webrev that provides missing @since tag for elements under javax.swing, Essentially it's simply add @since 1.2 for all classes/interfaces/exception that are missing @since tag, as JDK 1.2 package.html has @since tag but was removed in 1.3. The @since tag is

RFR (XL) 8046070 - Class Data Sharing clean up and refactoring, round #1

2014-06-10 Thread Ioi Lam
Hi Folks, Please review a the following clean up and refactoring of the AppCDS code http://cr.openjdk.java.net/~iklam/8046070-cds-cleanup-v1/ https://bugs.openjdk.java.net/browse/JDK-8046070 Summary of fix: Clean up and refactor the Class Data Sharing (CDS) code, including: +