Re: RFR: 8047795: Collections.checkedList checking bypassed by List.replaceAll

2014-06-25 Thread Paul Sandoz
On Jun 24, 2014, at 8:25 PM, Mike Duigou mike.dui...@oracle.com wrote: On Jun 24 2014, at 01:18 , Paul Sandoz paul.san...@oracle.com wrote: Additionally the javadoc is updated to inform users that a ClassCastException may result if the proposed replacement is unacceptable. No users will

RE: RFR: 8048020 - Regression on java.util.logging.FileHandler

2014-06-25 Thread Jason Mehrens
Daniel, FileChannel.open(WRITE,APPEND) could throw NoSuchFileException during a startup and shutdown race between two VMs. That case needs to either perform a bounded retry or continue and rotate. Jason Date: Tue, 24 Jun 2014 20:34:46 +0200 From:

Re: JDK 9 RFR of JDK-8048014: Update java.lang.SafeVararags for private methods

2014-06-25 Thread Joe Darcy
Hi Remi, Thanks for the note. However, I don't plan to extend @SafeVarargs to cover this case. Cheers, -Joe On 6/25/2014 1:35 AM, Remi Forax wrote: Hi Joe, Just for completeness, there is another case where @SafeVarargs is safe, any methods of an internal class (inner class static or not)

Re: RFR [9] 8041972: Add improved parse/format methods for Long/Integer

2014-06-25 Thread Paul Sandoz
On Jun 19, 2014, at 7:39 PM, Claes Redestad claes.redes...@oracle.com wrote: Hi, an updated webrev with reworked, public methods is available here: http://cr.openjdk.java.net/~redestad/8041972/webrev.8/ Reviews are yet again appreciated! I think if (s == null) or

Re: ThreadLocalRandom clinit troubles

2014-06-25 Thread Peter Levart
To sum-up: We have a problem with TLR initialization since by default it uses networking code to compute initial seeder value which can execute user code in at least two situations: - when sun.net.spi.nameservice.provider system property is defined to use custom NameService provider - when

Re: Ready for Review : 8042469 : Launcher changes for native memory tracking scalability enhancement

2014-06-25 Thread Neil Toda
Sorry. One more webrev .. 06 http://cr.openjdk.java.net/~ntoda/8042469/webrev-06/ Kumar's nit was correct and in fact index was old and should have been removed allowing .contains member to be used instead of .indexOf. So cleaned up a bit more as can be seen below. Other of Kumar's nits

Re: Ready for Review : 8042469 : Launcher changes for native memory tracking scalability enhancement

2014-06-25 Thread Zhengyu Gu
Hi Neil, I tried out this patch with my hotspot, it does not work. The reason is that, the environment variable is setup too late, it has to be set before it launches JavaVM (before calling LoadJavaVM()) method. Thanks, -Zhengyu On 6/25/2014 1:58 PM, Neil Toda wrote: Sorry. One more

Re: RFR: 8047795: Collections.checkedList checking bypassed by List.replaceAll

2014-06-25 Thread Mike Duigou
On Jun 25 2014, at 01:30 , Paul Sandoz paul.san...@oracle.com wrote: On Jun 24, 2014, at 8:25 PM, Mike Duigou mike.dui...@oracle.com wrote: On Jun 24 2014, at 01:18 , Paul Sandoz paul.san...@oracle.com wrote: Additionally the javadoc is updated to inform users that a ClassCastException

Re: Ready for Review : 8042469 : Launcher changes for native memory tracking scalability enhancement

2014-06-25 Thread Kumar Srinivasan
Hi Zhengyu, You are right then this needs to happen before LoadJavaVM, I think that is where it was initially, but I had Neil move it to ParseArguments where all the arguments are parsed. Also it is probably best that you push this changeset when it is complete, into hotspot-dev, along

Process trees and termination

2014-06-25 Thread roger riggs
Hi, The next step for JEP 102, Process API Updates is to provide an API to enumerate the hierarchy of processes and to be able to terminate a process tree. This draft javadoc http://bussund0416/%7Erriggs/pdoc/update [1] includes: - ProcessHandle class to provide handles to processes, their

Re: Process trees and termination

2014-06-25 Thread David M. Lloyd
On 06/25/2014 04:52 PM, roger riggs wrote: Hi, The next step for JEP 102, Process API Updates is to provide an API to enumerate the hierarchy of processes and to be able to terminate a process tree. This draft javadoc http://bussund0416/%7Erriggs/pdoc/update [1] includes: - ProcessHandle