On 6/30/2014 9:51 PM, Christian Thalinger wrote:
On Jun 30, 2014, at 5:50 PM, Coleen Phillimore coleen.phillim...@oracle.com
wrote:
On 6/30/14, 3:50 PM, Christian Thalinger wrote:
private Class(ClassLoader loader) {
// Initialize final field for classLoader. The
Hi,
Stuarts recent doc fix from Raoul reminded me about a few others:
https://bugs.openjdk.java.net/browse/JDK-8043328
Typo in documentation of package java.util.stream
https://bugs.openjdk.java.net/browse/JDK-8043327
Collectors.toMap studentToGPA example uses Functions.identity()
See
On 02/07/2014 09:25, Paul Sandoz wrote:
Hi,
Stuarts recent doc fix from Raoul reminded me about a few others:
https://bugs.openjdk.java.net/browse/JDK-8043328
Typo in documentation of package java.util.stream
https://bugs.openjdk.java.net/browse/JDK-8043327
Collectors.toMap
Hi Kasper,
Sorry for the *very* late reply, i forgot about this, but was reminded when
trawling through some bugs.
On Apr 17, 2014, at 3:13 PM, Kasper Nielsen kaspe...@gmail.com wrote:
Hi,
I'm trying to build a small test suite for for a custom stream
implementation I'm making.
And I
+1
Best
Lance
On Jul 1, 2014, at 8:34 PM, Stuart Marks stuart.ma...@oracle.com wrote:
Please review this small patch to fix some errors in the examples in the docs
for java.util.stream.Collectors. Thanks to Raoul Urma for pointing these out.
s'marks
# HG changeset patch
# User smarks
+1
On Jul 2, 2014, at 4:25 AM, Paul Sandoz paul.san...@oracle.com wrote:
Hi,
Stuarts recent doc fix from Raoul reminded me about a few others:
https://bugs.openjdk.java.net/browse/JDK-8043328
Typo in documentation of package java.util.stream
Hi,
I updated the webrev with first two suggestions from Bernd (expireTime
instead of createTime and cacheNanos + only use putIfAbsent instead of
get followed by putIfAbsent):
http://cr.openjdk.java.net/~plevart/jdk9-dev/InetAddress.Cache/webrev.02/
Thanks, Bernd.
The id field in
Hi,
Please review this fix for some missing null-checks in stream code:
http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8044047-null-checks/webrev/
https://bugs.openjdk.java.net/browse/JDK-8044047
I also boosted some of the primitive summary statistic tests.
Unfortunately the refactoring of
On 07/02/2014 08:26 AM, Mandy Chung wrote:
On 6/30/2014 9:51 PM, Christian Thalinger wrote:
On Jun 30, 2014, at 5:50 PM, Coleen Phillimore
coleen.phillim...@oracle.com wrote:
On 6/30/14, 3:50 PM, Christian Thalinger wrote:
private Class(ClassLoader loader) {
// Initialize
On 07/02/2014 02:22 PM, Peter Levart wrote:
On 07/02/2014 08:26 AM, Mandy Chung wrote:
On 6/30/2014 9:51 PM, Christian Thalinger wrote:
On Jun 30, 2014, at 5:50 PM, Coleen Phillimore
coleen.phillim...@oracle.com wrote:
On 6/30/14, 3:50 PM, Christian Thalinger wrote:
private
On 07/02/2014 02:38 PM, Peter Levart wrote:
On 07/02/2014 02:22 PM, Peter Levart wrote:
On 07/02/2014 08:26 AM, Mandy Chung wrote:
On 6/30/2014 9:51 PM, Christian Thalinger wrote:
On Jun 30, 2014, at 5:50 PM, Coleen Phillimore
coleen.phillim...@oracle.com wrote:
On 6/30/14, 3:50 PM,
On 7/2/14, 8:41 AM, Peter Levart wrote:
On 07/02/2014 02:38 PM, Peter Levart wrote:
On 07/02/2014 02:22 PM, Peter Levart wrote:
On 07/02/2014 08:26 AM, Mandy Chung wrote:
On 6/30/2014 9:51 PM, Christian Thalinger wrote:
On Jun 30, 2014, at 5:50 PM, Coleen Phillimore
Hi Peter,
perhaps the synchronized(this)-block in NameServiceAddresses::get()
can be replaced with a ReentrantLock? Applying this on top of your
patch, I seem to improve scores on your benchmark for -t 4 by ~33% on my
machine:
--- a/src/share/classes/java/net/InetAddress.javaWed Jul 02
On 02/07/2014 01:02, Jeremy Manson wrote:
Here you go (far too lazy to generate a webrev for this. :) )
diff --git a/src/share/classes/java/io/File.java
b/src/share/classes/java/io/File.java
--- a/src/share/classes/java/io/File.java
+++ b/src/share/classes/java/io/File.java
@@ -1997,8
Hi Claes,
Thank you for looking into this patch.
On 07/02/2014 04:39 PM, Claes Redestad wrote:
Hi Peter,
perhaps the synchronized(this)-block in NameServiceAddresses::get()
can be replaced with a ReentrantLock? Applying this on top of your
patch, I seem to improve scores on your benchmark
On 07/02/2014 05:30 PM, Peter Levart wrote:
Hi Claes,
Thank you for looking into this patch.
On 07/02/2014 04:39 PM, Claes Redestad wrote:
Hi Peter,
perhaps the synchronized(this)-block in NameServiceAddresses::get()
can be replaced with a ReentrantLock? Applying this on top of your
Hi Mandy,
The componentType field is the last one that I'm planning on moving out
for now, so I'd like to keep the code as is. If more are added because
of more performance opportunities, I think we can revisit this.
I agree with Doug that we don't want any more special code like this in
I wasn't aware of the VM special case of System.{in,out,err} fields that
Doug pointed out (thanks. I should have checked). That's okay with me.
Mandy
On 7/2/2014 10:05 AM, Coleen Phillimore wrote:
Hi Mandy,
The componentType field is the last one that I'm planning on moving
out for now,
On 7/2/14 1:25 AM, Paul Sandoz wrote:
Stuart, are you planning to back port your doc fix to 8u-dev? If so we could do
all three in one go.
Hm, it might be a good idea to do so, in case we refresh the published javadoc
in one of the 8-updates. That way the corrections will get out there
Hi,
Related to JDK-8023276[1] where we added two packages to JDK 9, we
should update @since to have 1.9 value as well.
http://cr.openjdk.java.net/~henryjen/jdk9/8049109/0/webrev/
[1] https://bugs.openjdk.java.net/browse/JDK-8023276
Cheers,
Henry
Looks good Henry; cheers,
-Joe
On 07/02/2014 02:45 PM, Henry Jen wrote:
Hi,
Related to JDK-8023276[1] where we added two packages to JDK 9, we
should update @since to have 1.9 value as well.
http://cr.openjdk.java.net/~henryjen/jdk9/8049109/0/webrev/
[1]
These packages were defined in JDK 1.5 / JAXP 1.3 (JSR 206). In that
sense, they were in JDK since 1.5.
For reasons I don't know, they were excluded from the Java API
Documentation. From the tag conventions
http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#@since
I don't have a strong preference in this case, and I hear you that those
classes are public and can be accessed in 1.5 even though it's not part
of API specification of JDK.
Considered DOM Level 2 is still listed as secondary information, and as
the document you pointed out, 1.9 is used
Please review -- the jdk_beansX targets were removed as part of moving
from Makefile logic to jtreg test groups late last year and the all
testset currently fails because of that. The only remaining beans group
is called jdk_beans and this change reflects that change.
Bug:
24 matches
Mail list logo
