Re: RFR: [6904367]: (coll) IdentityHashMap is resized before exceeding the expected maximum size

2014-07-09 Thread Peter Levart
On 07/09/2014 02:46 AM, Martin Buchholz wrote: Let me understand - you're worried that when size is MAX_CAPACITY - 1, then a call to putAll that does not actually add any elements might throw? This is not possible, because resize() is only called from putAll(map) if argument map.size()

Re: RFR: [6904367]: (coll) IdentityHashMap is resized before exceeding the expected maximum size

2014-07-09 Thread Peter Levart
On 07/09/2014 09:23 AM, Peter Levart wrote: On 07/09/2014 02:46 AM, Martin Buchholz wrote: Let me understand - you're worried that when size is MAX_CAPACITY - 1, then a call to putAll that does not actually add any elements might throw? This is not possible, because resize() is only called

Re: RFR: 8044862: Fix raw and unchecked lint warnings in macosx specific code

2014-07-09 Thread Petr Pchelko
Hello, Henry. AquaComboBoxRendererInternal : why ? extends Object and not just ?? AquaComboBoxUI:427, 510, 530 - you can replace JComboBoxObject with JComboBox? and avoid a @SupressWarning annotation. AquaFileChooserUI.createDirectoryComboBoxRenderer actually returns a ListCellRendererFile,

Re: RFR: 8048913: java/util/logging/LoggingDeadlock2.java times out

2014-07-09 Thread Daniel Fuchs
On 7/9/14 5:46 AM, Mandy Chung wrote: On 7/8/2014 5:58 AM, Daniel Fuchs wrote: Hi, Please find below a fix for 8048913: java/util/logging/LoggingDeadlock2.java times out http://cr.openjdk.java.net/~dfuchs/webrev_8048913/webrev.00/ My suggestion is thus simply to remove the

Re: [9] RFR (M): 8037209: Improvements and cleanups to bytecode assembly for lambda forms

2014-07-09 Thread Paul Sandoz
On Jul 8, 2014, at 9:09 PM, John Rose john.r.r...@oracle.com wrote: Regarding the extra cast in accessor logic that Paul picked up on: That may be a left-over from obsolete versions of the code, or it may cover for some corner cases, or it could possibly be a re-assurance to the JIT.

Re: [concurrency-interest] URI + RFC3986 compliance

2014-07-09 Thread Alan Bateman
On 09/07/2014 11:38, Peter Firmstone wrote: I've had some time to think about how to make java.net.URI comply with RFC3986 as well as retain the existing implementation for backward compatibility: 1. Strip out the existing URI class and Parser, create an abstract private delegate, move

Re: RFR: 8044656: Update JAX-WS RI integration to latest version

2014-07-09 Thread Miroslav Kos
Hi Joe, thanks for comments - see inline: On 08/07/14 01:02, huizhe wang wrote: Hi Miran, In class src/share/jaxws_classes/com/sun/tools/internal/xjc/Options.java: +// hack to force initialization so catalog manager system properties take effect +

Re: Draft JEP: Efficient Stack Walking API

2014-07-09 Thread David M. Lloyd
Just want to say that I am also looking forward to progress on this. On 07/09/2014 12:25 AM, Jeremy Manson wrote: Thanks for the response, Mandy. I'm looking forward to seeing the final version. For CallerFinder, we use reflective goop to get at sun.misc.JavaLangAccess.getStackTraceElement.

Re: [concurrency-interest] URI + RFC3986 compliance

2014-07-09 Thread Michael Kay
+1. As the author of a library that uses the URI class, I need control over how it is behaving, and I cannot assume that other libraries in the same VM want the same options as I do. Michael Kay Saxonica m...@saxonica.com +44 (0118) 946 5893 On 9 Jul 2014, at 12:10, Alan Bateman

Re: RFR: 8048913: java/util/logging/LoggingDeadlock2.java times out

2014-07-09 Thread Mandy Chung
On 7/9/2014 2:32 AM, Daniel Fuchs wrote: On 7/9/14 5:46 AM, Mandy Chung wrote: Do you know if the test was run with -timeoutFactor? Or does it use the default timeout? Are you able to run the test with the same configuration (on same test machine) to see how long it takes? ... What I

RFR: JDK-8042589: String.toLowerCase do not work for some concatenated strings

2014-07-09 Thread Xueming Shen
Hi, Please help review the change for JDK-8042589. Issue:https://bugs.openjdk.java.net/browse/JDK-8042589 webrev: http://cr.openjdk.java.net/~sherman/8042589/webrev/ This is a regression caused by the following change for #JDK-8032012, issue:

Re: RFR: [6904367]: (coll) IdentityHashMap is resized before exceeding the expected maximum size

2014-07-09 Thread Martin Buchholz
OK, I think we're down to the smallest possible bug: if size == MAX_CAPACITY - 1 and we putAll a concurrent map with greater size, but the concurrent map shrinks while we're adding it, and no actual elements get added to the IHM (but each element put takes ~ 2**28 probes), then an ISE is thrown

Re: [concurrency-interest] ThreadLocalRandom clinit troubles

2014-07-09 Thread Stanimir Simeonoff
Hi Peter, Irrc, ServiceLoader.load(NameServiceDescriptor.class) uses Thread.contextClassLoader to load the services. Depending how late the NameServices is getting initialized, perhaps it can be used to circumvent the loader available at clinit of InetAddress. I am not sure it could be a real

Re: RFR JDK-7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime (+more)

2014-07-09 Thread Bernd Eckenfels
Hello Peter, I think the comments in compareTo() are now superflucious (with 0). Greetings Bernd Am Wed, 02 Jul 2014 13:56:39 +0200 schrieb Peter Levart peter.lev...@gmail.com: Hi, I updated the webrev with first two suggestions from Bernd (expireTime instead of createTime and cacheNanos

Re: [9] RFR (M): 8037209: Improvements and cleanups to bytecode assembly for lambda forms

2014-07-09 Thread John Rose
On Jul 9, 2014, at 3:14 AM, Paul Sandoz paul.san...@oracle.com wrote: I quickly verified the fold up does as you expect. Also, if i do the following the null check goes away: ... void testLoop() { for (int i = 0; i 100; i++) { testLoopOne(a);

Re: [9] request for review 8047353: Improve error message when a JAR with invalid signatures is loaded

2014-07-09 Thread Aaron Digulla
Am Donnerstag, 19. Juni 2014 23:49 CEST, Joe Darcy joe.da...@oracle.com schrieb: I'd prefer to see the CheckJarSigError.sh as a Java program. There original bug report contains a full self-contained test case in Java. Why was that split into several files? I'm also a bit uneasy about the

Re: Draft JEP: Efficient Stack Walking API

2014-07-09 Thread Remi Forax
On 07/09/2014 03:42 PM, David M. Lloyd wrote: Just want to say that I am also looking forward to progress on this. so am i :) RĂ©mi On 07/09/2014 12:25 AM, Jeremy Manson wrote: Thanks for the response, Mandy. I'm looking forward to seeing the final version. For CallerFinder, we use

Re: RFR: 8044656: Update JAX-WS RI integration to latest version

2014-07-09 Thread huizhe wang
On 7/9/2014 4:13 AM, Miroslav Kos wrote: Hi Joe, thanks for comments - see inline: On 08/07/14 01:02, huizhe wang wrote: Hi Miran, In class src/share/jaxws_classes/com/sun/tools/internal/xjc/Options.java: +// hack to force initialization so catalog manager system properties

Re: RFR: [6904367]: (coll) IdentityHashMap is resized before exceeding the expected maximum size

2014-07-09 Thread Peter Levart
On 07/09/2014 06:36 PM, Martin Buchholz wrote: OK, I think we're down to the smallest possible bug: I wouldn't call it a bug, since it's not present. if size == MAX_CAPACITY - 1 and we putAll a concurrent map with greater size, but the concurrent map shrinks while we're adding it, and no

Re: RFR: 8044862: Fix raw and unchecked lint warnings in macosx specific code

2014-07-09 Thread Henry Jen
Thanks, Petr. I worked out AquaFileChooserUI and updated the webrev to adapt comments from both you and Joe. The updated webrev is at, http://cr.openjdk.java.net/~henryjen/jdk9/8044862/1/webrev/ Cheers, Henry On 07/09/2014 01:07 AM, Petr Pchelko wrote: Hello, Henry.

Re: RFR: 8044862: Fix raw and unchecked lint warnings in macosx specific code

2014-07-09 Thread Petr Pchelko
Hello, Henry. The new version of the fix looks good to me. With best regards. Petr. On Jul 10, 2014, at 4:51 AM, Henry Jen henry@oracle.com wrote: Thanks, Petr. I worked out AquaFileChooserUI and updated the webrev to adapt comments from both you and Joe. The updated webrev is

Re: RFR: 8044862: Fix raw and unchecked lint warnings in macosx specific code

2014-07-09 Thread Joe Darcy
Looks fine to me too; thanks, -Joe On 07/09/2014 09:13 PM, Petr Pchelko wrote: Hello, Henry. The new version of the fix looks good to me. With best regards. Petr. On Jul 10, 2014, at 4:51 AM, Henry Jen henry@oracle.com wrote: Thanks, Petr. I worked out AquaFileChooserUI and updated