Re: RFR: 8049892: Replace uses of 'new Integer()' with appropriate alternative across core classes

Hi Otavio, Other than things already spotted by Andrej, the change looks good to me. Thank you for doing this. -Pavel On 11 Jul 2014, at 02:36, Otávio Gonçalves de Santana otaviopolianasant...@gmail.com wrote: https://bugs.openjdk.java.net/browse/JDK-8049892

Re: [9] RFR (M): 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke

http://cr.openjdk.java.net/~vlivanov/8049555/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8049555 Code cleanup: - moved varargsArray(Class,int) varargsArray(int) from sun.invoke.util.ValueConversions to java.lang.invoke.MethodHandleImpl; - removed unused varargsList(int);

Re: [9] RFR (M): 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke

Vladimir, instead of the trick w/ 'ClassFileInstaller', you can use 'bootclasspath' option[1] which adds all paths to the bootclasspath: * @run main/bootclasspath java.lang.invoke.VarargsArrayTest * @run main/bootclasspath * -DVarargsArrayTest.MAX_ARITY=255

Re: [9] RFR (M): 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke

Igor, thanks for the hint! Updated version: http://cr.openjdk.java.net/~vlivanov/8049555/webrev.01/ Best regards, Vladimir Ivanov On 7/11/14 3:56 PM, Igor Ignatyev wrote: Vladimir, instead of the trick w/ 'ClassFileInstaller', you can use 'bootclasspath' option[1] which adds all paths to the

Re: [9] RFR (M): 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke

On Jul 11, 2014, at 2:21 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com wrote: Igor, thanks for the hint! Yes, much better. Updated version: http://cr.openjdk.java.net/~vlivanov/8049555/webrev.01/ +1 Paul.

RFR JDK-8049884: Reduce possible timing noise in com/sun/jndi/ldap/LdapTimeoutTest.java

Hi everyone, Could you please review my change for JDK-8049884? http://cr.openjdk.java.net/~prappo/8049884/webrev.00/ Thanks -Pavel

Re: RFR JDK-8049884: Reduce possible timing noise in com/sun/jndi/ldap/LdapTimeoutTest.java

This change looks fine Pavel and eliminates another intermittent test failure. Thanks. On 11 Jul 2014, at 14:59, Pavel Rappo pavel.ra...@oracle.com wrote: Hi everyone, Could you please review my change for JDK-8049884? http://cr.openjdk.java.net/~prappo/8049884/webrev.00/ Thanks

URL constructor/equals/hashCode/sameFile/openConnection synchronization issues

Hi, java.net.URL is supposed to behave as an immutable object, so URL instances can be shared among threads and among parts of code without fear that they will be modified. URL class has an unusual way to achieve this (or at least it tries to). Partly because of the design which uses: - URL

[9] RFR (M): 8050052: Small cleanups in java.lang.invoke code

http://cr.openjdk.java.net/~vlivanov/8050052/webrev.00 https://bugs.openjdk.java.net/browse/JDK-8050052 Numerous small code cleanups in java.lang.invoke package. Testing: jtreg, nashorn, octane w/ -ea -esa and COMPILE_THRESHOLD={0,30}. Reviewed-by: vlivanov, ? Contributed-by:

Re: Character, Byte, Short valueOf instead of new instance

On 07/02/2014 01:07 AM, Otávio Gonçalves de Santana wrote: Thank you Remi. The long[1] also was included? [1]https://bugs.openjdk.java.net/browse/JDK-8048267 yes, I've included all the patches (I hope) http://websvn.ow2.org/revision.php?repname=asmpath=%2Ftrunk%2Frev=1759 There were just one

[9] RFR (M): 8050053: Improve caching of different invokers

http://cr.openjdk.java.net/~vlivanov/8050053/webrev.00 https://bugs.openjdk.java.net/browse/JDK-8050053 Improve sharing of different invokers: basic, generic exact invokers, uninitialized call site invoker and NamedFunction invoker are changed. Testing: jdk/java/lang/invoke, nashorn, octane

Re: [9] RFR (M): 8050052: Small cleanups in java.lang.invoke code

On 07/11/2014 06:18 PM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8050052/webrev.00 https://bugs.openjdk.java.net/browse/JDK-8050052 I've found myself writing the very same code as MethodHandleStatics.uncaughException several times and I wonder if it should not be an

Re: [9] RFR (M): 8050052: Small cleanups in java.lang.invoke code

On Jul 11, 2014, at 7:56 PM, Remi Forax fo...@univ-mlv.fr wrote: On 07/11/2014 06:18 PM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8050052/webrev.00 https://bugs.openjdk.java.net/browse/JDK-8050052 I've found myself writing the very same code as

Re: [9] RFR (M): 8050052: Small cleanups in java.lang.invoke code

On 07/11/2014 08:16 PM, Paul Sandoz wrote: On Jul 11, 2014, at 7:56 PM, Remi Forax fo...@univ-mlv.fr wrote: On 07/11/2014 06:18 PM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8050052/webrev.00 https://bugs.openjdk.java.net/browse/JDK-8050052 I've found myself writing the

Re: RFR: [6904367]: (coll) IdentityHashMap is resized before exceeding the expected maximum size

I've been content to just observe Martin and Peter's nice efforts on this, but one note: On 07/11/2014 03:00 PM, Martin Buchholz wrote: On Wed, Jul 9, 2014 at 3:17 PM, Peter Levart peter.lev...@gmail.com wrote: IMH resizing is arranged so that the table is always 33% ... 66% full (if

JDK 9 RFR of 8050051: Remove unneeded/obsolete -source/-target options in shell tests

Hello, The purge of old -source and -target values in the JDK regression tests missed a few items. Please review the patch below which fixes two of them. Thanks, -Joe diff -r d5404a4e4fac test/java/lang/Class/forName/NonJavaNames.sh --- a/test/java/lang/Class/forName/NonJavaNames.shFri

Re: JDK 9 RFR of 8050051: Remove unneeded/obsolete -source/-target options in shell tests

On 11/07/2014 21:01, Joe Darcy wrote: Hello, The purge of old -source and -target values in the JDK regression tests missed a few items. Please review the patch below which fixes two of them. Thanks, -Joe This seems fine. -Alan

Re: RFR [9] 8041972: Add improved parse/format methods for Long/Integer

Some comments: - The NumberFormatException.forInputString for some CharSequence is probably misleading since it doesn't consider the begin-end range which was in effect for the parsing. Rather than extracting the substring just for the error message perhaps include the index at which the error

Re: RFR [9] 8041972: Add improved parse/format methods for Long/Integer

Thank you for looking at this, Mike! New webrev: http://cr.openjdk.java.net/~redestad/8041972/webrev.12 On 2014-07-12 00:55, Mike Duigou wrote: Some comments: - The NumberFormatException.forInputString for some CharSequence is probably misleading since it doesn't consider the begin-end

RFR (XS): 8050105: test sun/rmi/rmic/minimizeWrapperInstances/run.sh fails

Hi all, Please review this small patch to fix one of the old RMI tests that has started failing. This simply removes a couple test cases that use the (hidden, unsupported) -Xnew option of rmic, which relies on support for old -source and -target values that were recently removed from javac by

Re: RFR (XS): 8050105: test sun/rmi/rmic/minimizeWrapperInstances/run.sh fails

+1 On Jul 11, 2014, at 9:11 PM, Stuart Marks stuart.ma...@oracle.com wrote: Hi all, Please review this small patch to fix one of the old RMI tests that has started failing. This simply removes a couple test cases that use the (hidden, unsupported) -Xnew option of rmic, which relies on

Re: RFR (XS): 8050105: test sun/rmi/rmic/minimizeWrapperInstances/run.sh fails

Looks fine. On Jul 11 2014, at 18:11 , Stuart Marks stuart.ma...@oracle.com wrote: Hi all, Please review this small patch to fix one of the old RMI tests that has started failing. This simply removes a couple test cases that use the (hidden, unsupported) -Xnew option of rmic, which

Re: RFR (XS): 8050105: test sun/rmi/rmic/minimizeWrapperInstances/run.sh fails

Looks good to me too; thanks Stuart, -Joe On 07/11/2014 07:05 PM, Mike Duigou wrote: Looks fine. On Jul 11 2014, at 18:11 , Stuart Marks stuart.ma...@oracle.com wrote: Hi all, Please review this small patch to fix one of the old RMI tests that has started failing. This simply removes a