RFR 8054095: No space allowed in platforms string in ProblemList.txt

Please review the problem list change for JDK-8054095 http://cr.openjdk.java.net/~ewang/amylu/JDK-8054095/webrev.00/ In ProblemList.txt, when specify multiple platforms, the space between the platform names is not accepted by jtreg harness. This change is to remove the empty space between the

Re: RFR 8054095: No space allowed in platforms string in ProblemList.txt

The change looks good. So does the closed side. I read jtharness and it seems a line is broken into 3 parts separated by space(s). Either the 2nd or the 3rd part will be used by jtreg as platforms, but not both. I'm not sure if jtharness or jtreg should also be updated. Thanks Max On Aug 1,

Re: RFR JDK-8051991: Flatten VersionHelper hierarchies

Look fine Pavel. Thanks. On 25 Jul 2014, at 13:59, Pavel Rappo pavel.ra...@oracle.com wrote: Hi everyone, Could you please review my change for JDK-8051991? http://cr.openjdk.java.net/~prappo/8051991/webrev.00/ -Pavel

Re: Please View Change : 8044867 : Fix raw and unchecked lint warnings in sun.tools.*

Thanks Joe. -neil On 7/31/2014 4:58 PM, Joe Darcy wrote: Looks fine Neil; thanks, -Joe On 07/31/2014 02:33 PM, Neil Toda wrote: Please view this patch cleaning up lint rawtypes, cast, and unchecked warnings in sun.tools.* http://cr.openjdk.java.net/~ntoda/8044867/webrev-04/

RFR JDK-8054158: Fix typos in JNDI-related packages

Hi everyone, Could you please review my change for JDK-8054158? http://cr.openjdk.java.net/~prappo/8054158/webrev.00/ -Pavel

Re: RFR JDK-8054158: Fix typos in JNDI-related packages

Hi Pavel, The changes look fine. Thanks, Roger On 8/1/2014 11:50 AM, Pavel Rappo wrote: Hi everyone, Could you please review my change for JDK-8054158? http://cr.openjdk.java.net/~prappo/8054158/webrev.00/ -Pavel

Re: RFR JDK-8054158: Fix typos in JNDI-related packages

Thanks for fixing those typso. On 1 Aug 2014, at 16:50, Pavel Rappo pavel.ra...@oracle.com wrote: Hi everyone, Could you please review my change for JDK-8054158? http://cr.openjdk.java.net/~prappo/8054158/webrev.00/ -Pavel

Re: RFR JDK-8054158: Fix typos in JNDI-related packages

Roger, Vincent, Here are updates more of a structural type (grammar and syntax rather than spelling) and some deletions: http://cr.openjdk.java.net/~prappo/8054158/webrev.01/ src/share/classes/com/sun/jndi/dns/DnsClient.java src/share/classes/com/sun/jndi/ldap/LdapReferralContext.java

Re: RFR JDK-8054158: Fix typos in JNDI-related packages

Hi Pavel, Looks fine. Roger On 8/1/2014 12:45 PM, Pavel Rappo wrote: Roger, Vincent, Here are updates more of a structural type (grammar and syntax rather than spelling) and some deletions: http://cr.openjdk.java.net/~prappo/8054158/webrev.01/