Hi,
Thank you all for the reviews! I have prepared a final version that has
incorporated all the comments.
http://cr.openjdk.java.net/~iklam/8046070-cds-cleanup-vfinal/
- Ioi
On 8/9/14, 1:02 AM, Ioi Lam wrote:
Hi,
Thanks a lot to everyone for the very useful comments. I have updated
the
On 08/13/2014 08:55 AM, David Holmes wrote:
On 13/08/2014 1:01 AM, Andrew Haley wrote:
(Please forgive me if this should go to the AWT list or somesuch. It
seems to me like this is not really a graphics-related issue, but one
of Java concurrency.)
This is in JDK9, sun.font.GlyphList. There
Hi Paul,
On 2014-06-24, Paul Sandoz wrote:
On Jun 17, 2014, at 6:52 PM, Joel Borggrén-Franck joel.fra...@oracle.com
wrote:
Can I get a review for this fix and javadoc clarification for
https://bugs.openjdk.java.net/browse/JDK-8044629
+1
I never quite realised just how
Hi Ivan,
The first version looks good.
I think this is desirable even if it is a tiny bit slower.
cheers
/Joel
On 4 aug 2014, at 13:27, Ivan Gerasimov ivan.gerasi...@oracle.com wrote:
Hi Martin!
Sorry for the pause, I had to take a break.
Thank you for your StringJoiner rework!
I
Hi All
I'm working on 8038089: TLS optional support for Kerberos cipher suites needs
to be re-examine which will separate the implementation of Kerberos-related
TLS ciphersuites from the other TLS codes. I am thinking of defining a
ServiceLoader interface called ExternalCipherSuiteProvider
Thank you Joel!
I had already pushed this fix.
When you have a chance, could you please also review the continuation of
this, which I sent to core-libs-dev a few days ago?
[8054714] Use StringJoiner where it makes the code cleaner
Dne So 9. srpna 2014 07:18:54, Doug Lea napsal(a):
Dne Pá 8. srpna 2014 15:02:41, Stanimir Simeonoff napsal(a):
According to articles provided by Andrew[1], toString() can be on stack,
even if obj
(e.g. this for toString()) is garbage collected. This is a bit surprising
(an OOP
Hi all,
Cleaning out the patch queue, I found this small patch that adds sharing
of conceptually immutable annotation maps between instances of
Executable representing the same executable.
In short, Method/Constructor contain one bit of mutable state, if they
have been set accessible or not.
Please find below a fix for
8052403: java/util/logging/CheckZombieLockTest.java fails
with NoSuchFileException
https://bugs.openjdk.java.net/browse/JDK-8052403
The issue here is that CheckZombieLockTest and CheckLockLocationTest use
(create and delete) the same writable-dir under /tmp.
Hi,
can I have a review of this performance improvement to
java.time.Period#parse and java.time.Duration#parse?
bug: https://bugs.openjdk.java.net/browse/JDK-8055004
webrev: http://cr.openjdk.java.net/~redestad/8055004/webrev.0
The patch avoids String allocation through matcher.group(n)
On 12/08/2014 10:03, Peter Firmstone wrote:
Interesting, language features for modules, won't necessarily involve
ClassLoader's (my assumptions were based on existing systems) although
you'd expect modules to have their own ProtectionDomain.
I think it would be reasonable to expect to that
Just a BTW: It would be really cool to have a SPI interface for that, so people
who need SRP, CCM or shared secret handshakes (or stuff like NPN?) don't need
to use a third party SSL engine.
--
http://bernd.eckenfels.net
- Ursprüngliche Nachricht -
Von: Wang Weijun
On 13/08/2014 11:10, Wang Weijun wrote:
Hi All
I'm working on 8038089: TLS optional support for Kerberos cipher suites needs to be
re-examine which will separate the implementation of Kerberos-related TLS
ciphersuites from the other TLS codes. I am thinking of defining a ServiceLoader
Looks good. Ship it!
thank you so much Ioi, Jiangli, Calvin, Yumin and David for all the hard work!
Karen
On Aug 13, 2014, at 2:25 AM, Ioi Lam wrote:
Hi,
Thank you all for the reviews! I have prepared a final version that has
incorporated all the comments.
2014/8/13 7:20 -0700, alan.bate...@oracle.com:
The usual thing is to just have a default implementation that is used
when ServiceLoader doesn't locate a useful provider. You'll find many
examples of this in the JDK. In those cases then the default is not
listed in a services configuration
Hi,
can I have a review of this small patch which improves performance of
java.sql.Time::valueOf (~1.3x) and java.sql.Timestamp::valueOf (~1.9x).
Uses Integer.parseInt with offset to make intermediary substrings
unnecessary and improves the nanosecond fraction calculation to not use
String
I will take a look this week. Did you run the unit tests to make sure they
still pass?
On Aug 13, 2014, at 12:49 PM, Claes Redestad claes.redes...@oracle.com wrote:
Hi,
can I have a review of this small patch which improves performance of
java.sql.Time::valueOf (~1.3x) and
looks fine.
though arguably it might be more correct to do
if (dayStart != -1 || hourStart != -1 || minuteStart != -1 || secondStart !=
-1) {
...
}
as the regex spec says the start/end return -1 if no match for the group.
-Sherman
On 08/13/2014 05:50 AM, Claes Redestad wrote:
Hi,
can I
Thanks, Lance!
I only ran the jtreg tests under jdk/test/java/sql locally for this (29
passed).
/Claes
On 2014-08-13 20:14, Lance Andersen wrote:
I will take a look this week. Did you run the unit tests to make sure
they still pass?
On Aug 13, 2014, at 12:49 PM, Claes Redestad
On 2014-08-13 21:49, Xueming Shen wrote:
looks fine.
Thanks for reviewing!
though arguably it might be more correct to do
if (dayStart != -1 || hourStart != -1 || minuteStart != -1 ||
secondStart != -1) {
...
}
as the regex spec says the start/end return -1 if no match for the group.
Yes, I see a lot of places using
if (loadProviderFromProperty())
return provider;
if (loadProviderAsService())
return provider;
The 1st using Class.forName() and 2nd ServiceLoader.load().
I was thinking that the 1st method will not work because Class.forName() on an
Hi Joel,
Does your changeset alter the support (or non-support) of redefining an
annotation?
-Joe
On 08/13/2014 05:23 AM, Joel Borggren-Franck wrote:
Hi all,
Cleaning out the patch queue, I found this small patch that adds sharing
of conceptually immutable annotation maps between instances
22 matches
Mail list logo
