Re: RFR(S): 8055055: Improve numeric parsing in java.sql

I think this is OK. However, I want to write some additional tests to reduce the chance of regression and add this as part of the putback I am going to be out of the office for a few days so doubt I will get to this for another week or so Best, Lance On Aug 13, 2014, at 3:42 PM, Claes Redestad

RFR: 8055776, Add tests to exercise SQLPermissions for DriverManager & SyncFactory

Hi all, This is a request for review for This adds tests which exercise SQLPermissions for DriverManager and SyncFactory. The webrev can be found at http://cr.openjdk.java.net/~lancea/8055776/webrev.00/ Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle J

Re: Replace concat String to append in StringBuilder parameters

I also see a lot of .toString() and String.valueOf() calls. $ cat string_concat_updated.patch | perl -ne 'print if /^\+ .*append.*(String\.valueOf|\.toString\(\))/' | wc 62 2104626 Wrapped lines not indented correctly in src/java.xml.crypto/share/classes/com/sun/org/apache/xml/int

Re: RFR 8042003: java/lang/Math tests have external dependency on sun.misc.DoubleConsts and sun.misc.FloatConsts

On 8/21/14, 9:56 AM, Mandy Chung wrote: On 8/20/2014 6:39 PM, Amy Lu wrote: On 8/21/14, 8:54 AM, Mandy Chung wrote: On 8/20/2014 6:26 AM, Amy Lu wrote: Patch updated: http://cr.openjdk.java.net/~ewang/amylu/JDK-8042003/webrev.02/ test/java/lang/Double/ParseHexFloatingPoint.java No depend

Re: Replace concat String to append in StringBuilder parameters

On Aug 21, 2014, at 21:18, Andrej Golovnin wrote: >https://bugs.openjdk.java.net/browse/JDK-8038277 > > This is not the right bug report. The subject of this bug report is "Improve > the bootstrap performance of carets keystore". Oh, my mistake, it should be https://bugs.openjdk.java.net/

Re: Replace concat String to append in StringBuilder parameters

Hi Martin, you are right. And in the line 297: 297 sb.append(getClass().getName()).append(' ').append(Integer.toString(hashCode())); Integer.toString() can be removed too. Best regards, Andrej Golovnin On Thu, Aug 21, 2014 at 3:26 PM, Martin Desruisseaux < martin.desruisse...@geomatys.

Re: Replace concat String to append in StringBuilder parameters

I had a random look at the Webrev for TreeModelEvent.java and saw the following new code: sb.append(Integer.toString(childIndices[counter])) Wouldn't the following be slightly more efficient? sb.append(childIndices[counter]) since Integer.toString(int) creates a temporary char[] array l

Re: Replace concat String to append in StringBuilder parameters

> >https://bugs.openjdk.java.net/browse/JDK-8038277 This is not the right bug report. The subject of this bug report is "Improve the bootstrap performance of carets keystore". > >http://cr.openjdk.java.net/~weijun/8038277/client/webrev.00 TABs are still used for indentation. I looked

Re: Replace concat String to append in StringBuilder parameters

I filed a bug at https://bugs.openjdk.java.net/browse/JDK-8038277 Webrev in 3 parts at http://cr.openjdk.java.net/~weijun/8038277/client/webrev.00 http://cr.openjdk.java.net/~weijun/8038277/core/webrev.00/ http://cr.openjdk.java.net/~weijun/8038277/extra/webrev.00/ --Max On Aug 21,

Re: RFR: 8049343: (tz) Support tzdata2014f

We used to make name changes in the root (base) bundle as part of time zone data maintenance and deter only translations. But if you want to handle name changes later, that would be fine. It's your call. Thanks, Masayoshi On 8/21/2014 5:05 PM, Aleksej Efimov wrote: Masayoshi, I agree that we

Re: 8055393: Some tests added to the TEST.group to exclude execution on inappropriate compact profiles

On 21/08/2014 8:35 PM, Evgeniya Stepanova wrote: Hi David! sun/misc/URLClassPath/ClassnameCharTest.java was in both needs_compact2 and needs_jre testgroups. I just removed it from needs_compact2 testgroup because I've noticed that for the cleanup reason. As for tests dependencies, it were descri

Re: 8055393: Some tests added to the TEST.group to exclude execution on inappropriate compact profiles

Hi David! sun/misc/URLClassPath/ClassnameCharTest.java was in both needs_compact2 and needs_jre testgroups. I just removed it from needs_compact2 testgroup because I've noticed that for the cleanup reason. As for tests dependencies, it were described in the very first message (please see below

Re: 8055393: Some tests added to the TEST.group to exclude execution on inappropriate compact profiles

Hi Jane, On 20/08/2014 7:03 PM, Evgeniya Stepanova wrote: Update review request with links: bug: https://bugs.openjdk.java.net/browse/JDK-8055393 webrev:http://cr.openjdk.java.net/~avstepan/eistepan/8055393/webrev.00/ To be

Re: RFR: 8049343: (tz) Support tzdata2014f

Masayoshi, I agree that we should change the long names to match the new short names introduced by tzdata. But I suggest to log a different CR for such activity to handle long name changes and their translations (this activity is slightly out of tzdata update scope). Does it make sense? -Alek