Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-03 Thread Vladimir Ivanov
Vladimir, thanks! No problem, I'll integrate the fix through hs-comp repo. Best regards, Vladimir Ivanov On 10/3/14, 8:57 PM, Vladimir Kozlov wrote: Looks fine to me. Can you push it into our jdk9/hs-comp/jdk repo so we can see immediate results from it in our testing? Thanks, Vladimir On 10/

RFR (JAXP): 8036951: Xerces Update: XMLSchemaValidator.java and XMLSchemaLoader.java

2014-10-03 Thread huizhe wang
Hi, This patch contains updates to 52 classes, mostly completely updated to the trunk except a few. I replaced some obsolete usages (e.g. Vector), but not all of them in order to not expand the update into more classes. With this patch, the main validation section is updated to the current tr

Re: Fwd: No for each loop comment?

2014-10-03 Thread Chris Newland
Hi Paul, I've created a tool called JITWatch[1] which might be useful here. It parses the LogCompilation output, shows the source/bytecode/assembly and can highlight inlining failures due to exceeding the thresholds. If you could point me to the code you're having trouble with I'd be happy to run

Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-03 Thread Vladimir Kozlov
Looks fine to me. Can you push it into our jdk9/hs-comp/jdk repo so we can see immediate results from it in our testing? Thanks, Vladimir On 10/3/14 7:12 AM, Vladimir Ivanov wrote: Updated version: http://cr.openjdk.java.net/~vlivanov/8058892/webrev.02/ Looks good. Thanks, Aleksey. Any "ca

Re: RFR(L): JDK-8057777 Cleanup of old and unused VM interfaces

2014-10-03 Thread Xueming Shen
On 10/3/14 8:19 AM, Alan Bateman wrote: On 30/09/2014 07:40, Hideric Parain wrote: Hi all, Please review changes for bug JDK-805 "Cleanup of old and unused VM interfaces" CR: https://bugs.openjdk.java.net/browse/JDK-805 This is basically a big cleanup of VM interfaces that are not use

Re: RFR(L): JDK-8057777 Cleanup of old and unused VM interfaces

2014-10-03 Thread Frederic Parain
Alan, Thank you for your feedback, see my comments below. On 03/10/2014 17:19, Alan Bateman wrote: On 30/09/2014 07:40, Frederic Parain wrote: Hi all, Please review changes for bug JDK-805 "Cleanup of old and unused VM interfaces" CR: https://bugs.openjdk.java.net/browse/JDK-805 Thi

Re: RFR(L): JDK-8057777 Cleanup of old and unused VM interfaces

2014-10-03 Thread Alan Bateman
On 30/09/2014 07:40, Frederic Parain wrote: Hi all, Please review changes for bug JDK-805 "Cleanup of old and unused VM interfaces" CR: https://bugs.openjdk.java.net/browse/JDK-805 This is basically a big cleanup of VM interfaces that are not used anymore by the JDK but have been kept

Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-03 Thread Vladimir Ivanov
Peter, That's an interesting observation. As Vitaly already pointed out, varargs array should be eliminated by EA, but it seems it's not for this particular code shape. I'll look into what's going on there and file a followup bug. Thanks for the feedback! Best regards, Vladimir Ivanov On 1

Re: [9] RFR (S): 8058892: FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl

2014-10-03 Thread Vladimir Ivanov
Updated version: http://cr.openjdk.java.net/~vlivanov/8058892/webrev.02/ Looks good. Thanks, Aleksey. Any "capital-R" volunteers to review this change? :-) Best regards, Vladimir Ivanov