On 05/11/2014 00:06, Martin Buchholz wrote:
:
So ... there is the question whether we are tightening the spec for
Attributes and its subclasses or only for Attributes.
Subclasses of Attribute that would change the order are likely to be
very rare (is there a use case?) - I'm OK with those
Gently reminder
29.10.2014 17:25, Konstantin Shefov пишет:
Please, review a test bug fix.
http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/
-Konstantin
On 27.10.2014 13:16, Konstantin Shefov wrote:
Kindly reminder
On 23.10.2014 19:04, Paul Sandoz wrote:
On Oct 23, 2014, at 1:25 PM,
Kindly reminder
http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/
06.11.2014 18:20, Konstantin Shefov пишет:
Igor,
Thanks for your comment!
Here is the updated webrev:
http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/
-Konstantin
On 06.11.2014 17:36, Igor Ignatyev wrote:
Ho Konstantin,
Actually, I don't think that this should be fixed by reducing
iterations, CompileCommand magic sounds more reasonable here.
I'd even say I'm not sure that it's a test bug, it looks very similar to
JDK-8046809. have you tried to run the tests on the build where
JDK-8046809 is
On 05/11/14 19:47, Stanimir Simeonoff wrote:
945 } catch (Exception ex) {
946 System.err.println(Can't load log handler \ + type +
\);
947 System.err.println( + ex);
948 ex.printStackTrace();
On 07/11/14 07:42, Mandy Chung wrote:
On 11/5/2014 8:15 AM, Daniel Fuchs wrote:
Here is the new webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8060132/webrev.03/index.html
Looks good. Minor nits and no need to generate new webrev.
line 108: {@linkplain #reset} -- # is missing.
line
Hi everyone,
Could you please review my change for JDK-8059311?
http://cr.openjdk.java.net/~prappo/8059311/webrev.00/
It looks like one of the killSwitches went off and executed System.exit(0).
The problem is jtreg doesn't like
Are there any more comments on this patch? This is an 8u40 issue, so it
needs to be committed soon.
Thanks,
Eric
On 11/05/14 16:57, Eric McCorkle wrote:
A word on the tests: I don't think there's a stable way to check the
types on getParameterizedType() and getAnnotatedType(). So I checked
All looks good.
Thanks.
On 7 Nov 2014, at 12:14, Pavel Rappo pavel.ra...@oracle.com wrote:
Hi everyone,
Could you please review my change for JDK-8059311?
http://cr.openjdk.java.net/~prappo/8059311/webrev.00/
It looks
Hi all,
Need a reviewer for the following tests for exercising BaseRowSet,
SQlInputImpl, and SQLOutputImpl
The webrev can be found at:
http://cr.openjdk.java.net/~lancea/8064356/webrev.00/
Have a good weekend!
Best,
Lance
Lance Andersen| Principal Member of Technical Staff |
Hi,
This is a regression caused by changeset:
http://cr.openjdk.java.net/~joehw/jdk9/8027359/webrev/. The fix then is
to recover those changes that modified the buffer. Please review.
http://cr.openjdk.java.net/~joehw/jdk9/8059327/webrev/
https://bugs.openjdk.java.net/browse/JDK-8059327
Looks OK Joe. I went and looked at the previous version prior to the 1st fix.
Best
Lance
On Nov 7, 2014, at 11:50 AM, huizhe wang huizhe.w...@oracle.com wrote:
Hi,
This is a regression caused by changeset:
http://cr.openjdk.java.net/~joehw/jdk9/8027359/webrev/. The fix then is to
Hi Lance,
Looks ok.
Roger
On 11/7/14 11:25 AM, Lance Andersen wrote:
Hi all,
Need a reviewer for the following tests for exercising BaseRowSet,
SQlInputImpl, and SQLOutputImpl
The webrev can be found at:
http://cr.openjdk.java.net/~lancea/8064356/webrev.00/
Have a good weekend!
Best,
+1, nice tests!
Joe
On 11/7/2014 9:47 AM, Roger Riggs wrote:
Hi Lance,
Looks ok.
Roger
On 11/7/14 11:25 AM, Lance Andersen wrote:
Hi all,
Need a reviewer for the following tests for exercising BaseRowSet,
SQlInputImpl, and SQLOutputImpl
The webrev can be found at:
On Fri, Nov 7, 2014 at 1:52 AM, Alan Bateman alan.bate...@oracle.com wrote:
On 05/11/2014 00:06, Martin Buchholz wrote:
:
So ... there is the question whether we are tightening the spec for
Attributes and its subclasses or only for Attributes.
Subclasses of Attribute that would change the
Hi Martin,
Thanks for the clarification.
On 6 nov 2014, at 20:51, Martin Buchholz marti...@google.com wrote:
Hi Joel,
On Thu, Nov 6, 2014 at 2:48 AM, Joel Borggrén-Franck
joel.fra...@oracle.com wrote:
Hi,
I’m having a hard time following this thread, which webrev has been updated,
Hi Joel,
Thanks for volunteering. I foisted all I have in
https://bugs.openjdk.java.net/browse/JDK-8064391
I volunteer to be your reviewer for the backports.
On Fri, Nov 7, 2014 at 1:36 PM, Joel Borggrén-Franck
joel.fra...@oracle.com wrote:
Hi Martin,
Thanks for the clarification.
On 6
17 matches
Mail list logo
