On 07/11/2014 20:52, Martin Buchholz wrote:
:
I don't much care either way, so the spec change to
Attributes(Attributes) is reverted, as you wish. Webrev refreshed.
Thanks, I think it's a better with just the update to the class description.
-Alan
Hi David,
As previously, I feel competent to comment only the Java side of the patch.
Using linked list to publish to VM is a safer and easier way for the
desired purpose and using a separate data structure for interning makes
it easier to change it in the future should need arise. That need
Hi Otávio,
in sun/tools/jstat/SyntaxException.java I see a possible enhencement (maybe applies to other places
too):
65 public SyntaxException(int lineno, SetString expected, Token found) {
66 StringBuilder msg = new StringBuilder(A + B * expected.size());
67
68
Hi!
I think I can handle the backport to jdk7, if you still need a volunteer.
Sincerely yours,
Ivan
On 08.11.2014 1:48, Martin Buchholz wrote:
Hi Joel,
Thanks for volunteering. I foisted all I have in
https://bugs.openjdk.java.net/browse/JDK-8064391
I volunteer to be your reviewer for the
I accidentally passed a null to setProperty() and got an NPE. Okay. The
javadoc says this method relies on Hashtable, which, in turn, is documented
to throw an NPE when put() key/value is null. So, since setProperty()
bubbles up the exception, I think this method should gain a @throws tag to
make
