Re: Library enhancement proposal for copying data from/to Reader/Writer InputStream/OutputStream

2014-11-28 Thread Pavel Rappo
> What usage would you actually search in the OpenJDK code base? We're talking about copying with provided buffer, right? long copy(InputStream source, OutputStream target, byte[] buffer) ^ It would be very helpful to verify that thi

Re: Library enhancement proposal for copying data from/to Reader/Writer InputStream/OutputStream

2014-11-28 Thread Patrick Reinhart
> Am 28.11.2014 um 20:15 schrieb Bernd Eckenfels : > > Am Fri, 28 Nov 2014 12:09:11 + > schrieb Pavel Rappo : > >> I'm happy with any tool which is capable of "usages search". >> Configured IDE is a good choice. > > What usage would you actually search in the OpenJDK code base? > > I thin

Re: Library enhancement proposal for copying data from/to Reader/Writer InputStream/OutputStream

2014-11-28 Thread Bernd Eckenfels
Am Fri, 28 Nov 2014 12:09:11 + schrieb Pavel Rappo : > I'm happy with any tool which is capable of "usages search". > Configured IDE is a good choice. What usage would you actually search in the OpenJDK code base? I think it is not very representative to search for usage in the JDK code base

Re: [7u-dev] Request for Review + Request for Approval to Backport: 8064391: More thread safety problems in core reflection

2014-11-28 Thread Martin Buchholz
Approved! On Fri, Nov 28, 2014 at 5:37 AM, Ivan Gerasimov wrote: > Hello! > > Would you please approve the backport from jdk 8u to 7u? > > The patch didn't apply cleanly due to generics in these two files: > src/share/classes/sun/reflect/BootstrapConstructorAccessorImpl.java > src/share/classes/s

RFR 8066188: BaseRowSet default value for escape processing is not correct

2014-11-28 Thread Lance Andersen
Hi all, Attached is a trivial change to address the default value for escape processing for BaseRowSet. This aligns with the javadocs now for BaseRowSet as well as the default for escape process per the JDBC spec and other RowSets. This also uncovered a JCK bug which I have made the JCK team a

Re: [7u-dev] Request for Review + Request for Approval to Backport: 8064391: More thread safety problems in core reflection

2014-11-28 Thread Seán Coffey
Looks fine to me Ivan. Please get jdk7u reviewer to review. Approved. regards, Sean. On 28/11/2014 13:37, Ivan Gerasimov wrote: Hello! Would you please approve the backport from jdk 8u to 7u? The patch didn't apply cleanly due to generics in these two files: src/share/classes/sun/reflect/Boo

[7u-dev] Request for Review + Request for Approval to Backport: 8064391: More thread safety problems in core reflection

2014-11-28 Thread Ivan Gerasimov
Hello! Would you please approve the backport from jdk 8u to 7u? The patch didn't apply cleanly due to generics in these two files: src/share/classes/sun/reflect/BootstrapConstructorAccessorImpl.java src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java All the other changes are ident

Re: RFR: Update java/nio/charset/Charset/NIOCharsetAvailabilityTest.java to eliminate dependency on sun.misc.Launcher

2014-11-28 Thread Alan Bateman
On 28/11/2014 10:35, Amy Lu wrote: jdk/test/java/nio/charset/Charset/NIOCharsetAvailabilityTest.java has dependency on sun.misc.Launcher This fix is to remove above internal API dependency from the test. bug: https://bugs.openjdk.java.net/browse/JDK-8066131 webrev: http://cr.openjdk.java.net/~w

JEP 198 JDK-8046390 involvement

2014-11-28 Thread Hendrik Dev
I'd like to get involved in this JEP. When active development will be kicked off? Is it enough to read this mailing list or are other sources more recommended and is http://hg.openjdk.java.net/jdk9/dev/jdk/ the correct repo? Thanks Hendrik -- Hendrik Saly (salyh, hendrikdev22) @hendrikdev22 PGP

Re: Library enhancement proposal for copying data from/to Reader/Writer InputStream/OutputStream

2014-11-28 Thread Pavel Rappo
I'm happy with any tool which is capable of "usages search". Configured IDE is a good choice. -Pavel > On 27 Nov 2014, at 22:59, Patrick Reinhart wrote: > > I have to say, that I normally use my IDE to search for references. > > What technique do you use to search for such patterns?

RFR: Update java/nio/charset/Charset/NIOCharsetAvailabilityTest.java to eliminate dependency on sun.misc.Launcher

2014-11-28 Thread Amy Lu
jdk/test/java/nio/charset/Charset/NIOCharsetAvailabilityTest.java has dependency on sun.misc.Launcher This fix is to remove above internal API dependency from the test. bug: https://bugs.openjdk.java.net/browse/JDK-8066131 webrev: http://cr.openjdk.java.net/~weijun/8066131/webrev.00/ Thanks, Am

Re: RFR: 8062771: Core reflection should use final fields whenever possible

2014-11-28 Thread Joel Borggrén-Franck
Hi, > On 27 nov 2014, at 20:21, Martin Buchholz wrote: > > Approved! Making fields final is super-safe. > I agree. All fields are private (or package private for Label) so this is safe. +1 cheers /Joel > On Wed, Nov 26, 2014 at 10:59 PM, Ivan Gerasimov > wrote: >> Hi! >> >> I can take car