Re: [9] RFR of 6880737: (fs) FileLock constructors don't throw NPE if the channel argument is null

On 17/01/2015 00:02, Brian Burkhalter wrote: Hello, Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-6880737 Patch: http://cr.openjdk.java.net/~bpb/6880737/webrev.00/ This is a minor change to check the channel parameter of FileLock(). Although this class i

Re: RFR (JAXP): 8054196: XPath: support any type

On 1/16/2015 1:29 PM, Lance Andersen wrote: Hi Joe, Overall it is OK, a few minor comments - Is there a reason that XPathExpressionImpl is no longer public and XPathImpl is public? Ok, I'll keep both public, may be useful in the future. - I think you can leverage {@inheritdoc} in your

[9] RFR of 6880737: (fs) FileLock constructors don't throw NPE if the channel argument is null

Hello, Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-6880737 Patch: http://cr.openjdk.java.net/~bpb/6880737/webrev.00/ This is a minor change to check the channel parameter of FileLock(). Although this class is public, a non-JDK subclass does not appear to

Re: [9] RFR (M): 8063137: Never-taken branches should be pruned when GWT LambdaForms are shared

On Jan 16, 2015, at 9:16 AM, Vladimir Ivanov wrote: > > http://cr.openjdk.java.net/~vlivanov/8063137/webrev.00/hotspot/ > > http://cr.openjdk.java.net/~vlivanov/8063137/webrev.00/jdk/ >

Re: JDK 9 RFR of 8067669: Documentation for methods in Number incomplete regarding too large values.

On Jan 8, 2015, at 7:13 AM, Andreas Lundblad wrote: > Although I was the one who brought it up, I think the whole > Comparator discussion is slightly off topic. I still think that > explicitly mentioning rounding and truncation is a bit confusing, as even the > JDK implementations resort to

Re: RFR JDK-8042262: Javadoc typo in java.util.Formatter

Hi Sherman, Looks fine. Roger On 1/16/2015 4:28 PM, Xueming Shen wrote: Please help review the typo in the Formatter javadoc. https://bugs.openjdk.java.net/browse/JDK-8042262 http://cr.openjdk.java.net/~sherman/8042262/ thanks! -Sherman

Re: RFR JDK-8042262: Javadoc typo in java.util.Formatter

+1 On Jan 16, 2015, at 4:28 PM, Xueming Shen wrote: > Please help review the typo in the Formatter javadoc. > > https://bugs.openjdk.java.net/browse/JDK-8042262 > http://cr.openjdk.java.net/~sherman/8042262/ > > thanks! > -Sherman Lance Andersen| Principal Member of Technical Staff | +1.781.

Re: RFR (JAXP): 8054196: XPath: support any type

Hi Joe, Overall it is OK, a few minor comments - Is there a reason that XPathExpressionImpl is no longer public and XPathImpl is public? - I think you can leverage {@inheritdoc} in your impl classes to avoid comment duplication possibly? - please remember to make the copyright year 2015 - X

RFR JDK-8042262: Javadoc typo in java.util.Formatter

Please help review the typo in the Formatter javadoc. https://bugs.openjdk.java.net/browse/JDK-8042262 http://cr.openjdk.java.net/~sherman/8042262/ thanks! -Sherman

[9] RFR of 8066842: java.math.BigDecimal.divide(BigDecimal, RoundingMode) produces incorrect result

Hello, Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8066842 Patch: http://cr.openjdk.java.net/~bpb/8066842/webrev.00/ The problem appears to have been that at line 4941 of the old source, in the divWord() method, one or both of the long variables ‘r’ and

Re: [9] RFR (M): 8063137: Never-taken branches should be pruned when GWT LambdaForms are shared

Nice! At least Hotspot part since I don't understand jdk part :) I would suggest to add more detailed comment (instead of simple "Stop profiling") to inline_profileBranch() intrinsic explaining what it is doing because it is not strictly "intrinsic" - it does not implement profileBranch() java

Re: [bg-jug] Re: RFR: 5050783: Throwable convenience method: String getStackTraceString()

Hi, On that note, I'm thinking loudly about whether or not it'd be appropriate > to extract common methods in PrintStream and PrintWriter to an interface. > java.io.Printable? > Thinking a bit further in a similar direction: a thinner interface gives more clarity about the API contract, it's also

Re: RFR (JAXP): 8054196: XPath: support any type

Hi all, Could you review the change? Thanks, Joe On 12/18/2014 1:24 PM, huizhe wang wrote: Hi, This is to add support for any type and improvement with new features reflected in the new evaluateExpression methods, XPathEvaluationResult and XPathNodes. https://bugs.openjdk.java.net/browse/

Re: RFR : 8068795: Missing trailing blank in a HttpServer response leads to client crashes

Thanks Chris, Could you please push it? Best Regards, Lev On 01/16/2015 09:14 PM, Chris Hegarty wrote: This looks ok to me Lev. -Chris. On 16 Jan 2015, at 17:02, Lev Priima wrote: The second space should not be omitted in first line(status-line) of a http response message: http://tools.ie

Re: Explicit Serialization API and Security

On 15/01/15 20:33, Peter Firmstone wrote: > Thanks Chris, > > WRT circular references, is it possible to detect and delay setting > these until after all verifiers run? It is possible to detect the circular reference. Currently you can retrieve a circular reference ( in readObject ) from readFi

Re: RFR : 8068795: Missing trailing blank in a HttpServer response leads to client crashes

This looks ok to me Lev. -Chris. On 16 Jan 2015, at 17:02, Lev Priima wrote: > The second space should not be omitted in first line(status-line) of a http > response message: http://tools.ietf.org/html/rfc7230#section-3.1.2 . > > Issue: http://bugs.openjdk.java.net/browse/JDK-8068795 > Patch:

Re: JDK 9 RFR of JDK-8068948: Update java.base module to use new try-with-resources statement

Might it also make sense to allow anonymous variables in the try-with-resource statement? So that something like `try (() -> System.out.println("closed")) {}` would work... I don't think that is necessary. In JDK 7, we started out allowing a general AutoCloseable expression in a try-with-res

[9] RFR (M): 8063137: Never-taken branches should be pruned when GWT LambdaForms are shared

http://cr.openjdk.java.net/~vlivanov/8063137/webrev.00/hotspot/ http://cr.openjdk.java.net/~vlivanov/8063137/webrev.00/jdk/ https://bugs.openjdk.java.net/browse/JDK-8063137 After GuardWithTest (GWT) LambdaForms became shared, profile pollution significantly distorted compilation decisions. It af

RFR : 8068795: Missing trailing blank in a HttpServer response leads to client crashes

The second space should not be omitted in first line(status-line) of a http response message: http://tools.ietf.org/html/rfc7230#section-3.1.2 . Issue: http://bugs.openjdk.java.net/browse/JDK-8068795 Patch: http://cr.openjdk.java.net/~lpriima/8068795/webrev.00/ Testing: $ jtreg -jdk:jdk9/dev/bui

Re: HashMap collision speed (regression 7->8)

On 14/01/15 15:50, Peter Levart wrote: Hi, Loosely related to this topic, there is some local variable caching of comparableClassFor() result already being performed inside iterative/recursive methods of TreeNode, but this caching is just positive caching, meaning that null return is not cached.

Re: [9] Review request : JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

On 16/01/15 12:50, Konstantin Shefov wrote: Hi Chris, Alan, thank you for reviewing. I have made a new webrev http://cr.openjdk.java.net/~kshefov/6933879/webrev.01 I have removed ":" and added a test case. This looks ok to me. -Chris. -Konstantin 16.01.2015 14:42, Chris Hegarty пишет: On

Re: [9] Review request : JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

Hi Chris, Alan, thank you for reviewing. I have made a new webrev http://cr.openjdk.java.net/~kshefov/6933879/webrev.01 I have removed ":" and added a test case. -Konstantin 16.01.2015 14:42, Chris Hegarty пишет: On 16/01/15 11:29, Alan Bateman wrote: On 16/01/2015 10:49, Chris Hegarty wrot

Re: RFR: 8068736: Avoid synchronization on Executable/Field.declaredAnnotations

Joel, Paul, thanks for reviewing! Pushed. /Claes On 01/15/2015 02:46 PM, Joel Borggrén-Franck wrote: Looks good. cheers /Joel On 15 jan 2015, at 13:32, Claes Redestad wrote: Hi, please review this patch to use double-checked locking to avoid synchronization overhead on repeated access t

Re: RFR 8068730: Increase the precision of the implementation of java.time.Clock.systemUTC()

> On 13 jan 2015, at 13:26, David Holmes wrote: > > Hi Daniel, > > On 13/01/2015 7:53 PM, Daniel Fuchs wrote: >> On 13/01/15 04:52, David Holmes wrote: Here is the new webrev with Stephen & your feedback included http://cr.openjdk.java.net/~dfuchs/webrev_8068730/webrev.01/

Re: [9] Review request : JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

On 16/01/15 11:29, Alan Bateman wrote: On 16/01/2015 10:49, Chris Hegarty wrote: : I don't see any reason to update the spec here, given that the set of allowable character is not clearly defined in the relevant RFC's. I think we need to create a bug to look into this more. Inet6Address allow

Re: [9] Review request : JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

On 16/01/2015 10:49, Chris Hegarty wrote: : I don't see any reason to update the spec here, given that the set of allowable character is not clearly defined in the relevant RFC's. I think we need to create a bug to look into this more. Inet6Address allows the scope of be any String but URI p

Re: [9] Review request : JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

On 15/12/14 12:01, Alan Bateman wrote: On 15/12/2014 11:25, Chris Hegarty wrote: Konstantin, I did reply to this RFR [1], with a question, that is still unanswered. -Chris. [1] http://mail.openjdk.java.net/pipermail/net-dev/2014-December/008782.html I can think of configurations where the s