Re: String.indexOf optimization

2015-01-24 Thread Martin Buchholz
On Sat, Jan 24, 2015 at 1:19 PM, Vitaly Davidovich wrote: > Try -XX:+UnlockDiagnosticVMOptions -XX:DisableIntrinsic:_indexOf > Thank you very much! Hard to find because -XX:+PrintFlagsFinal is insufficient - also needs -XX:+UnlockDiagnosticVMOptions

Re: String.indexOf optimization

2015-01-24 Thread Vitaly Davidovich
Try -XX:+UnlockDiagnosticVMOptions -XX:DisableIntrinsic:_indexOf sent from my phone On Jan 24, 2015 4:13 PM, "Martin Buchholz" wrote: > I took another look. It seems to me that the java code implementing > String.indexOf still assumes the old String layout and so is full of dead > code, which s

Re: String.indexOf optimization

2015-01-24 Thread Martin Buchholz
I took another look. It seems to me that the java code implementing String.indexOf still assumes the old String layout and so is full of dead code, which should be excised just to be clean. (I continue to think the change to String layout came too late in the life of Java and is incomplete in way

Re: [9] RFR of 8069269: (spec) Defect in the System.nanoTime spec

2015-01-24 Thread Martin Buchholz
How about: --- a/src/java.base/share/classes/java/lang/System.java +++ b/src/java.base/share/classes/java/lang/System.java @@ -376,19 +376,16 @@ * the difference between two such values, obtained within the same * instance of a Java virtual machine, is computed. * - * For ex

Re: RFR 9: 8068578: test/java/io/Serializable/subclassGC/SubclassGC.java assumes app class loader is a URLClassLoader

2015-01-24 Thread Alan Bateman
On 24/01/2015 00:15, Brent Christian wrote: Hi, Please review this test case update. Bug: https://bugs.openjdk.java.net/browse/JDK-8068578 Webrev: http://cr.openjdk.java.net/~bchristi/8068578/webrev.0/ The test relies on creating a new URLClassLoader and using it to load a subclass of ObjectO

Re: RFR: JDK-8055190: Cleanup include and exclude of core-libs native libraries after source code restructure

2015-01-24 Thread Alan Bateman
On 23/01/2015 14:59, Erik Joelsson wrote: : Can refs.allowed be removed? I thought we removed the JDK 8 dependency checker early in JDK 9 so this file shouldn't be needed. I was wondering what it was and could not find any usages. With your confirmation I have opted to remove it completely in