Re: RFR (xs): JDK-8072611: (process) ProcessBuilder redirecting output to file should work with long file names (win)

Hi Thomas, Conventionally, File.deleteOnExit is used for file cleanup in the test. An unexpected exception could leave the file around. An alternative is to use try {...} finally {file.delete}; Fixed file names can sometime cause issues if they are left around by previous test runs or with a

Re: JEP 102 Process Updates revised API draft

Hi David, On 2/9/15 6:44 PM, David M. Lloyd wrote: On 02/09/2015 05:25 PM, Roger Riggs wrote: Hi, After a protracted absence from working on JEP 102, the updated API draft provides access to process hierarchies and individual process information; as permitted by the OS. The relationship

Re: JDK 9 RFR of JDK-8069255: Suppress deprecation warnings in jdk.rmic module

Thank you Roger! Yes, please sponsor this. Thanks, Amy On 2/10/15 9:55 AM, Roger Riggs wrote: Hi Amy, Looks fine to me; If no one already volunteered to sponsor, I can. Roger On 2/9/15 8:20 PM, Amy Lu wrote: Kindly reminder ... On 1/29/15 11:09 AM, Amy Lu wrote: I updated the webrev,

Re: RFR (xs): JDK-8072611: (process) ProcessBuilder redirecting output to file should work with long file names (win)

Hi Thomas, the change looks good and I can sponsor it once it is reviewed. Just some small notes: - it seems that getPath() isn't used anywhere else in ProcessImpl_md.c and because it is static it can't be used anywhere else. So can you please remove it completely. - io_util_md.h has a list of

Re: FilePermission Canonical path optimization

It sounds to me like we need additional means to protect the file permission without canocialization. I am looking forward to seeing the new proposal with appropriate solution for problem Peter raised. Thanks a lot! 2015-02-09 14:50 GMT+08:00 Wang Weijun weijun.w...@oracle.com: On Feb 9,

Re: JEP 102 Process Updates revised API draft

On 9 February 2015 at 23:44, David M. Lloyd david.ll...@redhat.com wrote: ProcessHandle.Info provides a startTime and totalTime. But it seems odd and inconsistent that startTime is an Instant, yet totalTime is a raw long as opposed to the arguably more consistent Duration. Is there a reason

RFR 8068587: ScriptEngineFactory.getParameter() should specify NPE for a null key

Please review http://cr.openjdk.java.net/~sundar/8068587/ for https://bugs.openjdk.java.net/browse/JDK-8068587 Thanks, -Sundar

Re: JDK 9 RFR of JDK-8069255: Suppress deprecation warnings in jdk.rmic module

Hi Amy, Looks fine to me; If no one already volunteered to sponsor, I can. Roger On 2/9/15 8:20 PM, Amy Lu wrote: Kindly reminder ... On 1/29/15 11:09 AM, Amy Lu wrote: I updated the webrev, suppress deprecation warnings for jdk/src/jdk.rmic/share/classes/sun/tools/java/* now also covered.

Re: RFR: JDK-8068682 - Deprivilege/move java.corba to the ext class loader

On 08/02/2015 06:58, Mandy Chung wrote: : Mark's patch is first to move it out from the boot loader to the ext class loader. Identifying the permissions required by corba requires more effort and not straight-forward. So it's granted with AllPermissions for now and reduce the permission

Re: RFR 8071479: Stream and lamdification improvements to j.u.regex.Matcher

Here is an alternative that pushes the methods on to Pattern instead: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8071479--Matcher-stream-results/on-Pattern/webrev/ (Whe webrev reports some files as empty, please ingore those, i have this webrev stacked on the previous one.) I have also

RFR(XS): 8072770: [TESTBUG] Some Introspector tests fail with a Java heap bigger than 4GB

Hi, the three Introspector test: java/beans/Introspector/7064279/Test7064279.java java/beans/Introspector/Test7172865.java java/beans/Introspector/Test7195106.java provoke an OutOfMemory situation by repeatedly allocating constantly growing arrays with the following loop: int[] array = new

RFR (xs): JDK-8072611: (process) ProcessBuilder redirecting output to file should work with long file names (win)

Hi all, please review this small change at your convenience: http://cr.openjdk.java.net/~stuefe/webrevs/8072611/webrev.01/webrev/ It fixes a small issue which causes ProcessBuilder not to be able to open files to redirect into (when using Redirect.append) on windows, if that file name is longer

Re: JEP 102 Process Updates revised API draft

On 02/09/2015 05:25 PM, Roger Riggs wrote: Hi, After a protracted absence from working on JEP 102, the updated API draft provides access to process hierarchies and individual process information; as permitted by the OS. The relationship between Process and ProcessHandle is clarified and the

Re: JDK 9 RFR of JDK-8041395: Doclint regression in java.net.SocketOption

looks fine joe best lance On Feb 9, 2015, at 6:27 PM, joe darcy joe.da...@oracle.com wrote: Hello, Please review these straightforward changes to address some doclint issues in java.net: JDK-8041395: Doclint regression in java.net.SocketOption

JEP 102 Process Updates revised API draft

Hi, After a protracted absence from working on JEP 102, the updated API draft provides access to process hierarchies and individual process information; as permitted by the OS. The relationship between Process and ProcessHandle is clarified and the security model validated. Both Processes and

JDK 9 RFR of JDK-8041395: Doclint regression in java.net.SocketOption

Hello, Please review these straightforward changes to address some doclint issues in java.net: JDK-8041395: Doclint regression in java.net.SocketOption http://cr.openjdk.java.net/~darcy/8041395.0/ Patch below. Thanks, -Joe ---

Re: RFR 8064924: Update java.net.URL to work with modules

Thank you for the comments Alan. On 06/02/15 10:20, Alan Bateman wrote: On 04/02/2015 15:11, Chris Hegarty wrote: Agreed. Updated in-place http://cr.openjdk.java.net/~chegar/8064924/03/specdiff/overview-summary.html I think the approach and naming is good. A few small comments on the

Re: JDK 9 RFR of JDK-8069255: Suppress deprecation warnings in jdk.rmic module

Kindly reminder ... On 1/29/15 11:09 AM, Amy Lu wrote: I updated the webrev, suppress deprecation warnings for jdk/src/jdk.rmic/share/classes/sun/tools/java/* now also covered. Please review: http://cr.openjdk.java.net/~amlu/8069255/webrev.01/ Thanks, Amy On 1/19/15 2:31 PM, Amy Lu wrote: