JDK 9 RFR of JDK-8075670: Remove intermittent keyword from some tests

2015-03-22 Thread joe darcy
Hello, Upon closer review, some of the tests marked as failing intermittently in JDK-8075565 seem to just have suffered from transient infrastructure problems. Therefore, those tests test/java/nio/channels/AsynchronousSocketChannel/Basic.java test/java/nio/channels/Selector/Wakeup.java tes

Re: Javadoc nit Throwable#getStackTraceElement

2015-03-22 Thread Bernd Eckenfels
Hello David, interesting, I thought I saw it in 8u40, however when I check more closely it was Eclipse suggesting me the source of a 1.5 JDK (even when the project I was working with was using 8u40). It has already a @code element. So sorry for the false report. BTW: speaking of Throwable, the a

Re: Javadoc nit Throwable#getStackTraceElement

2015-03-22 Thread David Holmes
On 22/03/2015 6:47 PM, Bernd wrote: Oh yes, sorry of course. My report was about the wrong % entity escape. The expression should be >= like before. I missed the % vs & :) But I don't see this in our sources going back a long long time - where did you see this? Thanks, David Greetings Be

Re: Javadoc nit Throwable#getStackTraceElement

2015-03-22 Thread Bernd
Oh yes, sorry of course. My report was about the wrong % entity escape. The expression should be >= like before. Greetings Bernd David Holmes schrieb am So., 22. Mär. 2015 09:37: > On 22/03/2015 9:54 AM, Bernd Eckenfels wrote: > > There is an typo in the javadoc, > > > > * @throws IndexOutOfB

Re: Javadoc nit Throwable#getStackTraceElement

2015-03-22 Thread David Holmes
On 22/03/2015 9:54 AM, Bernd Eckenfels wrote: There is an typo in the javadoc, * @throws IndexOutOfBoundsException if index %lt; 0 || * index >= getStackTraceDepth() Maybe using {@code index < 0 || index > getStackTraceDepth()} would be better here? Don't we index from zero to ge