Re: Review request for JDK-8051559: JAXP function dom tests conversion

2015-04-03 Thread Lance Andersen
On Apr 3, 2015, at 5:41 PM, huizhe wang wrote: > > On 4/2/2015 10:11 PM, Frank Yuan wrote: >> Yes, understand, thank you very much! I will follow this rule you talked in >> future! >> >> Well, since current code is ok for you, would you like to be my sponsor to >> push the code? > > Will d

RFR JDK-8076641: getNextEntry throws ArrayIndexOutOfBoundsException when unzipping file

2015-04-03 Thread Xueming Shen
Hi, Please help review the changeset for issue: https://bugs.openjdk.java.net/browse/JDK-8076641 webrev: http://cr.openjdk.java.net/~sherman/8076641/webrev/ It appears there is zip tool over there that purposely doesn't generate the complete NTFS timestamp in loc table (while it does generate

Re: 8076442: Cannot fully read BitSet.stream() if bit Integer.MAX_VALUE is set

2015-04-03 Thread Henry Jen
Looks fine to me, thanks for taking care of it. Cheers, Henry On 04/03/2015 02:57 AM, Chris Hegarty wrote: This is a request for review for a small change to address 8076442 [1]. Seems to be a day one bug in the internal BitSetIterator, for a boundary condition when the Integer.MAX_VALUE bit

Re: Review request for JDK-8051559: JAXP function dom tests conversion

2015-04-03 Thread huizhe wang
On 4/2/2015 10:11 PM, Frank Yuan wrote: Yes, understand, thank you very much! I will follow this rule you talked in future! Well, since current code is ok for you, would you like to be my sponsor to push the code? Will do once Lance finishes the review. Best, Joe Best Regards Frank

Re: RFR: JDK-8076583: move jdk.Exported from langtools to jdk

2015-04-03 Thread Tim Bell
@Build folk: There is a trivial change to a makefile in the langtools repo. Looks good to me. Tim On 04/02/15 16:52, Jonathan Gibbons wrote: Sorry for the relatively wide distribution. JDK-8076583 is a conceptually simple cleanup, to move the source file for the jdk.Exported class from the

Re: RFR [9] 8071474: Better failure atomicity for default read object

2015-04-03 Thread Peter Levart
On 04/03/2015 05:03 PM, Chris Hegarty wrote: Peter, Some more thought is needed in that area of the field setter API. If there are no strong objections, then I’d like to proceed with this version of better failure atomicity, and follow up as needed. -Chris. I agree. We can revisit this la

Re: RFR: JDK-8076583: move jdk.Exported from langtools to jdk

2015-04-03 Thread Jan Lahoda
On 3.4.2015 01:52, Jonathan Gibbons wrote: Sorry for the relatively wide distribution. JDK-8076583 is a conceptually simple cleanup, to move the source file for the jdk.Exported class from the langtools repo (where it is a singleton outlier) to the jdk repo (alongside most of the rest of the cla

RFR: 8076549: Update JAX-WS RI integration to latest version (2.2.11-b150402.1412)

2015-04-03 Thread Aleksej Efimov
Hello, Can I have a review for a JDK9 bulk update of JAX-B/WS from upstream projects. Webrev: http://cr.openjdk.java.net/~aefimov/8076549/9/00/ More details in issue description: https://bugs.openjdk.java.net/browse/JDK-8076549 Thank you, Aleksej

Re: RFR [9] 8071474: Better failure atomicity for default read object

2015-04-03 Thread Chris Hegarty
Peter, Some more thought is needed in that area of the field setter API. If there are no strong objections, then I’d like to proceed with this version of better failure atomicity, and follow up as needed. -Chris. On 20 Mar 2015, at 16:30, Chris Hegarty wrote: > Hi Peter, > > On 20 Mar 2015,

Re: RFR: JDK-8076583: move jdk.Exported from langtools to jdk

2015-04-03 Thread Mandy Chung
On 4/2/2015 4:52 PM, Jonathan Gibbons wrote: Sorry for the relatively wide distribution. JDK-8076583 is a conceptually simple cleanup, to move the source file for the jdk.Exported class from the langtools repo (where it is a singleton outlier) to the jdk repo (alongside most of the rest of the

Re: JEP 110 HTTP 2 client API

2015-04-03 Thread Chris Hegarty
On 3 Apr 2015, at 14:20, Pavel Rappo wrote: > Hi Kasper, > > I assume your questions are all about WebSocket part, right? If so, then > >> 1) >> Would it possible to add a connect timeout parameter. >> builder.setConnectTimeout(long timeout, TimeUnit unit) >> >> For some reason it was left ou

Re: JEP 110 HTTP 2 client API

2015-04-03 Thread Pavel Rappo
Hi Kasper, I assume your questions are all about WebSocket part, right? If so, then > 1) > Would it possible to add a connect timeout parameter. > builder.setConnectTimeout(long timeout, TimeUnit unit) > > For some reason it was left out of the javax.websocket API. And working > around it is a s

Re: JDK-8060068/JDK-8067904 DriverManager clean-up introduces bootstrap problem that breaks production drivers

2015-04-03 Thread Robert Gibson
Thanks Alan,Note that the repro given in my mail is a bit simpler than the current defect description, especially if you don't have access to the "MyFace"  JDBC driver.Regards,Robert On Friday, 3 April 2015, 13:04, Alan Bateman wrote: On 03/04/2015 10:33, Robert Gibson wrote: > Hi there, > >

Re: 8076442: Cannot fully read BitSet.stream() if bit Integer.MAX_VALUE is set

2015-04-03 Thread Alan Bateman
On 03/04/2015 10:57, Chris Hegarty wrote: This is a request for review for a small change to address 8076442 [1]. Seems to be a day one bug in the internal BitSetIterator, for a boundary condition when the Integer.MAX_VALUE bit is set. The change to the iterator, and test, is in line with th

Re: JDK-8060068/JDK-8067904 DriverManager clean-up introduces bootstrap problem that breaks production drivers

2015-04-03 Thread Alan Bateman
On 03/04/2015 10:33, Robert Gibson wrote: Hi there, We are doing some early testing with JDK 9 and have discovered that the changes made to java.sql.DriverManager back in November/December have introduced an incompatibility with our JDBC driver (that we have used unchanged since Java 6) when

8076442: Cannot fully read BitSet.stream() if bit Integer.MAX_VALUE is set

2015-04-03 Thread Chris Hegarty
This is a request for review for a small change to address 8076442 [1]. Seems to be a day one bug in the internal BitSetIterator, for a boundary condition when the Integer.MAX_VALUE bit is set. The change to the iterator, and test, is in line with the advise in BitSet.nextSetBit(int) ( break/te

JDK-8060068/JDK-8067904 DriverManager clean-up introduces bootstrap problem that breaks production drivers

2015-04-03 Thread Robert Gibson
Hi there, We are doing some early testing with JDK 9 and have discovered that the changes made to java.sql.DriverManager back in November/December have introduced an incompatibility with our JDBC driver (that we have used unchanged since Java 6) when it is pre-loaded with Class.forName (as reco