Re: [9] RFR (S): Class.getSimpleName() should work for non-JLS compliant class names

2015-04-09 Thread John Rose
On Apr 8, 2015, at 7:52 PM, David Holmes david.hol...@oracle.com wrote: Meta-question: if this is non-Java code then what does/should simpleName even mean? Returns the simple name of the underlying class as given in the source code. If there is no (java) source code does this have any

[9] RFR (XXS): 8077054: DMH LFs should be customizeable

2015-04-09 Thread Vladimir Ivanov
http://cr.openjdk.java.net/~vlivanov/8077054/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8077054 It's a followup fix for JDK-8069591 [1]. As Charlie observed, it's important to customize DirectMethodHandles as well. Otherwise, additional frame for DMH LambdaForm is created and it

Re: [9] RFR (S): Class.getSimpleName() should work for non-JLS compliant class names

2015-04-09 Thread David Holmes
Hi Remi, On 9/04/2015 4:10 PM, Rémi Forax wrote: Hi David, The problem is that j.l.i.MethodType.toString uses getSimpleName and j.l i.WrongMethodTypeException uses MethodType.toString. So if getSimpleName returns a blank string, you destroy the debuggability of any invokedynamic/methodhandle

Re: RFR: 8076090: jimage extract + recreate broken again

2015-04-09 Thread Mandy Chung
On 4/9/15 7:59 AM, Jim Laskey (Oracle) wrote: Thanks Mandy. Changed the main to ; public static void main(String[] args) { final String JAVA_HOME = System.getProperty(java.home); Path jimagePath = Paths.get(JAVA_HOME, bin, jimage); Path bootimagePath =

RFR (XXS) : 8050123: Incorrect property name documented in CORBA InputStream API

2015-04-09 Thread Seán Coffey
https://bugs.openjdk.java.net/browse/JDK-8050123 diff --git a/src/java.corba/share/classes/org/omg/CORBA_2_3/portable/InputStream.java b/src/java.corba/share/classes/org/omg/CORBA_2_3/portable/InputStream.java --- a/src/java.corba/share/classes/org/omg/CORBA_2_3/portable/InputStream.java +++

Re: [9] RFR (XXS): 8077054: DMH LFs should be customizeable

2015-04-09 Thread John Rose
Looks good. Would you please also check the number of distinct LFs compiled when running standard benchmarks? (With and without the change.) The number should go up, but only slightly. Thanks! — John On Apr 9, 2015, at 11:44 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com wrote:

Re: [9] RFR (S): Class.getSimpleName() should work for non-JLS compliant class names

2015-04-09 Thread Rémi Forax
Hi David, The problem is that j.l.i.MethodType.toString uses getSimpleName and j.l i.WrongMethodTypeException uses MethodType.toString. So if getSimpleName returns a blank string, you destroy the debuggability of any invokedynamic/methodhandle calls. regards, Rémi Le 9 avril 2015 04:52:15

Re: RFR (XXS) : 8050123: Incorrect property name documented in CORBA InputStream API

2015-04-09 Thread Lance @ Oracle
+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 9, 2015, at 9:42 AM, Seán Coffey sean.cof...@oracle.com wrote:

Re: RFR: 8076090: jimage extract + recreate broken again

2015-04-09 Thread Jim Laskey (Oracle)
Thanks Mandy. Changed the main to ; public static void main(String[] args) { final String JAVA_HOME = System.getProperty(java.home); Path jimagePath = Paths.get(JAVA_HOME, bin, jimage); Path bootimagePath = Paths.get(JAVA_HOME, lib, modules, bootmodules.jimage);

RFR 9: 8077350 Process API Updates Implementation Review

2015-04-09 Thread Roger Riggs
Please review the API and implementation of the Process API Updates described inJEP 102 https://bugs.openjdk.java.net/browse/JDK-8046092. Please review and comment by April 23rd. The recommendation to make ProcessHandle an interface is included allowing the new functions to be extended by

Re: [9] RFR (S): Class.getSimpleName() should work for non-JLS compliant class names

2015-04-09 Thread Vladimir Ivanov
David, thanks for the feedback! Updated webrev: http://cr.openjdk.java.net/~vlivanov/8057919/webrev.01/jdk http://cr.openjdk.java.net/~vlivanov/8057919/webrev.01/hotspot I restored original logic and call into VM only if it fails. The logic to compute simple name (Class.getSimpleName())

Re: [9] RFR (S): Class.getSimpleName() should work for non-JLS compliant class names

2015-04-09 Thread Vladimir Ivanov
On 4/9/15 9:10 AM, Rémi Forax wrote: Hi David, The problem is that j.l.i.MethodType.toString uses getSimpleName and j.l i.WrongMethodTypeException uses MethodType.toString. So if getSimpleName returns a blank string, you destroy the debuggability of any invokedynamic/methodhandle calls.

Re: JDK-8060068/JDK-8067904 DriverManager clean-up introduces bootstrap problem that breaks production drivers

2015-04-09 Thread Robert Gibson
Hi again, I just realised that I missed an important bit from the test case in my earlier mail. The jar file used for the test needs to contain, in addition to the class files, a text file called META-INF/services/java.sql.Driver containing the text MyDriver since it is the interaction between