Re: RFR 9: 8048264 : StringBuffer's codePoint methods throw unspecified IndexOutOfBoundsException

On 13/04/2015 23:49, Brent Christian wrote: Hello, Please review this small javadoc change. It was discovered that some codePoint-related methods in StringBuffer are missing documentation for throwing IndexOutOfBoundsException. The methods are: codePointAt(int) codePointBefore(int)

Re: RFR (S): 8076461: JSR292: remove unused native and constants

Looks good. I'll push it for you. Best regards, Vladimir Ivanov On 4/14/15 2:33 PM, Michael Haupt wrote: Hi John, thanks again; I've applied your suggestions, re-tested as before and uploaded the revision to http://cr.openjdk.java.net/~mhaupt/8076461/webrev.02/. Best, Michael Am

Contracts, subtyping, JDK-8029804

Hi, I've been looking into an old doc issue [1] on incompleteness in description of handling incorrect arguments in BufferedWriter.write(String, int, int). In a nutshell it's concerned that given the following facts: 1. Writer.write(String str, int off, int len) promises to throw

Re: [9] RFR (S): Class.getSimpleName() should work for non-JLS compliant class names

David, John, thanks for review! Best regards, Vladimir Ivanov On 4/14/15 3:47 AM, David Holmes wrote: On 14/04/2015 3:39 AM, Vladimir Ivanov wrote: John, David, thanks for the feedback! What do you think about the following version:

Re: RFR (S): 8076461: JSR292: remove unused native and constants

Hi John, thanks again; I've applied your suggestions, re-tested as before and uploaded the revision to http://cr.openjdk.java.net/~mhaupt/8076461/webrev.02/. Best, Michael Am 13.04.2015 um 21:38 schrieb John Rose john.r.r...@oracle.com: That's much better; thanks. Glad to hear the

Re: RFR 8073056: Repeating annotations throws java.security.AccessControlException with a SecurityManager

Mandy, Paul, what do you think? cheers /Joel On 28 Mar 2015, at 11:24, Joel Borggrén-Franck joel.fra...@oracle.com wrote: Hi, On 27 Feb 2015, at 11:06, Peter Levart peter.lev...@gmail.com wrote: On 02/27/2015 10:27 AM, Joel Borggrén-Franck wrote: On 26 feb 2015, at 22:35, Peter Levart

Re: RFR 9: 8077350 Process API Updates Implementation Review

On 04/09/2015 10:00 PM, Roger Riggs wrote: Please review the API and implementation of the Process API Updates described inJEP 102 https://bugs.openjdk.java.net/browse/JDK-8046092. Please review and comment by April 23rd. The recommendation to make ProcessHandle an interface is included

Re: AWT Dev [9] Review Request: 8076264 [macosx] Launching app on MacOSX requires enclosing class

Hi Sergey, looks good to me. Thanks Kumar On 4/14/2015 9:02 AM, Sergey Bylokhov wrote: Hi, Kumar. Thanks for your suggestions. Then new version of the fix: http://cr.openjdk.java.net/~serb/8076264/webrev.02 On 10.04.15 4:39, Kumar Srinivasan wrote:

Re: AWT Dev [9] Review Request: 8076264 [macosx] Launching app on MacOSX requires enclosing class

Hi, Kumar. Thanks for your suggestions. Then new version of the fix: http://cr.openjdk.java.net/~serb/8076264/webrev.02 On 10.04.15 4:39, Kumar Srinivasan wrote: src/java.base/macosx/native/libjli/java_md_macosx.c we need a comment here explaining why the Exception is cleared, basically what

Re: [9] RFR of 8075156: (prefs) remove() should disallow the use of the null control character '\u0000' as key

Hi Roger, Thanks for taking the time to review this recap. Your suggestion to forge ahead with the approach already taken seems to be reasonable. I concur that a fail-fast approach of throwing an IAE as soon as the bad character is encountered if preferable to waiting for some inscrutable

Re: [9] RFR of 8075156: (prefs) remove() should disallow the use of the null control character '\u0000' as key

Hi Brian, Thanks for digging deeper and the recap. I don't see any cases in which it is necessary or valuable to allow \0 in Strings (key or value). The original bug report did not indicate whether it was discovered as a testing exercise or when diagnosing a bug in an application. The

Re: Contracts, subtyping, JDK-8029804

Hi Pavel, On 14/04/2015 9:57 PM, Pavel Rappo wrote: Hi, I've been looking into an old doc issue [1] on incompleteness in description of handling incorrect arguments in BufferedWriter.write(String, int, int). In a nutshell it's concerned that given the following facts: 1.

Re: RFR 9: 8077350 Process API Updates Implementation Review

Hi Peter, Thanks for the review. On 4/14/2015 11:47 AM, Peter Levart wrote: On 04/09/2015 10:00 PM, Roger Riggs wrote: Please review the API and implementation of the Process API Updates described inJEP 102 https://bugs.openjdk.java.net/browse/JDK-8046092. Please review and comment by

Re: RFR 9: 8077350 Process API Updates Implementation Review

On 14/04/2015 16:47, Peter Levart wrote: The behavior of pipes on Windows is a little different (perhaps because the Pipe NIO API uses sockets under the hood on Windows - why is that? Windows does have a pipe equivalent). Multiplexing is a bit limited on Windows, I don't think you can select

Re: [9] RFR of 8075156: (prefs) remove() should disallow the use of the null control character '\u0000' as key

Please review at your convenience this latest patch modified from the previous one pursuant to the most recent comments. Issue: https://bugs.openjdk.java.net/browse/JDK-8075156 Patch: http://cr.openjdk.java.net/~bpb/8075156/webrev.01/ Summary: * Revise Preferences javadoc to indicate IAE for

Re: JDK-8060068/JDK-8067904 DriverManager clean-up introduces bootstrap problem that breaks production drivers

Hi Robert, I had a chance to look at the code you provided and part of the problem is that MyDriver is not adhering to the JDBC specification as the call to registerDriver *must* be in the static block of the java.sql.Driver implementation and *not* in the constructor. The