On 05/12/2015 07:41 AM, Peter Levart wrote:
Taking another look at this deadlock issue and the compatibility
concerns, I wonder if we should keep this change as a special
implementation for system properties rather than having this change to
java.util.Properties class. Properties is a
Everybody,
Updated version:
http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.03/
Now it iterates over queue and output result sorted by number of instances.
-Dmitry
On 2015-05-07 00:51, Derek White wrote:
Hi Dmitry, Staffan,
Lots of good comments here.
On the topic of what
Your updated webrev
http://cr.openjdk.java.net/~igerasim/8074657/02/webrev/jdk.changeset
Looks Good To Me!
On Mon, May 11, 2015 at 4:02 PM, Ivan Gerasimov ivan.gerasi...@oracle.com
wrote:
Thanks Martin!
Yes, did that.
I also fixed indentation in some places and replaced StringBuffer with
Hi Ivan,
The code below looks wrong to me - sb.length() resolves to sb.count, not
v2.length.
If I'm correct, then there's a missing test to be added, since this error
should be caught by some test.
private boolean nonSyncContentEquals(AbstractStringBuilder sb) {
-char v1[] = value;
Sounds good, to make note of the style cleanup.
I suppose if this were backported to JDK 8 the source cleanup would not
be an issue.
Thanks, Roger
On 5/12/2015 3:18 PM, Ivan Gerasimov wrote:
Hi Roger.
On 12.05.2015 21:32, Roger Riggs wrote:
Hi Ivan,
Perhaps the bug description should be
Hi Ivan,
Perhaps the bug description should be updated.
The original changes the bug identifies are lost in the collateral updates.
Roger
On 5/11/2015 7:02 PM, Ivan Gerasimov wrote:
Thanks Martin!
Yes, did that.
I also fixed indentation in some places and replaced StringBuffer with
On Tue, May 12, 2015 at 11:32 AM, Roger Riggs roger.ri...@oracle.com
wrote:
The original changes the bug identifies are lost in the collateral updates.
Roger is correct that user-invisible changes are mixed with user-visible
ones.
In a perfect world with low-friction commits, we would have
On 12.05.2015 20:34, Martin Buchholz wrote:
Hi Ivan,
The code below looks wrong to me - sb.length() resolves to sb.count,
not v2.length.
If I'm correct, then there's a missing test to be added, since this
error should be caught by some test.
private boolean
Hi Roger.
On 12.05.2015 21:32, Roger Riggs wrote:
Hi Ivan,
Perhaps the bug description should be updated.
The original changes the bug identifies are lost in the collateral
updates.
Adding the spaces to the strings are the only changes here noticeable
from outside.
What if we keep the
All your changes look good. But:
---
Not your bug, but it looks like the below should instead be:
throw new StringIndexOutOfBoundsException(beginIndex);
Perhaps fix in a follow-on change.
1935 if (subLen 0) {
1936 throw new StringIndexOutOfBoundsException(subLen);
---
We
On 05/12/2015 10:49 PM, Mandy Chung wrote:
But I think it should be pretty safe to make the java.util.Properties
object override all Hashtable methods and delegate to internal CMH so
that:
- all modification methods + all bulk read methods such as
(keySet().toArray, values.toArray) are made
On 05/11/2015 11:41 PM, Peter Levart wrote:
On 05/12/2015 07:41 AM, Peter Levart wrote:
Taking another look at this deadlock issue and the compatibility
concerns, I wonder if we should keep this change as a special
implementation for system properties rather than having this change to
Peter,
http://cr.openjdk.java.net/~vlivanov/8079205/webrev.01
https://bugs.openjdk.java.net/browse/JDK-8079205
Your Finalizator touches are good. Supplier interface is not needed as
there is a public Reference superclass that can be used for return type
of
Hi Dmitry,
You iterate the queue then, not the unfinalized list. That's more logical.
Holding the queue's lock may pause reference handler and finalizer
threads for the entire time of iteration. This can blow up the
application. Suppose one wants to diagnose the application because he
Hi Pavel,
Is there anything I can do in the meantime?
Unfortunately I do not have no account on cr.openjdk.java.net
http://cr.openjdk.java.net/, so I need to paste the patch to the mailing list
directly.
Cheers Patrick
Am 10.05.2015 um 21:16 schrieb Chris Hegarty chris.hega...@oracle.com:
Committed!
On Fri, May 8, 2015 at 11:33 AM, Xueming Shen xueming.s...@oracle.com
wrote:
looks good!
On 5/8/15 10:58 AM, Jeremy Manson wrote:
There's a fairly harmless buffer underflow with empty zip names in libzip.
Martin has offered to sponsor this (right, Martin?).
We detected this
Hello
I've tried to play with the new JSR 308 feature (type annotations) and I'm
facing a rather annoying limitation:
Suppose a class:
public static class SimpleEntityCodecFactoryTest {
private Map@JSON Integer,Map@Frozen
Integer,@Enumerated(value = Enumerated.Encoding.NAME, test =
17 matches
Mail list logo
