Re: RFR 9: 8074818: Resolve disabled warnings for libjava

On 2015-05-22 16:02, Roger Riggs wrote: Hi Alan, The change to make the assert about the build numbers in getVersionInfo should be a different issue. Perhaps it makes sense to do that as part of the JEP 223: New Version-String Scheme that is specific to the Oracle JDK. The current JEP-223

Re: Review Request 8074432: Move jdeps to jdk.compiler module

On 24/05/2015 05:00, Mandy Chung wrote: This will move jdeps to the same module as other langtools javac and javap. Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074432/webrev.00/ This is the final change to resolve the open issue JDK-8072601 (Re-examine jdk.runtime and

RFR [9] 8040147: minor cleanup for docs

Hello, Could you please review the fix http://cr.openjdk.java.net/~avstepan/8040147/webrev.02/ for https://bugs.openjdk.java.net/browse/JDK-8040147 Just a minor fix for docs (some tidy warnings + misprints). Thanks, Alexander

Re: i18n dev RFR JDK-8042125: Japanese character converters incompatible between Java 7 and Java 8

Looks good to me. Masayoshi On 5/24/2015 9:26 AM, Xueming Shen wrote: Hi Please help the change for 8042125 issue: https://bugs.openjdk.java.net/browse/JDK-8042125 webrev: http://cr.openjdk.java.net/~sherman/8042125 It's a regression caused by the changes of JDK-6653797. The direct

RFR 8068978: All versions of javax.script.ScriptEngine.eval(...) method may clarify ScriptException throwing

Please review http://cr.openjdk.java.net/~sundar/8068978/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8068978 Thanks, -Sundar

Re: RFR 8068978: All versions of javax.script.ScriptEngine.eval(...) method may clarify ScriptException throwing

+1 On May 25, 2015, at 2:54 PM, A. Sundararajan sundararajan.athijegannat...@oracle.com wrote: Please review http://cr.openjdk.java.net/~sundar/8068978/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8068978 Thanks, -Sundar

Re: RFR [9] 8040147: minor cleanup for docs

Hi Alexander, Overal this looks OK. One suggestion for webrevs is to change code/code to {@code} while you are updating specific comments (not the entire file, but at least the lines you are touching). Thank you for making the changes. Best Lance On May 25, 2015, at 5:40 AM, alexander

DualPivotQuicksort webrev for JDK-8080945

Hi all, Unless I'm doing something immensely stupid, the DualPivotQuicksort proposal in http://cr.openjdk.java.net/~psandoz/tmp/gs/sort/webrev.2/ doesn't work for me. This little program public static void main(String[] args) { int[] a = new int[287]; for (int i = 0; i a.length; i++) {

Re: Review Request 8074432: Move jdeps to jdk.compiler module

Meant to include jigsaw-dev in the initial post. On May 25, 2015, at 12:16 AM, Alan Bateman alan.bate...@oracle.com wrote: On 24/05/2015 05:00, Mandy Chung wrote: This will move jdeps to the same module as other langtools javac and javap. Webrev at:

RE: DualPivotQuicksort webrev for JDK-8080945

Stefan, you're looking at an older version of the code. If you apply Paul's suggestions from http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033640.html the code works as expected. Thanks Moh -Original Message- From: core-libs-dev

RE: Patch to improve primitives Array.sort()

I have looked at the mailing list archive and so far I haven't identify any progress on the space for benchmark - so we could include the performance test as a part of the patch but it will required JMH access somehow. From: Paul Sandoz [mailto:paul.san...@oracle.com] Sent: 22 May 2015 22:24

JEP 119 / Implementation of javax.lang.model.util.Types

Hi all, This Github repository of mine https://github.com/fschopp/java-types provides an abstract skeletal implementation of the type-system related methods of interface javax.lang.model.util.Types, plus a concrete realization backed by the core Java Reflection API, akin to JEP 119 by Joe Darcy.