Re: Review request for JDK-8080907 - Develop test for Xerces Update: XML Schema Validation

2015-06-12 Thread Lance Andersen
I am fine with this also Frank Best Lance On Jun 12, 2015, at 12:58 PM, huizhe wang wrote: > Hi Frank, > > The change looks good to me. > > Thanks, > Joe > > On 6/12/2015 12:27 AM, Frank Yuan wrote: >> Hi Joe, Lance and all >> >> Would you like to have a review for bug: >> https://bugs.ope

Re: [9] RFR of 8087288: File.get{Free, Total, Usable}Space may return unexpected results with >2TB file systems

2015-06-12 Thread Alan Bateman
On 12/06/2015 01:30, Brian Burkhalter wrote: Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8087288 Patch: http://cr.openjdk.java.net/~bpb/8087288/webrev.00/ The root cause of this problem is essentially the same as that of https://bugs.openjdk.java.net/br

Re: RFR: 8087283 : Add support for the XML Signature here() function to the JDK XPath implementation

2015-06-12 Thread Alan Bateman
On 12/06/2015 18:29, Sean Mullan wrote: Please review this change to add support for the XML Signature here() function to the JDK XPath implementation. The here function is not defined in its own namespace. Therefore it needs to be implemented by extending the function library of XPath in the s

Re: RFR: 8087283 : Add support for the XML Signature here() function to the JDK XPath implementation

2015-06-12 Thread huizhe wang
Hi Sean, The change looks good to me. Thanks, Joe On 6/12/2015 10:29 AM, Sean Mullan wrote: Please review this change to add support for the XML Signature here() function to the JDK XPath implementation. The here function is not defined in its own namespace. Therefore it needs to be implement

RFR: 8087283 : Add support for the XML Signature here() function to the JDK XPath implementation

2015-06-12 Thread Sean Mullan
Please review this change to add support for the XML Signature here() function to the JDK XPath implementation. The here function is not defined in its own namespace. Therefore it needs to be implemented by extending the function library of XPath in the same namespace. Currently, the JDK XML S

Re: Review request for JDK-8080907 - Develop test for Xerces Update: XML Schema Validation

2015-06-12 Thread huizhe wang
Hi Frank, The change looks good to me. Thanks, Joe On 6/12/2015 12:27 AM, Frank Yuan wrote: Hi Joe, Lance and all Would you like to have a review for bug: https://bugs.openjdk.java.net/browse/JDK-8080907? I added some new tests and updated some existing tests to add more coverage for JAX

Re: RFR(XS): 8081412: Remove MHIllegalAccess.java from the problem list

2015-06-12 Thread joe darcy
Looks fine; thanks, -Joe On 6/11/2015 5:06 AM, Andreas Eriksson wrote: Hi, Id like to remove java/lang/invoke/8022701/MHIllegalAccess.java from the problem list. It was added while the test fix propagated to the correct repos. [1] Now the fix has propagated. [2] Change, generated by running

Review request for JDK-8080907 - Develop test for Xerces Update: XML Schema Validation

2015-06-12 Thread Frank Yuan
Hi Joe, Lance and all Would you like to have a review for bug: https://bugs.openjdk.java.net/browse/JDK-8080907? I added some new tests and updated some existing tests to add more coverage for JAXP library. The webrev is at http://cr.openjdk.java.net/~fyuan/8080907/webrev.00/, your com