On Wed, Jun 17, 2015 at 1:36 AM, Paul Sandoz paul.san...@oracle.com wrote:
A top-level Spliterator should not report both CONCURRENT and
IMMUTABLE, since they are mutually exclusive. Such a Spliterator is
inconsistent and no guarantees can be made about any computation using that
On Jun 16, 2015, at 8:36 PM, David Holmes david.hol...@oracle.com wrote:
On 17/06/2015 8:39 AM, John Rose wrote:
What I'm suggesting is that a BC generator might emit a zero length name for
a non-anon class, leading to confusion when C.isAnon is called.
Is a zero-length name for a
On Jun 17, 2015, at 6:27 AM, Jochen Theodorou blackd...@gmx.org wrote:
I did not expect that the outer class is not set for Local and Anonymous
classes. I would have thought that the enclosing method is the only
difference.
A bit of history (which can be found in the JVMS itself): The
On 18/06/2015 7:56 AM, John Rose wrote:
On Jun 17, 2015, at 6:27 AM, Jochen Theodorou blackd...@gmx.org wrote:
I did not expect that the outer class is not set for Local and Anonymous
classes. I would have thought that the enclosing method is the only difference.
A bit of history (which can
On 15/06/2015 22:58, Roger Riggs wrote:
Please review code for Windows 10 that sets the System properties for
os.name and os.version
from the version of kernel32.dll. The update uses the same technique
used by Hotspot
in src/os/windows/vm/os_windows.cpp.
The Windows link of CoreLibraries.gmk
On Tue, Jun 16, 2015 at 1:43 AM, Paul Sandoz paul.san...@oracle.com wrote:
It's a subtle area. Certain Spliterator characteristics refer to the
(element) source namely, NONULL, IMMUTABLE and CONCURRENT.
Yes, it's subtle. I went back and studied
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8067005
Webrev is http://cr.openjdk.java.net/~kshefov/8067005/webrev.00/
Thanks
-Konstantin
On Jun 17, 2015, at 8:10 AM, Martin Buchholz marti...@google.com wrote:
On Tue, Jun 16, 2015 at 1:43 AM, Paul Sandoz paul.san...@oracle.com wrote:
It's a subtle area. Certain Spliterator characteristics refer to the
(element) source namely, NONULL, IMMUTABLE and CONCURRENT.
Yes, it's
Hello,
I have updated the fix once more
http://cr.openjdk.java.net/~kshefov/8062904/webrev.03/
Please, review
Thanks
-Konstantin
On 06/16/2015 02:01 PM, Konstantin Shefov wrote:
Hello,
Please, review the new version of the fix to this issue
Hello Roger,
Build change looks fine to me.
/Erik
On 2015-06-15 23:58, Roger Riggs wrote:
Please review code for Windows 10 that sets the System properties for
os.name and os.version
from the version of kernel32.dll. The update uses the same technique
used by Hotspot
in
Konstantin,
Overall looks good w.r.t. my previous comments about Utils class.
You have a duplicate of processVME in LambdaFormTestCase.
Best regards,
Vladimir Ivanov
On 6/17/15 1:21 PM, Konstantin Shefov wrote:
Hello,
I have updated the fix once more
Am 16.06.2015 10:40, schrieb Vladimir Ivanov:
[...]
Example:
class TopLevel {
static class Nested {}
classInner {}
void f() {
class Local {}
}
Object o = new TopLevel() {}; // anonymous
}
And here's how they look like on bytecode level.
I'll use both javap and ASM
Hi Alan,
Would there be any concerns about backporting to JDK 8?
On 6/17/2015 7:32 AM, Alan Bateman wrote:
On 15/06/2015 22:58, Roger Riggs wrote:
Please review code for Windows 10 that sets the System properties for
os.name and os.version
from the version of kernel32.dll. The update uses
Konstantin,
I'd move isThrowableCausedByVME processVME from Utils to a more
specific place (new shared class for JSR292 tests?). They aren't general
enough to be useful for other tests.
Also, processVME name is confusing. I'd introduce something like a
runMHTest wrapper and process
Vladimir
Thanks for reviewing
On 06/17/2015 04:09 PM, Vladimir Ivanov wrote:
Konstantin,
Overall looks good w.r.t. my previous comments about Utils class.
I will fix the common code
-Konstantin
You have a duplicate of processVME in LambdaFormTestCase.
Best regards,
Vladimir Ivanov
On
I updated the webrev to remove the Windows 3.1 case and
will wait 24hrs to see if there are more comments.
Thanks for the review, Roger
On 6/17/2015 9:58 AM, Alan Bateman wrote:
On 17/06/2015 14:49, Roger Riggs wrote:
Hi Alan,
Would there be any concerns about backporting to JDK 8?
I don't
Looks good.
Best regards,
Vladimir Ivanov
On 6/17/15 7:23 PM, Konstantin Shefov wrote:
Vladimir,
I have updated the webrev:
http://cr.openjdk.java.net/~kshefov/8067005/webrev.01/
-Konstantin
On 06/17/2015 04:01 PM, Vladimir Ivanov wrote:
Konstantin,
I'd move isThrowableCausedByVME
Looks good.
Best regards,
Vladimir Ivanov
On 6/17/15 7:21 PM, Konstantin Shefov wrote:
Vladimir
I have updated the webrev:
http://cr.openjdk.java.net/~kshefov/8062904/webrev.04/
-Konstantin
On 06/17/2015 04:09 PM, Vladimir Ivanov wrote:
Konstantin,
Overall looks good w.r.t. my previous
Vladimir
I have updated the webrev:
http://cr.openjdk.java.net/~kshefov/8062904/webrev.04/
-Konstantin
On 06/17/2015 04:09 PM, Vladimir Ivanov wrote:
Konstantin,
Overall looks good w.r.t. my previous comments about Utils class.
You have a duplicate of processVME in LambdaFormTestCase.
Vladimir,
I have updated the webrev:
http://cr.openjdk.java.net/~kshefov/8067005/webrev.01/
-Konstantin
On 06/17/2015 04:01 PM, Vladimir Ivanov wrote:
Konstantin,
I'd move isThrowableCausedByVME processVME from Utils to a more
specific place (new shared class for JSR292 tests?). They
20 matches
Mail list logo
