Re: [verona.stage] RFR 8087203: Add support for PATCH field and remove unused fields of new version string

Sounds good Joe, I will push those soon. Thanks Alejandro On 6/19/2015 3:56 PM, huizhe wang wrote: Hi Alejandro, Alan's right about the JAXP version-check code. But since this is urgently needed, I agree you can push the change as is. I'll create a separate bug to re-examine version

Re: [verona.stage] RFR 8087203: Add support for PATCH field and remove unused fields of new version string

Hi Alejandro, Alan's right about the JAXP version-check code. But since this is urgently needed, I agree you can push the change as is. I'll create a separate bug to re-examine version related code in jaxp. As Alan pointed out, it would be some clean-up. Thanks, Joe On 6/19/2015 9:53 AM,

Re: RFR 9/8: 8066504: GetVersionEx in java.base/windows/native/libjava/java_props_md.c might not get correct Windows version

Hi Ivan, Thanks for the review and recommendation. The webrev is updated in place to use WCHAR. http://cr.openjdk.java.net/~rriggs/webrev-win-ver-8066504/ On 6/18/2015 2:07 PM, Ivan Gerasimov wrote: Hi Roger! On 17.06.2015 17:27, Roger Riggs wrote: I updated the webrev to remove the

RFR 8129120 Terminal operation properties should not be back-propagated to upstream operations

Hi, http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8129120-flag-back-propagation/webrev/ I am a little red in the face (of the embarrassed kind) about this fix. We found an issue reported on stack overflow whereby a stream can report incorrect results. I may be wrong but this might be the first

Re: RFR of 8074819: Resolve disabled warnings for libzip

On 18/06/2015 21:40, Xueming Shen wrote: Hi, Please help review the change to resolve the disabled parentheses warnings for libzip issue: https://bugs.openjdk.java.net/browse/JDK-8074819 webrev: http://cr.openjdk.java.net/~sherman/8074819 Looks okay to me, although I have to admit that

Re: [verona.stage] RFR 8087203: Add support for PATCH field and remove unused fields of new version string

Hi Alan, just to you. didn't hear back from you, so I'll assume you are fine with the corrections. We want to get this into further testing so I'm going to push the changes cheers Alejandro On 6/18/2015 4:56 PM, Alejandro E Murillo wrote: Thanks Alan, see below On 6/18/2015 7:41 AM, Alan

Re: RFR 9/8: 8066504: GetVersionEx in java.base/windows/native/libjava/java_props_md.c might not get correct Windows version

Hi Ivan, Both fixed, Thanks, Roger On 6/19/2015 1:33 PM, Ivan Gerasimov wrote: Thanks! I like it better now :) A couple of minor nits: - please use VerQueryValueW() for consistency, - missing space after if in '507 if(is_workstation'. Otherwise looks fine to me. Sincerely yours, Ivan

Re: RFR 9/8: 8066504: GetVersionEx in java.base/windows/native/libjava/java_props_md.c might not get correct Windows version

Thanks! I like it better now :) A couple of minor nits: - please use VerQueryValueW() for consistency, - missing space after if in '507 if(is_workstation'. Otherwise looks fine to me. Sincerely yours, Ivan On 19.06.2015 16:38, Roger Riggs wrote: Hi Ivan, Thanks for the review and

Re: RFR of 8074819: Resolve disabled warnings for libzip

There's a whole cottage industry of web sites explaining the do {...} while (0) thing, e.g. http://www.bruceblinn.com/linuxinfo/DoWhile.html On Fri, Jun 19, 2015 at 11:47 AM, Ivan Gerasimov ivan.gerasi...@oracle.com wrote: On 19.06.2015 15:11, Alan Bateman wrote: On 18/06/2015 21:40,

Re: RFR of 8074819: Resolve disabled warnings for libzip

On 19.06.2015 15:11, Alan Bateman wrote: On 18/06/2015 21:40, Xueming Shen wrote: Hi, Please help review the change to resolve the disabled parentheses warnings for libzip issue: https://bugs.openjdk.java.net/browse/JDK-8074819 webrev: http://cr.openjdk.java.net/~sherman/8074819 Looks