Re: RFR: 8132459: ExceptionInInitializerError from 'java -version' on Linux under zh_CN.GB18030 locale

2015-07-29 Thread Xueming Shen
On 7/29/15 2:23 AM, Volker Simonis wrote: On Tue, Jul 28, 2015 at 11:11 PM, Xueming Shen xueming.s...@oracle.com wrote: Volker, If fine with you I will re-open the gb18080 specific bug and fix it by adding the gb18030 into stdcs-solaris/linux and aix (does aix have a gb18030 locale?). In

Re: RFR(s): 8132206: move ScanTest.java into OpenJDK

2015-07-29 Thread Xueming Shen
On 7/28/15 6:45 PM, Stuart Marks wrote: Hi all, Please review this small change to add a test for java.util.Scanner into OpenJDK. This test was inadvertently omitted from OpenJDK when the regression tests were migrated into the open. Bug: https://bugs.openjdk.java.net/browse/JDK-8132206

Re: RfR - 8130058: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/Process.java

2015-07-29 Thread Lance Andersen
Looks OK based on the email thread about this proposed change On Jul 29, 2015, at 11:02 AM, Daniel Fuchs daniel.fu...@oracle.com wrote: http://cr.openjdk.java.net/~dfuchs/webrev_8130058/webrev.00/ Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering

Re: RFR: JDK-8062849 -- Optimize EnumMap.equals

2015-07-29 Thread Paul Sandoz
On 28 Jul 2015, at 18:14, Steve Drach steve.dr...@oracle.com wrote: Please review the following simple fix for the issue reported in https://bugs.openjdk.java.net/browse/JDK-8062849 https://bugs.openjdk.java.net/browse/JDK-8062849. +1 Paul. - # HG changeset patch #

Re: RFR: JDK-8066013 (prefs) Unused variable in src/java.prefs/share/classes/java/util/prefs/MacOSXPreferences.java

2015-07-29 Thread Paul Sandoz
On 23 Jul 2015, at 11:26, Chris Hegarty chris.hega...@oracle.com wrote: Your change [1] looks fine to me Steve. +1 Paul.

Re: RFR: 8132459: ExceptionInInitializerError from 'java -version' on Linux under zh_CN.GB18030 locale

2015-07-29 Thread Volker Simonis
On Wed, Jul 29, 2015 at 5:53 PM, Xueming Shen xueming.s...@oracle.com wrote: On 7/29/15 2:23 AM, Volker Simonis wrote: On Tue, Jul 28, 2015 at 11:11 PM, Xueming Shen xueming.s...@oracle.com wrote: Volker, If fine with you I will re-open the gb18080 specific bug and fix it by adding the

Re: Re: RFR (M/L): 8131168: Refactor ProcessHandleImpl_*.c and add implememtation for AIX

2015-07-29 Thread Volker Simonis
Hi Roger, thanks a lot for the review. Please find my comments inline and the new webrev under: http://cr.openjdk.java.net/~simonis/webrevs/2015/8131168.v3/ On Mon, Jul 27, 2015 at 10:26 PM, Roger Riggs roger.ri...@oracle.com wrote: Hi Volker, Thanks for the refactoring and the AIX

Re: ProcessBuilder support for pipelines

2015-07-29 Thread Martin Buchholz
Curmudgeon Martin supports this change! I'm a little surprised we can implement it without native code. --- The below should probably be in its own paragraph. + * The {@link #startPipe startPipe} method can be invoked to create + * a pipeline of new processes that send the output of each

Re: RFR: 8132459: ExceptionInInitializerError from 'java -version' on Linux under zh_CN.GB18030 locale

2015-07-29 Thread Xueming Shen
Here is the webrev to add those missing charsets. The assumption back then was that the linux platform has successfully migrated to the utf-8 default world. http://cr.openjdk.java.net/~sherman/8132459/ thanks, Sherman On 7/28/15 8:22 PM, Jonathan Lu wrote: Hi Alan, Sherman, Thanks for

Re: RFR: 8132459: ExceptionInInitializerError from 'java -version' on Linux under zh_CN.GB18030 locale

2015-07-29 Thread David Holmes
Hi Sherman, On 30/07/2015 1:54 PM, Xueming Shen wrote: Here is the webrev to add those missing charsets. The assumption back then was that the linux platform has successfully migrated to the utf-8 default world. This process seems somewhat ad-hoc, what are we using to determine which

Re: RFR: 8132306: java/lang/ref/ReferenceEnqueue.java fails with RuntimeException: Error: poll() returned null; expected ref object

2015-07-29 Thread David Holmes
Hi Kim, tl;dr: Ship it! :) On 30/07/2015 9:46 AM, Kim Barrett wrote: On Jul 29, 2015, at 4:32 AM, David Holmes david.hol...@oracle.com wrote: On 29/07/2015 5:57 PM, Kim Barrett wrote: ... The race is being fixed by reordering a pair of volatile assignments. While this seems logical for

Re: RFR: 8132459: ExceptionInInitializerError from 'java -version' on Linux under zh_CN.GB18030 locale

2015-07-29 Thread Volker Simonis
On Tue, Jul 28, 2015 at 11:11 PM, Xueming Shen xueming.s...@oracle.com wrote: Volker, If fine with you I will re-open the gb18080 specific bug and fix it by adding the gb18030 into stdcs-solaris/linux and aix (does aix have a gb18030 locale?). In general I'm fine with your proposal. But I

Re: RFR: 8132306: java/lang/ref/ReferenceEnqueue.java fails with RuntimeException: Error: poll() returned null; expected ref object

2015-07-29 Thread David Holmes
Hi Kim, On 29/07/2015 5:57 PM, Kim Barrett wrote: Please review this fix of a race condition in j.l.r.Reference/ReferenceQueue. See comments in the bug report for a description of the race. The race is being fixed by reordering a pair of volatile assignments. While this seems logical for

Re: ProcessBuilder support for pipelines

2015-07-29 Thread Stephen Colebourne
Seems like a useful addition to me. Stephen On 28 July 2015 at 09:28, Chris Hegarty chris.hega...@oracle.com wrote: I find this kinda cute. Seems like a reasonable addition to me. -Chris. On 27 Jul 2015, at 15:48, Roger Riggs roger.ri...@oracle.com wrote: On most operating systems,

RFR: 8132306: java/lang/ref/ReferenceEnqueue.java fails with RuntimeException: Error: poll() returned null; expected ref object

2015-07-29 Thread Kim Barrett
Please review this fix of a race condition in j.l.r.Reference/ReferenceQueue. See comments in the bug report for a description of the race. The race is being fixed by reordering a pair of volatile assignments. CR: https://bugs.openjdk.java.net/browse/JDK-8132306 Webrev:

Re: RFR(s): 8132206: move ScanTest.java into OpenJDK

2015-07-29 Thread Paul Sandoz
On 29 Jul 2015, at 03:45, Stuart Marks stuart.ma...@oracle.com wrote: Hi all, Please review this small change to add a test for java.util.Scanner into OpenJDK. This test was inadvertently omitted from OpenJDK when the regression tests were migrated into the open. Bug:

Re: RFR: 8132306: java/lang/ref/ReferenceEnqueue.java fails with RuntimeException: Error: poll() returned null; expected ref object

2015-07-29 Thread Thomas Schatzl
Hi Kim, On Wed, 2015-07-29 at 03:57 -0400, Kim Barrett wrote: Please review this fix of a race condition in j.l.r.Reference/ReferenceQueue. See comments in the bug report for a description of the race. The race is being fixed by reordering a pair of volatile assignments. CR:

Re: RFR: 8132306: java/lang/ref/ReferenceEnqueue.java fails with RuntimeException: Error: poll() returned null; expected ref object

2015-07-29 Thread Daniel Fuchs
Hi Kim, I agree with your proposed fix. I see that you have added a comment for future maintainers. Thanks for that - as the implication of the ordering between the two volatile writes is not immediately perceptible to the casual reader. You have good eyes - I hadn't spotted the race

Re: RFR(XS): 8132475 : The commands in the modular images are executable by the owner only (once again)

2015-07-29 Thread Volker Simonis
On Tue, Jul 28, 2015 at 10:04 PM, Alan Bateman alan.bate...@oracle.com wrote: On 28/07/2015 19:32, Volker Simonis wrote: Hi, could you please review this tiny change: http://cr.openjdk.java.net/~simonis/webrevs/2015/8132475/ https://bugs.openjdk.java.net/browse/JDK-8132475 After 8080511:

Review request: JDK-8080108: [TEST_BUG] ERROR: No IPv6 address returned from platform

2015-07-29 Thread Alexander Fomin
Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8080108 See webrev here http://cr.openjdk.java.net/~kshefov/8080108/webrev.00/ The original test (com/sun/jndi/dns/IPv6NameserverPlatformParsingTest.java @bug 6991580) fails automatically if /etc/resolv.conf file

Re: RFR: 8132459: ExceptionInInitializerError from 'java -version' on Linux under zh_CN.GB18030 locale

2015-07-29 Thread Xueming Shen
On 7/29/15 9:53 PM, David Holmes wrote: Hi Sherman, On 30/07/2015 1:54 PM, Xueming Shen wrote: Here is the webrev to add those missing charsets. The assumption back then was that the linux platform has successfully migrated to the utf-8 default world. This process seems somewhat ad-hoc,

Re: RFR: 8132306: java/lang/ref/ReferenceEnqueue.java fails with RuntimeException: Error: poll() returned null; expected ref object

2015-07-29 Thread Kim Barrett
On Jul 29, 2015, at 4:32 AM, David Holmes david.hol...@oracle.com wrote: On 29/07/2015 5:57 PM, Kim Barrett wrote: ... The race is being fixed by reordering a pair of volatile assignments. While this seems logical for the failure at hand it isn't immediately obvious to me that setting

RfR - 8130058: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/Process.java

2015-07-29 Thread Daniel Fuchs
Hi, Please find below a patch that removes a bunch of unused files in jdk9/dev/jaxp: https://bugs.openjdk.java.net/browse/JDK-8130058 8130058: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/Process.java http://cr.openjdk.java.net/~dfuchs/webrev_8130058/webrev.00/