Re: RFR 8124977 cmdline encoding challenges on Windows

2015-08-07 Thread Martin Buchholz
(only half paying attention) On Wed, Aug 5, 2015 at 7:45 PM, Kirk Shoop kirk.sh...@microsoft.com wrote: This webrev uses GetCommandLineW That sounds right - this should be the source of truth in win32land. on windows to retrieve the UCS16 UCS16 confuses me. Do you mean UTF-16 or UCS-2?

RFR JDK-8039390: Unexpected behaviour of String.format with null arguments

2015-08-07 Thread Xueming Shen
Hi, Please help review fix for issue: https://bugs.openjdk.java.net/browse/JDK-8039390 webrev: http://cr.openjdk.java.net/~sherman/8039390 The j.u.Formatter implementation outputs null/Null for all conversions if the argument is null (except 'b'/'B', in which the result is false/FALSE).

Re: RFR (M/L): 8131168: Refactor ProcessHandleImpl_*.c and add implememtation for AIX

2015-08-07 Thread Roger Riggs
Hi Volker, 1) ProcessHandle.java:243 For the definition of the new commandLine method I would: - Use @link instead of @code for references to commands() and arguments() for easy navigation - @implNote[1] should I think be changed to @apiNote: the text describes not the JDK

Re: RFR 8124977 cmdline encoding challenges on Windows

2015-08-07 Thread Kumar Srinivasan
Hi Kirk, We don't allow any shell tests. There are existing shell based tests, I have not had a chance to port all of them. Your test must be rewritten to use the TestHelper framework, please see the other tests in jdk/test/tools/launcher for patterns. Kumar -Original Message- From: