Re: RFR(XS): 8133105: Fix getFinalAttributes() on Windows to handle more special cases

2015-08-10 Thread Roger Riggs
Hi Volker, Looks fine. Is there any way to test this? It seems like it needs a special file system state that would not be readily available. Thanks, Roger On 8/10/15 9:57 AM, Volker Simonis wrote: Hi, can somebody please review this trivial fix? Thanks, Volker On Thu, Aug 6, 2015 at

Re: RFR (M/L): 8131168: Refactor ProcessHandleImpl_*.c and add implememtation for AIX

2015-08-10 Thread Volker Simonis
On Fri, Aug 7, 2015 at 8:54 PM, Roger Riggs roger.ri...@oracle.com wrote: Hi Volker, 1) ProcessHandle.java:243 For the definition of the new commandLine method I would: - Use @link instead of @code for references to commands() and arguments() for easy navigation - @implNote[1] should

Re: RFR(XS): 8133105: Fix getFinalAttributes() on Windows to handle more special cases

2015-08-10 Thread Volker Simonis
Hi, can somebody please review this trivial fix? Thanks, Volker On Thu, Aug 6, 2015 at 5:27 PM, Volker Simonis volker.simo...@gmail.com wrote: Hi, can somebody please review the following small fix contributed by matthias.baes...@sap.com:

RFR: 8129957 - Deadlock in JNDI LDAP implementation when closing the LDAP context

2015-08-10 Thread Rob McKenna
Hi folks, We have a hang between LdapClient / Ctx due to the fact that Connection.cleanup() calls LdapClient.processConnectionClosure which locks the unsolicited vector and in turn calls LdapCtx.fireUnsolicited which locks the eventSupport object. Unfortunately when an LdapCtx.close() occurs

Re: RFR - 8027634: Support @argfiles for java command-line tool

2015-08-10 Thread Erik Joelsson
Hello Henry, Build changes look good to me. /Erik On 2015-07-10 05:48, Henry Jen wrote: Hi, Please review proposed patch for JDK-8027634[1]. This patch is to enable java support command line argument file like javac does. The implementation use the same syntax rule, which is implemented in

Re: RFR v4 - 8027634: Support @argfiles for java command-line tool

2015-08-10 Thread Erik Joelsson
New build changes look fine to me. /Erik On 2015-08-08 09:03, Henry Jen wrote: Hi, Another update for argument file support, this version we added a couple measures to ensure compatibility, 1) Compile time directive ENABLE_ARG_FILES is needed to enable the feature, only java is enabled

RFR [9] 8133188: docs: replace tt tags (obsolete in html5) for java.util

2015-08-10 Thread Alexander Stepanov
Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8133188/webrev.01 for https://bugs.openjdk.java.net/browse/JDK-8133188 Just a next portion of tt tags removed. specdiff report:

Re: RFR [9] 8133188: docs: replace tt tags (obsolete in html5) for java.util

2015-08-10 Thread Martin Buchholz
Hi Alexander, I've been hoping that someone does cleanups of the jdk as you are doing now. Some of these source files are part of jsr166 and are maintained separately, in jsr166 CVS. http://g.oswego.edu/dl/concurrency-interest/ And that has already been tt/code-cleaned (although it has been done