Looks good.
Best regards,
Vladimir Ivanov
On 8/14/15 3:53 AM, Konstantin Shefov wrote:
Hello,
Please review a test bug fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8133543
Webrev: http://cr.openjdk.java.net/~kshefov/8133543/webrev.00/
-Konstantin
Hi,
Another minor revision address comments, no real behavior changes except use
JLI_StrCmp instead of JLI_StrCCmp in checkArg().
http://cr.openjdk.java.net/~henryjen/jdk9/8027634/v5/webrev/
Cheers,
Henry
Looks good.
Best regards,
Vladimir Ivanov
On 8/11/15 3:54 AM, Konstantin Shefov wrote:
Kindly reminder.
06.08.2015 17:49, Konstantin Shefov пишет:
Please, look at the modified test
http://cr.openjdk.java.net/~kshefov/8060717/webrev.01/
-Konstantin
On 08/06/2015 02:06 PM, Konstantin Shefov
Hi Konstantin,
excellent, thank you. This is a lower-case review, but thumbs up.
Best,
Michael
Am 14.08.2015 um 03:53 schrieb Konstantin Shefov
konstantin.she...@oracle.com:
Hello,
Please review a test bug fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8133543
Webrev:
On Aug 14, 2015, at 1:10 PM, Henry Jen henry@oracle.com wrote:
Hi,
Another minor revision address comments, no real behavior changes except use
JLI_StrCmp instead of JLI_StrCCmp in checkArg().
http://cr.openjdk.java.net/~henryjen/jdk9/8027634/v5/webrev/
main.c
Hello,
Please review a test bug fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8133543
Webrev: http://cr.openjdk.java.net/~kshefov/8133543/webrev.00/
-Konstantin
Thanks Volker. Have a good vacation.
On 8/14/15 2:48 AM, Volker Simonis wrote:
On Fri, Aug 14, 2015 at 3:24 AM, Roger Riggs roger.ri...@oracle.com wrote:
Hi Volker,
The internal reviews are complete and accepted.
The code looks fine. Please push it. Ill be going on vacation so if it
breaks
Vladimir,
Please review the modified test.
Thanks
-Konstantin
On 08/06/2015 05:49 PM, Konstantin Shefov wrote:
Please, look at the modified test
http://cr.openjdk.java.net/~kshefov/8060717/webrev.01/
-Konstantin
On 08/06/2015 02:06 PM, Konstantin Shefov wrote:
Hi Vladimir
Thanks for
On Fri, Aug 14, 2015 at 3:24 AM, Roger Riggs roger.ri...@oracle.com wrote:
Hi Volker,
The internal reviews are complete and accepted.
The code looks fine. Please push it. Ill be going on vacation so if it
breaks something,
someone else will need to pick up the pieces or back it out.
Thanks!
Regards,
Alexander
On 8/13/2015 8:42 PM, Lance Andersen wrote:
looks OK. Nothing obvious stands out.
Best
Lance
On Aug 13, 2015, at 10:42 AM, Alexander Stepanov
alexander.v.stepa...@oracle.com
mailto:alexander.v.stepa...@oracle.com wrote:
Hello,
Could you please review the
10 matches
Mail list logo