Re: RFR (JAXP): 8144966: Catalog API: Null handling and reference to Reader

2016-01-04 Thread Mandy Chung
> On Dec 23, 2015, at 2:55 PM, huizhe wang wrote: > > Hi, > > This is an improvement to the new Catalog API on null handling. At the > package level, a null argument shall result in NPE. However, an exception was > made to the methods in CatalogManager so that they can used conveniently. > W

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2016-01-04 Thread Kim Barrett
On Dec 18, 2015, at 7:41 PM, Kim Barrett wrote: > > On Dec 16, 2015, at 8:50 AM, Magnus Ihse Bursie > wrote: >> Bug: https://bugs.openjdk.java.net/browse/JDK-8145549 >> WebRev: >> http://cr.openjdk.java.net/~ihse/JDK-8145549-vs2015-community-edition/webrev.01 >> >> /Magnus > > I only looked

Re: RFR JDK-8146431:j.u.z.ZipFile.getEntry("") throws AIOOBE

2016-01-04 Thread Xueming Shen
On 01/04/2016 02:54 PM, Martin Buchholz wrote: ZipFile/Assortment already tests empty entry names. Why didn't that test catch any error? IOW, ;how can ZipFile/Assortment be improved? The bug only occurs if there is no such empty name entry inside the target zip file. The ZipFile/Assortment

Re: RFR JDK-8146431:j.u.z.ZipFile.getEntry("") throws AIOOBE

2016-01-04 Thread Martin Buchholz
ZipFile/Assortment already tests empty entry names. Why didn't that test catch any error? IOW, ;how can ZipFile/Assortment be improved? On Mon, Jan 4, 2016 at 1:02 PM, Xueming Shen wrote: > Hi, please help review the change for JDK-8146431 > > Issue: https://bugs.openjdk.java.net/browse/JDK-814

Re: RFR JDK-8146431:j.u.z.ZipFile.getEntry("") throws AIOOBE

2016-01-04 Thread Xueming Shen
Claes, I think the spec does not say the jar/zip file can't have an empty name entry. So it'd be better to check first. Sherman On 01/04/2016 01:05 PM, Claes Redestad wrote: Thanks for fixing this! Can getEntryPos(new byte[0], true/false); ever return anything but -1? Otherwise it seems the

Re: RFR JDK-8146431:j.u.z.ZipFile.getEntry("") throws AIOOBE

2016-01-04 Thread Claes Redestad
Thanks for fixing this! Can getEntryPos(new byte[0], true/false); ever return anything but -1? Otherwise it seems the check could be moved to the start of the method. /Claes On 2016-01-04 22:02, Xueming Shen wrote: Hi, please help review the change for JDK-8146431 Issue: https://bugs.openjd

Re: RFR JDK-8146431:j.u.z.ZipFile.getEntry("") throws AIOOBE

2016-01-04 Thread Lance Andersen
Looks OK Sherman… Best Lance On Jan 4, 2016, at 4:02 PM, Xueming Shen wrote: > Hi, please help review the change for JDK-8146431 > > Issue: https://bugs.openjdk.java.net/browse/JDK-8146431 > webrev: http://cr.openjdk.java.net/~sherman/8146431 > > Cause: > > The parameter "ulen" in native vers

RFR JDK-8146431:j.u.z.ZipFile.getEntry("") throws AIOOBE

2016-01-04 Thread Xueming Shen
Hi, please help review the change for JDK-8146431 Issue: https://bugs.openjdk.java.net/browse/JDK-8146431 webrev: http://cr.openjdk.java.net/~sherman/8146431 Cause: The parameter "ulen" in native version zip_util.c.ZIP_GetEntry() serves two purposes, (1) the length of the name (2) whether or no

Re: [PING] Potential infinite waiting at JMXConnection#createConnection

2016-01-04 Thread Jaroslav Bachorik
Hi Yuji, On 4.1.2016 15:14, KUBOTA Yuji wrote: Hi all, Could you please review this patch? Sorry for the long delay. Shanliang has not been present for some time and probably this slipped the attention of the others. However, core-libs mailing list might be more appropriate place to revie

Re: RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

2016-01-04 Thread Chris Hegarty
On 04/01/16 14:16, Alan Bateman wrote: On 04/01/2016 14:02, Chris Hegarty wrote: sun.misc.VM provides a low-level interface for a small number of specific operations with the VM. In preparation for JEP 260, this class should be moved out of sun.misc and located in a non-exported package [. http

Re: [PING] PoC for JDK-4347142: Need method to set Password protection to Zip entries

2016-01-04 Thread KUBOTA Yuji
Hi Sherman and all, Happy new year to everyone! Please let know your feedback about this proposal. :-) Thanks, Yuji 2015-12-21 22:38 GMT+09:00 KUBOTA Yuji : > Hi Sherman, > > 2015-12-20 16:35 GMT+09:00 Xueming Shen : >> It is no longer necessary to touch the native code (zip_util.c/h) after the

Re: RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

2016-01-04 Thread Sean Mullan
On 01/04/2016 09:14 AM, Chris Hegarty wrote: Note: as in other areas some tests that require access to internal APIs have been updated to use types from a more stable package, sun.security.x509. Not sure what you mean - which tests do you mean and why is sun.security.x509 related to this issue?

Re: RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

2016-01-04 Thread Alan Bateman
On 04/01/2016 14:02, Chris Hegarty wrote: sun.misc.VM provides a low-level interface for a small number of specific operations with the VM. In preparation for JEP 260, this class should be moved out of sun.misc and located in a non-exported package [. http://cr.openjdk.java.net/~chegar/8145544

Re: RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

2016-01-04 Thread Chris Hegarty
On 04/01/16 14:12, Sean Mullan wrote: On 01/04/2016 09:02 AM, Chris Hegarty wrote: sun.misc.VM provides a low-level interface for a small number of specific operations with the VM. In preparation for JEP 260, this class should be moved out of sun.misc and located in a non-exported package [. ht

Re: RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

2016-01-04 Thread Wang Weijun
I am OK with the change for krb5 in both src and test. Thanks Max > On Jan 4, 2016, at 10:02 PM, Chris Hegarty wrote: > > sun.misc.VM provides a low-level interface for a small number > of specific operations with the VM. In preparation for JEP 260, > this class should be moved out of sun.misc

Re: RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

2016-01-04 Thread Sean Mullan
On 01/04/2016 09:02 AM, Chris Hegarty wrote: sun.misc.VM provides a low-level interface for a small number of specific operations with the VM. In preparation for JEP 260, this class should be moved out of sun.misc and located in a non-exported package [. http://cr.openjdk.java.net/~chegar/814554

RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

2016-01-04 Thread Chris Hegarty
sun.misc.VM provides a low-level interface for a small number of specific operations with the VM. In preparation for JEP 260, this class should be moved out of sun.misc and located in a non-exported package [. http://cr.openjdk.java.net/~chegar/8145544/00/ Note: as in other areas some tests that