Re: RFR: 8072727 - add variation of Stream.iterate() that's finite

2016-02-14 Thread Peter Levart
On 02/14/2016 07:15 PM, Stefan Zobel wrote: Hi Tagir, this looks good. I wonder, however, if the signature should accept a wider range of types, i.e., something like static Stream iterate(S seed, Predicate predicate, UnaryOperator f) I know that the corresponding static Stream iterate(T

Re: RFR 9: 8149750 Decouple sun.misc.Signal from the base module

2016-02-14 Thread David Holmes
Hi Roger, A few mostly minor comments ... On 13/02/2016 3:47 AM, Roger Riggs wrote: Please review moving the functionality of sun.misc.Signal to jdk.internal.misc and creating a wrapper sun.misc.Signal for existing external uses. +++ This time including the hotspot changes to update the target

Re: RFR: 8072727 - add variation of Stream.iterate() that's finite

2016-02-14 Thread Stuart Marks
Hi Tagir, Thanks for picking this up. I'll be at a conference this week and I won't have much time to discuss this in detail until afterward. But here are some quick thoughts about the proposal. I'd suggest focusing on the API first before worrying about how to track the stream state with bo

Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

2016-02-14 Thread Steve Drach
Sherman, I like your suggestions and will open an issue to work on the performance after integration. I’ll fix the minor “bug” you pointed out at the same time. Steve > On Feb 12, 2016, at 5:19 PM, Xueming Shen wrote: > > > Steve, > > I would assume the difference of the webrev.04 "old"

Re: RFR: JDK-8149787 test/java/util/regex/GraphemeTest.java source file has non-ascii character u+00f7

2016-02-14 Thread Ivan Gerasimov
Hi! This looks good! Sincerely yours, Ivan On 14.02.2016 23:24, Xueming Shen wrote: Hi, Please help review the change for bug JDK-8149787, which "accidentally" embeds couple non-ascii character u+00f7 in several comment lines. This will trigger javac failure if using encoding=ascii. The fix

RFR: JDK-8149787 test/java/util/regex/GraphemeTest.java source file has non-ascii character u+00f7

2016-02-14 Thread Xueming Shen
Hi, Please help review the change for bug JDK-8149787, which "accidentally" embeds couple non-ascii character u+00f7 in several comment lines. This will trigger javac failure if using encoding=ascii. The fix is to replace the DIV with a simple "+" character. issue: https://bugs.openjdk.jav

Re: RFR: 8072727 - add variation of Stream.iterate() that's finite

2016-02-14 Thread Stefan Zobel
Hi Tagir, this looks good. I wonder, however, if the signature should accept a wider range of types, i.e., something like static Stream iterate(S seed, Predicate predicate, UnaryOperator f) I know that the corresponding static Stream iterate(T seed, UnaryOperator f) is less general than th

RFR: 8072727 - add variation of Stream.iterate() that's finite

2016-02-14 Thread Tagir F. Valeev
Hello! I wanted to work on foldLeft, but Brian asked me to take this issue instead. So here's webrev: http://cr.openjdk.java.net/~tvaleev/webrev/8072727/r1/ I don't like iterator-based Stream source implementations, so I made them AbstractSpliterator-based. I also implemented manually forEachRema