[8u-dev] Request for Approval for Backport: 8151574, jdk/test/sample fails with "effective library path is outside the test suite"

Hi there, please approve the backport of 8151574 from 9 to 8. Webrev: http://cr.openjdk.java.net/~xiaofeya/8151574/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8151574 Changeset in jdk9: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/dbb0fd7f2a2b Review: http://mail.openjdk.java.net

Ping - Re: RFR 8151676/9, Add jdk/internal/jline/console/StripAnsiTest.java into problem list for MacOSX

Hi, can we get either exclusion request or Jan's fix reviewed? This hanging test keeps on affecting other tests on some Mac OSX environments. Thanks, Felix On 2016/3/11 16:59, Felix Yang wrote: Hi Jan, we have seen test runs hanging 15+ hours on several environments, which blocks othe

Re: RFR: 8151858: update ASM 5.1 to accept V53.0 classfiles

+1 -Sundar On 3/15/2016 6:37 AM, Kumar Srinivasan wrote: > Hi Remi, Jon, Alan, > > This is in preparation to increment the class-file major version, > since we have internal dependencies, we cannot wait for upstream > changes, and have to line up our ducks, and yes there are several > of these, s

RFR: 8151858: update ASM 5.1 to accept V53.0 classfiles

Hi Remi, Jon, Alan, This is in preparation to increment the class-file major version, since we have internal dependencies, we cannot wait for upstream changes, and have to line up our ducks, and yes there are several of these, sprinkled all over the JDK. http://cr.openjdk.java.net/~ksrini/815185

Re: RFR: 8151847 rmic should support v53 classfiles

+1 -Sundar On 3/15/2016 4:57 AM, Mandy Chung wrote: >> On Mar 14, 2016, at 3:59 PM, Jonathan Gibbons >> wrote: >> >> Please review this one character change to have rmic support v53 class files: >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8151847 >> Webrev: http://cr.openjdk.java.net/~j

Re: RFR 9: 8085887 : java.time.format.FormatStyle.LONG or FULL causes unchecked exception

Great to see the better error messages. It may be better long term to add toString() to the TemporalQuery implementations (lambdas are convenient but optional). That said, what is in the webrev is what is needed here. The error message in the inner class probably ought to be more clever, although

Re: RFR: JDK-8133206 - Higher native memory usage caused by upgrade to zlib 1.2.8

Hi, On 11/10/2015 10:44 AM, Alex Kashchenko wrote: Please review the following fix to JDK-8133206: - bug: https://bugs.openjdk.java.net/browse/JDK-8133206 - webrev for jdk9: http://cr.openjdk.java.net/~akasko/jdk9/8133206/webrev.00/ This fix is a forward-port of the patch to jdk7u created

Re: RFR: 8151847 rmic should support v53 classfiles

> On Mar 14, 2016, at 3:59 PM, Jonathan Gibbons > wrote: > > Please review this one character change to have rmic support v53 class files: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8151847 > Webrev: http://cr.openjdk.java.net/~jjg/8151847/webrev/ +1 Mandy

Re: RFR: 8151847 rmic should support v53 classfiles

On 14/03/2016 22:59, Jonathan Gibbons wrote: Please review this one character change to have rmic support v53 class files: JBS: https://bugs.openjdk.java.net/browse/JDK-8151847 Webrev: http://cr.openjdk.java.net/~jjg/8151847/webrev/ Looks good. -Alan

RFR: 8151847 rmic should support v53 classfiles

Please review this one character change to have rmic support v53 class files: JBS: https://bugs.openjdk.java.net/browse/JDK-8151847 Webrev: http://cr.openjdk.java.net/~jjg/8151847/webrev/ -- Jon

Re: [PING] RFR: JDK-8150704 XALAN: ERROR: 'No more DTM IDs are available' when transforming with lots of temporary result trees

Hi Christoph, Aleksej has done great services to users of JDK 8 & 7 by backporting important changes from JDK 9. Please coordinate with Aleksej on this particular task. Best, Joe On 3/10/2016 12:27 PM, Langer, Christoph wrote: Hi Joe, OK, thanks. I'll prepare the JDK 8 backport then. Be

Re: JDK 9 RFR of JDK-8151785: Doc typo in src/../java/util/stream/PipelineHelper.java

Hi, Looks fine. Thanks, Roger On 3/13/2016 11:52 PM, Hamlin Li wrote: Please help to review the tiny doc typo fix for bug https://bugs.openjdk.java.net/browse/JDK-8151785 it should be "copyInto(wrapSink(sink), spliterator);", but it is "intoWrapped(wrapSink(sink), spliterator);", there is no

Re: RFR 9: 8085887 : java.time.format.FormatStyle.LONG or FULL causes unchecked exception

Hi Stephen, Thanks for the comments and suggestions. I have no issue cleaning it all up in one change. Updated webrev: http://cr.openjdk.java.net/~rriggs/webrev-format-8085887/ On 3/12/2016 4:47 AM, Stephen Colebourne wrote: I think the new text needs should be more specific: The {@code FU

Re: RFR 8150840: Add an internal system property to control the default level of System.Logger when java.logging is not present.

Hi Mandy, On 06/03/16 00:29, Mandy Chung wrote: On Mar 4, 2016, at 9:05 AM, Daniel Fuchs wrote: http://cr.openjdk.java.net/~dfuchs/webrev_8150840/webrev.01/ Looks okay in general. I’m not a fan of using GetPropertyAction. While it’s convenient as the class already exists, method refs a

Re: JDK 9 RFR of JDK-8151763; Use more informative format for problem list

Looks good to me. --Sean On 03/11/2016 10:28 PM, joe darcy wrote: Hello, As Jon Gibbons has noted off-list, the problem list entries can directly include the bug number associated with the test in question, enabling better reporting. This format should be used rather than the current conventio

Re: RFR 8131913: jdk/internal/jline/console/StripAnsiTest.java can't run in the background

Hello, Any feedback/comments on this? Thanks, Jan On 1.3.2016 11:54, Jan Lahoda wrote: Hi, I'd like to ask for a review of a patch for JDK-8131913. The fix is to use the "UnsupportedTerminal", which will not try to switch the OS terminal into the raw mode. The proposed patch is here: htt

Re: JDK 9 RFR of JDK-8151798: Mark java/util/TimeZone/Bug6772689.java as intermittently failing and demote to tier2

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected] Sent from my iPad > On Mar 14, 2016, at 5:51 AM, Amy Lu wrote: > > java/util/TimeZone/Bug6772689.java > > This test is known to fail

JDK 9 RFR of JDK-8151798: Mark java/util/TimeZone/Bug6772689.java as intermittently failing and demote to tier2

java/util/TimeZone/Bug6772689.java This test is known to fail intermittently (JDK-8149898, JDK-8150804). This patch is to mark the test accordingly with keyword 'intermittent’ and demote it to tier2 until issue resolved. bug: https://bugs.openjdk.java.net/browse/JDK-8151798 webrev: http://cr.