Re: [concurrency-interest] We need to add blocking methods to CompletionStage!

2016-09-21 Thread Martin Buchholz
On Wed, Sep 21, 2016 at 2:38 PM, Pavel Rappo wrote: > On Wed, Sep 21, 2016 at 9:43 PM, Martin Buchholz > wrote: > > What is happening instead is API providers not using CompletionStage as > > return values in public APIs because of the lack of

We need to add blocking methods to CompletionStage!

2016-09-21 Thread Martin Buchholz
(Sorry to re-open this discussion) The separation of a read-only CompletionStage from CompletableFuture is great. I'm a fan of the scala style Promise/Future split as described in http://docs.scala-lang.org/overviews/core/futures.html, but: we need to re-add (safe, read-only) blocking methods

Re: RFR: jsr166 jdk9 integration wave 11

2016-09-21 Thread Aleksey Shipilev
On 09/21/2016 09:33 PM, Martin Buchholz wrote: > http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/ Looks fine. Multi-story predicates sure look better now... -Aleksey

RFR: jsr166 jdk9 integration wave 11

2016-09-21 Thread Martin Buchholz
http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/ Notable here is an attempt to make a minimal completion stage more acceptable as a return value from APIs, by making completableFuture.minimalCompletionStage().toCompletableFuture() useful. Lots of boring changes to

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-21 Thread Chris Bensen
> On Sep 21, 2016, at 6:38 AM, Kumar Srinivasan > wrote: > > > On 9/16/2016 10:34 AM, Volker Simonis wrote: >> Hi Christoph, >> >> I think your change is fine as a quick-fix to fix the build. But >> you're completely right that this should be reworked in the

RFR: 8166398: CatalogSupport tests need to be fixed -> Re: RFR: 8166220: Catalog API: JAXP XML Processor Support - add StAX test coverage

2016-09-21 Thread Joe Wang
Hi Daniel, Here's the fix for the test issues, a couple of errors including missing handler in StAX test, and dtd was mistakingly typed as xsd . The root cause is a debugging assertEquals method that printed out debugging message without throwing Exception. I've searched the jaxp/test to make

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

2016-09-21 Thread Seán Coffey
Resurrecting this old review thread. After some internal discussion, I've dropped the minor edit that was made in StackTraceElementCompositeData. It could be noisy data for exception purposes. I've corrected the other issues raised by Alan and Jim has long pushed the changes mentioned below.

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-21 Thread Kumar Srinivasan
On 9/16/2016 10:34 AM, Volker Simonis wrote: Hi Christoph, I think your change is fine as a quick-fix to fix the build. But you're completely right that this should be reworked in the long term. I hate to see that we now have the third version of these routines in the OpenJDK. Unfortunately a