Re: RFR: 8037325: Class.getConstructor() performance regression

2017-01-16 Thread Mandy Chung
> On Jan 16, 2017, at 1:59 PM, Claes Redestad wrote: > > http://cr.openjdk.java.net/~redestad/8037325/webrev.02/ +1 Mandy

Re: RFR: 8037325: Class.getConstructor() performance regression

2017-01-16 Thread Claes Redestad
On 2017-01-16 22:39, Mandy Chung wrote: On Jan 12, 2017, at 6:48 AM, Claes Redestad wrote: Hi, please review this fix to various performance regressions observed as the security model has evolved over the years. Bug:

Re: RFR: 8037325: Class.getConstructor() performance regression

2017-01-16 Thread Mandy Chung
> On Jan 12, 2017, at 6:48 AM, Claes Redestad wrote: > > Hi, > > please review this fix to various performance regressions observed > as the security model has evolved over the years. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8037325 > Webrev:

RE: RFR: 8169631: [JAXP] XALAN: transformation of XML via namespace-unaware SAX input yields a different result than namespace-unaware DOM input

2017-01-16 Thread Langer, Christoph
Hi Joe, I finally got back to this one and pushed the change with some minor whitespace diffs. Thanks Christoph > -Original Message- > From: Joe Wang [mailto:huizhe.w...@oracle.com] > Sent: Montag, 28. November 2016 20:06 > To: Langer, Christoph > Cc:

Re: [9] RFR: 8171139: Simplify ResourceBundle.CacheKey and ClassLoader may not be needed

2017-01-16 Thread Daniel Fuchs
Hi Naoto, On 14/01/17 00:54, Naoto Sato wrote: diff -r a6d3c80ea436 src/java.base/share/classes/java/util/ResourceBundle.java --- a/src/java.base/share/classes/java/util/ResourceBundle.java +++ b/src/java.base/share/classes/java/util/ResourceBundle.java @@ -2192,7 +2192,7 @@ private static

Re: JDK 9 RFR of JDK-8146668: Replace custom check/range functionality with check index/range methods in java.util.Objects

2017-01-16 Thread Amy Lu
Thank you Paul and Martin for your review. On 1/13/17 12:52 AM, Paul Sandoz wrote: HI Amy, Overall this looks very good, well done. At this point we are down to two things: 1) should we preserve exception messages? 2) due diligence on the performance. On 1) my preference is that uniform