Re: RFR 8156073 : 2-slot LiveStackFrame locals (long and double) are incorrect (updated)

2017-01-30 Thread Coleen Phillimore
Added core-libs-dev. Coleen On 1/30/17 5:52 PM, Coleen Phillimore wrote: Hi Brent, I think this looks more conservative and better. in http://cr.openjdk.java.net/~bchristi/8156073/webrev.03/hotspot/src/share/vm/prims/stackwalk.cpp.html 287 int mode = 0; 288 if (_jvf->is_interpre

[9] RFR: 8173423: Wrong display name for supplemental Japanese era

2017-01-30 Thread Naoto Sato
Hello, Please review the fix to the following bug: https://bugs.openjdk.java.net/browse/JDK-8173423 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8173423/webrev.00/ There is a functionality in Japanese Imperial Calendar to supplement a new era from system property. The co

Re: RFR (JDK 10) 8172298: Reduce memory churn when linking VarHandles operations

2017-01-30 Thread Paul Sandoz
> On 30 Jan 2017, at 02:59, Aleksey Shipilev wrote: > > On 01/28/2017 12:10 AM, Paul Sandoz wrote: >> http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8172298-varhandle-link-reduce-memory/webrev/ > > Looks good, but I think the StringBuilder is inefficiently sized: it adds > (parameterCount() - 2)

Update: RFR 8172974 [JAXP] XALAN: Wrong result when transforming namespace unaware StAX Input

2017-01-30 Thread Langer, Christoph
Hi Joe, I've updated my webrev for 8172974 after pulling out the refactoring of javax/xml/jaxp/unittest/transform/TransformerTest.java to Bug 8173602: http://cr.openjdk.java.net/~clanger/webrevs/8172974.1/ After exchanging some off-list mails with Lance and Daniel, we came to the conclusion th

Re: RFR (XS): 8173634: libjli/cmdtoargs.c does not compile with VS2010

2017-01-30 Thread Chris Hegarty
++1 I ran into this myself earlier today. -Chris. On 30/01/17 14:59, Roger Riggs wrote: Hi Christoph, Looks fine, Thanks, Roger On 1/30/2017 9:52 AM, Langer, Christoph wrote: Hi, please review a tiny fix. The change for JDK-8170832 (Add a new launcher environment variable JAVA_OPTIONS) h

RE: RFR (XS): 8173634: libjli/cmdtoargs.c does not compile with VS2010

2017-01-30 Thread Langer, Christoph
Thanks, Roger, Chris. It's submitted: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/65a1441c9c80 Best Christoph > -Original Message- > From: Chris Hegarty [mailto:chris.hega...@oracle.com] > Sent: Montag, 30. Januar 2017 16:33 > To: Langer, Christoph ; core-libs- > d...@openjdk.java.net >

RFR (XS): 8173634: libjli/cmdtoargs.c does not compile with VS2010

2017-01-30 Thread Langer, Christoph
Hi, please review a tiny fix. The change for JDK-8170832 (Add a new launcher environment variable JAVA_OPTIONS) has introduced a build error when you build with Visual Studio 2010. Yes, we know it is not officially supported for JDK9 - however, it's easy and clean to keep compatibility. :) Bu

Re: RFR (XS): 8173634: libjli/cmdtoargs.c does not compile with VS2010

2017-01-30 Thread Roger Riggs
Hi Christoph, Looks fine, Thanks, Roger On 1/30/2017 9:52 AM, Langer, Christoph wrote: Hi, please review a tiny fix. The change for JDK-8170832 (Add a new launcher environment variable JAVA_OPTIONS) has introduced a build error when you build with Visual Studio 2010. Yes, we know it is no

[JAXP] RFR: 8173602: TESTBUG: javax/xml/jaxp/unittest/transform/TransformerTest.java needs refactoring

2017-01-30 Thread Langer, Christoph
Hi, please review a test fix for javax/xml/jaxp/unittest/transform/TransformerTest.java: Bug: https://bugs.openjdk.java.net/browse/JDK-8173602 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8173602.0/ The main motivation for this refactoring is to remove the dependency to the JDK internal

Re: RFR: 8167063: spurious message "A JNI error has occurred" if start-class cannot be initialized

2017-01-30 Thread Alan Bateman
On 30/01/2017 12:11, Ramanand Patil wrote: Thank you Alan. I have eliminated the inner catch block for LinkageError. Here is the updated webrev: http://cr.openjdk.java.net/~rpatil/8167063/webrev.04 I think this looks right now. -Alan

RE: RFR: 8167063: spurious message "A JNI error has occurred" if start-class cannot be initialized

2017-01-30 Thread Ramanand Patil
Thank you Alan. I have eliminated the inner catch block for LinkageError. Here is the updated webrev: http://cr.openjdk.java.net/~rpatil/8167063/webrev.04 Regards, Ramanand. -Original Message- From: Alan Bateman Sent: Sunday, January 29, 2017 1:06 AM To: Ramanand Patil Cc: core-libs-

Re: RFR (JDK 10) 8172298: Reduce memory churn when linking VarHandles operations

2017-01-30 Thread Aleksey Shipilev
On 01/28/2017 12:10 AM, Paul Sandoz wrote: > http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8172298-varhandle-link-reduce-memory/webrev/ Looks good, but I think the StringBuilder is inefficiently sized: it adds (parameterCount() - 2) chars in the loop, skipping the first and and then two after the