On 22/03/2017 10:26 AM, dean.l...@oracle.com wrote:
On 3/21/17 5:02 PM, David Holmes wrote:
I haven't been looking at the details of this but have been watching
from afar. As per my comments in the bug report (now public) I'm quite
concerned about the thread-non-safety issue here ...
On 22/03/
On 3/21/17 5:02 PM, David Holmes wrote:
I haven't been looking at the details of this but have been watching
from afar. As per my comments in the bug report (now public) I'm quite
concerned about the thread-non-safety issue here ...
On 22/03/2017 4:47 AM, dean.l...@oracle.com wrote:
On 3/21/
On 22/03/2017 10:09 AM, David Holmes wrote:
Hi Daniel,
On 22/03/2017 4:41 AM, Daniel Fuchs wrote:
Hi Brent,
Here is an updated webrev that incorporates your feedback:
http://cr.openjdk.java.net/~dfuchs/webrev_8177136/webrev.02
You could move all the detail to the @implSpec method as a clari
Hi Daniel,
On 22/03/2017 4:41 AM, Daniel Fuchs wrote:
Hi Brent,
Here is an updated webrev that incorporates your feedback:
http://cr.openjdk.java.net/~dfuchs/webrev_8177136/webrev.02
You could move all the detail to the @implSpec method as a clarification
on the use of the caller e.g.:
I haven't been looking at the details of this but have been watching
from afar. As per my comments in the bug report (now public) I'm quite
concerned about the thread-non-safety issue here ...
On 22/03/2017 4:47 AM, dean.l...@oracle.com wrote:
On 3/21/17 9:37 AM, Vladimir Ivanov wrote:
and w
Thanks Mandy, Lance! I added jdk9-fix-request as per the RDP2 Process.
Will push once it's approved.
-Joe
On 3/21/2017 12:27 PM, Mandy Chung wrote:
+1
Mandy
On Mar 21, 2017, at 11:58 AM, huizhe wang wrote:
In a jigsaw changeset [1], configuration files were moved from ${java.home}/lib
+1
Mandy
> On Mar 21, 2017, at 11:58 AM, huizhe wang wrote:
>
> In a jigsaw changeset [1], configuration files were moved from
> ${java.home}/lib directory to ${java.home}/conf. However, I found two misses
> as I searched the jaxp repo.
>
> javax/xml/stream/FactoryFinder.java:
>
> There wer
Looks fine Joe
> On Mar 21, 2017, at 2:58 PM, huizhe wang wrote:
>
> In a jigsaw changeset [1], configuration files were moved from
> ${java.home}/lib directory to ${java.home}/conf. However, I found two misses
> as I searched the jaxp repo.
>
> javax/xml/stream/FactoryFinder.java:
>
> There
In a jigsaw changeset [1], configuration files were moved from
${java.home}/lib directory to ${java.home}/conf. However, I found two
misses as I searched the jaxp repo.
javax/xml/stream/FactoryFinder.java:
There were two references to the "lib" directories. The one for
jaxp.properties was rep
On 3/21/17 9:37 AM, Vladimir Ivanov wrote:
and webrev.2 with it removed:
http://cr.openjdk.java.net/~dlong/8158168/webrev.2/
Thanks, Dean. I started with webrev.2 and tried to minimize the
changes. I ended up with the following version:
http://cr.openjdk.java.net/~vlivanov/dlong/8158168/
Hi Brent,
Here is an updated webrev that incorporates your feedback:
http://cr.openjdk.java.net/~dfuchs/webrev_8177136/webrev.02
Thanks!
-- daniel
On 21/03/2017 18:21, Brent Christian wrote:
Hi, Daniel
I think the new @throws tag gives a good explanation of the situation,
with instructions
On 21/03/2017 18:21, Brent Christian wrote:
Hi, Daniel
I think the new @throws tag gives a good explanation of the situation,
with instructions for someone wanting to get a System.Logger from JNI.
To nitpick on style, it's maybe on the long side for an @throws -
perhaps consider a slightly more
Hi, Daniel
I think the new @throws tag gives a good explanation of the situation,
with instructions for someone wanting to get a System.Logger from JNI.
To nitpick on style, it's maybe on the long side for an @throws -
perhaps consider a slightly more concise version:
* @throws Illegal
Thanks, Amy!
On Tue, Mar 21, 2017 at 1:09 AM, Amy Lu wrote:
> Below two tests was demoted from tier1 to tier2 due to test fails
> intermittently:
>
> java/util/concurrent/forkjoin/FJExceptionTableLeak.java
> JDK-8144990, JDK-8151158
> java/util/concurrent/ThreadPoolExecutor/ConfigChanges.ja
and webrev.2 with it removed:
http://cr.openjdk.java.net/~dlong/8158168/webrev.2/
Thanks, Dean. I started with webrev.2 and tried to minimize the changes.
I ended up with the following version:
http://cr.openjdk.java.net/~vlivanov/dlong/8158168/webrev.00/
Some clarifications:
===
Hi,
Please find below an updated patch for:
8177136: Caller sensitive method System.getLogger should specify
what happens if there is no caller on the stack.
https://bugs.openjdk.java.net/browse/JDK-8177136
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8177136/webrev.01
System.ge
Hi,
I now believe I was wrong in trying to tackle both
java.util.logging.Logger::getLogger and System::getLogger
uses of @CS with a single fix.
Both issues are indeed different in nature and might require
a different fix.
java.util.logging.Logger is an existing API.
the issue already exists in p
On 21/03/2017 08:09, Amy Lu wrote:
Below two tests was demoted from tier1 to tier2 due to test fails
intermittently:
java/util/concurrent/forkjoin/FJExceptionTableLeak.java
JDK-8144990, JDK-8151158
java/util/concurrent/ThreadPoolExecutor/ConfigChanges.java
JDK-8139237, JDK-8169243
M
Below two tests was demoted from tier1 to tier2 due to test fails
intermittently:
java/util/concurrent/forkjoin/FJExceptionTableLeak.java
JDK-8144990, JDK-8151158
java/util/concurrent/ThreadPoolExecutor/ConfigChanges.java
JDK-8139237, JDK-8169243
Mentioned issues have been resolved and
On 3/20/17 11:10 PM, Xueming Shen wrote:
Hi Dean,
Thanks for doing this.
Though as I suggested last time personally I prefer to make minimum
change to simply
seal those holes in ASB at this late stage of JDK9. I'm fine with the
webrev.2 and it looks
better and reasonable to pull all UTF16 o
On 21/03/2017 06:43, Weijun Wang wrote:
:
I can think of comparing with static final Path fields, but is there a
even faster way?
Can you creates some benchmarks and bring them to nio-dev?
-Alan
21 matches
Mail list logo
