Re: RFR(10)(XS) 8177015: STACK_SIZE_MINIMUM of 32k is not always enough for Mac OS X

2017-03-26 Thread David Holmes
Thanks Chris. All good to go. David On 27/03/2017 3:55 PM, Chris Plummer wrote: Hi David, On 3/26/17 5:06 PM, David Holmes wrote: Hi Chris, On 25/03/2017 6:12 AM, Chris Plummer wrote: Hello, Please review changes for the following: http://cr.openjdk.java.net/~cjplummer/8177015/webrev.00/

Re: RFR(10)(XS) 8177015: STACK_SIZE_MINIMUM of 32k is not always enough for Mac OS X

2017-03-26 Thread Chris Plummer
Hi David, On 3/26/17 5:06 PM, David Holmes wrote: Hi Chris, On 25/03/2017 6:12 AM, Chris Plummer wrote: Hello, Please review changes for the following: http://cr.openjdk.java.net/~cjplummer/8177015/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8177015 Functional change seems okay, th

Re: JDK 9 RFR of JDK-8177638: com/sun/jarsigner, jdk/internal/loader (and more) are missed in TEST.group

2017-03-26 Thread Amy Lu
Sure. Moved to jdk_security3. webrev updated: http://cr.openjdk.java.net/~amlu/8177638/webrev.00/ Thanks, Amy On 3/27/17 11:25 AM, Weijun Wang wrote: The com/sun/jarsigner line should be added to jdk_security3. Roughly, the categories mean: 1: public APIs 2: JCE 3: implementation and private

Re: JDK 9 RFR of JDK-8177638: com/sun/jarsigner, jdk/internal/loader (and more) are missed in TEST.group

2017-03-26 Thread Weijun Wang
The com/sun/jarsigner line should be added to jdk_security3. Roughly, the categories mean: 1: public APIs 2: JCE 3: implementation and private APIs 4: JGSS/krb5 Thanks Max On 03/27/2017 11:06 AM, Amy Lu wrote: jdk/internal/loader jdk/internal/util com/sun/jarsigner jdk/internal/agent Somehow

RFR of JDK-8176865: overridden api has a wrong since value in java.base module

2017-03-26 Thread Hamlin Li
Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8176865 webrev: http://cr.openjdk.java.net/~mli/8176865/webrev.00/ Thank you -Hamlin

JDK 9 RFR of JDK-8177638: com/sun/jarsigner, jdk/internal/loader (and more) are missed in TEST.group

2017-03-26 Thread Amy Lu
jdk/internal/loader jdk/internal/util com/sun/jarsigner jdk/internal/agent Somehow these are missed in TEST.group. Please review this patch to update TEST.group Tested on all platforms, TestVersionedStream.java fails on Windows, put it in ProblemList.txt for now. bug: https://bugs.openjdk.ja

Re: RFR(10)(XS) 8177015: STACK_SIZE_MINIMUM of 32k is not always enough for Mac OS X

2017-03-26 Thread David Holmes
Hi Chris, On 25/03/2017 6:12 AM, Chris Plummer wrote: Hello, Please review changes for the following: http://cr.openjdk.java.net/~cjplummer/8177015/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8177015 Functional change seems okay, though I do have to wonder why we see such variance i