Hi Joe,
On 04/12/2017 07:59 PM, Joseph D. Darcy wrote:
On 4/11/2017 1:48 PM, Chris Dennis wrote:
Color me confused… what would the javadoc on the parameter say? It
could I guess have an @implNote documenting the meanings of the
parameters… but then what use is it? The proposed API simply limit
> On 12 Apr 2017, at 17:36, Paul Sandoz wrote:
> ..
> Do you think it’s simpler just to let jtreg cleanup? There are a few Mr.Jar
> tests that clean up after themselves but i wonder if it’s just simpler to let
> jtreg do it? any thoughts on that?
I added these test library utility methods. Som
On 4/11/2017 1:48 PM, Chris Dennis wrote:
Color me confused… what would the javadoc on the parameter say? It could I
guess have an @implNote documenting the meanings of the parameters… but then
what use is it? The proposed API simply limits the precision with which a
DoubleSummaryStatistic can
Something like that was what I was envisioning (of course the inability to
represent NaN or infinity with a BigDecimal is annoying). To me this approach
really only breaks down when you stop using an actual iteration to perform the
computation… as long as a “sum” in some form is part of the inte
On 12/04/2017 17:36, Paul Sandoz wrote:
Such “simple” ( :-) ) utilities should be part of the JDK.
I think this utility method in the test library may the pre-date in
jtreg that does retry. As to why we retry, then it's virus checkers and
the like locking files that are in use by the test. I
Hi Amy,
FileUtils
—
-} catch (NoSuchFileException | DirectoryNotEmptyException x) {
+} catch (NoSuchFileException x) {
You removed the catch and rethrow of DirectoryNotEmptyException. The
documentation of deleteFIleIfExistsWithRetry states:
72 /**
73 * Del
On 04/12/2017 04:41 PM, Peter Levart wrote:
On 04/11/2017 10:48 PM, Chris Dennis wrote:
Color me confused… what would the javadoc on the parameter say? It
could I guess have an @implNote documenting the meanings of the
parameters… but then what use is it? The proposed API simply limits
the p
Hi Dennis,
On 04/11/2017 10:48 PM, Chris Dennis wrote:
Color me confused… what would the javadoc on the parameter say? It could I
guess have an @implNote documenting the meanings of the parameters… but then
what use is it? The proposed API simply limits the precision with which a
DoubleSummar
Hi Igor,
The fix looks, thanks for doing it.
Please update the copyrights before integration :)
Thanks,
Dima
On 12.04.2017 5:29, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev/8178415/webrev.00/
59 lines changed: 0 ins; 59 del; 0 mod;
Hi all,
could you please review this small c
