[cc'ing some errorprone folk ...]
On Fri, Apr 28, 2017 at 2:22 PM, Martin Buchholz
wrote:
> http://errorprone.info/bugpattern/PrivateConstructorForUtilityClass
>
It's highly non-obvious how to run errorprone against recent jdk sources.
You need a prerelease of errorprone,
> On Apr 28, 2017, at 4:16 PM, Kumar Srinivasan
> wrote:
>
> Hello,
>
> Please review changes for java.management and java.management.rmi to
> be HTML5 ready, there are outliers like cellpadding, cellspacing that needs
> to be done separately, note this was
Hello,
Please review changes for java.management and java.management.rmi to
be HTML5 ready, there are outliers like cellpadding, cellspacing that needs
to be done separately, note this was *not* done mechanically by a script.
http://cr.openjdk.java.net/~ksrini/8179415/
On 4/28/2017 3:39 PM, Paul Sandoz wrote:
On 28 Apr 2017, at 14:55, Alex Buckley wrote:
On 4/26/2017 4:06 PM, Paul Sandoz wrote:
Please review some documentation changes to VarHandle:
> On 28 Apr 2017, at 14:55, Alex Buckley wrote:
>
> On 4/26/2017 4:06 PM, Paul Sandoz wrote:
>> Please review some documentation changes to VarHandle:
>>
>> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8167229-varhandle-docs/webrev/index.html
>
> I notice that "shape"
On 4/26/2017 4:06 PM, Paul Sandoz wrote:
Please review some documentation changes to VarHandle:
http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8167229-varhandle-docs/webrev/index.html
I notice that "shape" is still mentioned throughout the
MethodHandles.Lookup class.
59 * {@code CT1, CT2,
http://errorprone.info/bugpattern/PrivateConstructorForUtilityClass
On Fri, Apr 28, 2017 at 2:19 PM, Paul Sandoz wrote:
>
> > On 28 Apr 2017, at 14:10, joe darcy wrote:
> >
> > Hello,
> >
> > As this is a binary incompatible change, effectively
> On 28 Apr 2017, at 14:10, joe darcy wrote:
>
> Hello,
>
> As this is a binary incompatible change, effectively removing a public
> constructor, I'd prefer if this change got into JDK 9 instead, pending the
> review process of course.
>
Fair point, the earlier the
Hello,
As this is a binary incompatible change, effectively removing a public
constructor, I'd prefer if this change got into JDK 9 instead, pending
the review process of course.
(I've thought it would be worthwhile to audit the JDK for default
constructors and/or add a javac lint warning
> On 28 Apr 2017, at 12:34, Ron Pressler wrote:
>
> Hi.
> Please review the following patch, which creates static final instances of
> FindOp.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8174267
>
+1
> I believe an additional test is not required as this is
Looks fine to me too.
-Joe
On 4/28/2017 12:52 PM, Lance Andersen wrote:
+1
On Apr 28, 2017, at 3:43 PM, Brian Burkhalter
wrote:
Please review at your convenience.
Issue: https://bugs.openjdk.java.net/browse/JDK-8179452
Patch: [1]
Thanks,
Brian
[1] diff
+1
> On Apr 28, 2017, at 3:43 PM, Brian Burkhalter
> wrote:
>
> Please review at your convenience.
>
> Issue:https://bugs.openjdk.java.net/browse/JDK-8179452
> Patch:[1]
>
> Thanks,
>
> Brian
>
> [1] diff
>
> ---
Please review at your convenience.
Issue: https://bugs.openjdk.java.net/browse/JDK-8179452
Patch: [1]
Thanks,
Brian
[1] diff
--- a/test/java/io/FileInputStream/LargeFileAvailable.java
+++ b/test/java/io/FileInputStream/LargeFileAvailable.java
@@ -24,7 +24,6 @@
/*
* @test
* @bug 6402006
Hi.
Please review the following patch, which creates static final instances
of FindOp.
Bug: https://bugs.openjdk.java.net/browse/JDK-8174267
I believe an additional test is not required as this is an
implementation detail.
---
diff -r 83d37efcd2a5
Hi.
Please review this trivial fix:
---
diff -r 83d37efcd2a5
src/java.base/share/classes/java/lang/invoke/LambdaMetafactory.java
---
a/src/java.base/share/classes/java/lang/invoke/LambdaMetafactory.java
Thu Apr 13 20:35:17 2017 +
+++
Reviewed. I’ll take a look at 8175022 soon.
-Chris.
> On 28 Apr 2017, at 20:18, joe darcy wrote:
>
> Hello,
>
> The test
>
> jdk/modules/incubator/ImageModules.java
>
> has been seen to intermittently fail at a low frequency (JDK-8175022) and
> should be marked
Hello,
The test
jdk/modules/incubator/ImageModules.java
has been seen to intermittently fail at a low frequency (JDK-8175022)
and should be marked accordingly.
Please review the patch below.
Thanks,
-Joe
diff -r 7c04ab31b4d6 test/jdk/modules/incubator/ImageModules.java
---
Do you mean just in the class name or also the directory name?
Ron
On 26/04/2017 20:53, Vladimir Ivanov wrote:
Ron,
The fix looks good.
One request: please, try to avoid bug ids in test names. It's much
easier to work with tests when they have meaningful names and there's
already @bug
18 matches
Mail list logo