Re: RFR: Update tables in java.base to be HTML5-friendly.

Jonathan Gibbons for "css style czar"! --- I checked the tables at http://cr.openjdk.java.net/~jjg/8179479-8179592/api/java/util/concurrent/BlockingDeque.html They look perfectly fine, although I feel a twinge of non-collapsed-border-nostalgia. --- Yes, "striped" is a much better name than

RFR 8178912, Throw away sample tests

Hi there, please review following change to remove tests for several samples, which have been removed in "JEP 298: Remove Demos and Samples". Webrev: http://cr.openjdk.java.net/~xiaofeya/8178912/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8178912 Corresponding JEP:

Re: RFR 8179566: Add additional jaxws messages to be translated

=== Copy from David's email That endorsed part is problem. It is valid in JDK-8 but not in 9. Following message is my proposed solution. It would fit JDK-8 and 9. JAX-WS 2.1 API is loaded from {0}, But JAX-WS runtime requires JAX-WS 2.2 API. Use the standard override mechanism to load JAX-WS

Re: tutorial on using Cleaner-based finalization

Thanks, Roger. That is a helpful example. Derby is a component which can be quiesced and unloaded on resource-constrained platforms, then re-loaded when resources free up. Unloading means garbage collecting all the classloaders created by the component so that, at the end, not a single scrap

Re: RFR: Update tables in java.base to be HTML5-friendly.

With my javadoc-tool-developer hat on, I'd like to get out of the business of jdk-style-owner, or at least identify that as a distinct hat. :-) Kumar has identified a problem with the styles as currently defined ... you cannot easily embed a table with a default style inside a table with an

jdk10/jdk10 is broken on 32-bit linux

With the latest changes in jdk10/jdk10 we are seeing failures of all jtreg agentvm mode tests on 32-bit linux binaries due to socket connection failures. And also some OSX failures. This seems to be have been caused by: 8165437: Evaluate the use of gettimeofday in Networking code

Re: RFR: Update tables in java.base to be HTML5-friendly.

Jon, I am happy for you to own the html5 style for the entire javadoc; consistency wins; my comments are only suggestions and I'm no html or css expert. On Wed, May 3, 2017 at 5:03 PM, Jonathan Gibbons < jonathan.gibb...@oracle.com> wrote: > > > On 05/03/2017 04:39 PM, Martin Buchholz wrote: > >

Re: RFR: Update tables in java.base to be HTML5-friendly.

On 05/03/2017 04:39 PM, Martin Buchholz wrote: Thanks, Jon. For the Deque/Queue tables - * + * I expected that we would modify these to which rendered alright and is compliant (although "border" is a weird boolean) and makes the "border intent" clear to humans and to browsers. THIS IS

Re: RFR: Update tables in java.base to be HTML5-friendly.

Thanks, Jon. For the Deque/Queue tables - * + * I expected that we would modify these to which rendered alright and is compliant (although "border" is a weird boolean) and makes the "border intent" clear to humans and to browsers. THIS IS JAVA, so I'd prefer more verbose meaningful names

Re: RFR: Update tables in java.base to be HTML5-friendly.

Hi Jon, The changes in the java.lang and java.math packages look fine. Cheers, -Joe On 5/3/2017 3:06 PM, Jonathan Gibbons wrote: This is a review request for two co-dependent fixes. JDK-8179592: Update tables in java.base to be HTML 5-friendly. JDK-8179479: Add new styles to enable HTML 5

RFR: Update tables in java.base to be HTML5-friendly.

This is a review request for two co-dependent fixes. JDK-8179592: Update tables in java.base to be HTML 5-friendly. JDK-8179479: Add new styles to enable HTML 5 tables In doc comments, some of the HTML 4.01 attributes for tables are no longer available in HTML 5, and CSS should be used

RFR 8150681 Update JAR specification for multi-release jar files

Hi, Please review an update to the JAR “specification” (in the loose sense of the term): - first, it has been moved from a closed repository into the idk repository (same shared location as the recently introduced serialisation specification) and converted to markdown:

Re: RFR 8179566: Add additional jaxws messages to be translated

> On May 3, 2017, at 1:35 PM, Alan Bateman wrote: > > On 03/05/2017 19:58, Lance Andersen wrote: > >> + >> +runtime.modeler.addressing.responses.nosuchmethod = JAX-WS 2.1 API is >> loaded from {0}, But JAX-WS runtime requires JAX-WS 2.2 or newer API. \ >> + Use the

Re: RFR 8179566: Add additional jaxws messages to be translated

On 03/05/2017 19:58, Lance Andersen wrote: + +runtime.modeler.addressing.responses.nosuchmethod = JAX-WS 2.1 API is loaded from {0}, But JAX-WS runtime requires JAX-WS 2.2 or newer API. \ + Use the standard override mechanism to load JAX-WS 2.2 or newer API. \ No newline at end of file "Use

RE: AppCDS in OpenJDK?

Thanks Jiangli Regards, Deepak From: Jiangli Zhou [mailto:jiangli.z...@oracle.com] Sent: Tuesday, May 02, 2017 5:50 PM To: Ramana, Deepak Cc: core-libs-dev@openjdk.java.net Subject: Re: AppCDS in OpenJDK? Hi Deepak, In JDK 8u40, AppCDS is an experimental (i.e can not be used in production)

RFR 8179566: Add additional jaxws messages to be translated

Hi all, Please review the following resources properties file update for jaxws. See https://bugs.openjdk.java.net/browse/JDK-8179566 for more info Best Lance $ hg diff diff -r 1c610f1b4097

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Shouldn't the version information be in the manifest for the jar file containing the classes, accessed via java.lang.Package? Roman Grigoriadi wrote on 05/ 3/17 09:49 AM: > Hi, > > you can find new web rev here: > http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8176508/01/ >

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi, you can find new web rev here: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8176508/01/ Previous review comments are addressed. > The change to version.properties reminds me to ask if there is anything in >

Re: RFR: 8078267 - Add test to verify that a module based JDBC driver via the service-provider loading mechanism

Hi Daniel, Thank you for the info. I do plan on adding some additional tests using these modules.I did run into some challenges with testng/jtreg/modules/TEST.properties that I am trying to sort out overall before I do that. Best Lance > On May 3, 2017, at 10:05 AM, Daniel Fuchs

Re: tutorial on using Cleaner-based finalization

Hi Rick, The general nature of changes to use the Cleaner involve factoring out the cleanup code from the object being cleaned, though in many cases it does not require restructuring. For example, if an object holds a reference to a network socket that needs to be closed when the object is

Re: JDK 9 RFR of JDK-8023897: Replace/update/rename executeAndCatch in various tests to assertThrows

Hi Amy, Ok, fine as is. My point was that there are now 2 exceptions in the log, one of which is an artifact of the test only to provide the message and useful information is spread across those two exceptions. There is no information lost but there is redundant information that has to be

Re: RFR: 8078267 - Add test to verify that a module based JDBC driver via the service-provider loading mechanism

Hi Lance, Are you planning to use these modules in other tests? I'm asking because you're using the @library tag to compile them. If you want to encapsulate a module inside a test (without resorting to @library) then you can do so with the following layout and following @build line:

Re: JDK 9 RFR of JDK-8023897: Replace/update/rename executeAndCatch in various tests to assertThrows

On 03/05/2017 05:19, Amy Lu wrote: On 5/3/17 12:53 AM, Daniel Fuchs wrote: Is that why you decided to drop the description? I tried best to keep the useful message, EmptyNavigableMap EmptyNavigableSet are examples. For Map/Defaults.java, most cases' message are test's description and/or

Re: Review Request: JDK-8020801: Apply the restriction of invoking MethodHandles.lookup to j.l.r.Method.invoke

Hi Mandy, On 05/02/2017 11:27 PM, Mandy Chung wrote: Hi Peter, Looking at it again, you are right that no need to skip inflation. The change is simplified. I have verified with and without -Dsun.reflect.noInflation=true. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8020801/webrev.01/