Re: RFR 10 JDK-8159995: Rename internal Unsafe.compare methods

2017-05-07 Thread David Holmes
Hi Ron, On 6/05/2017 5:27 AM, Ron Pressler wrote: Hi, Please review the following core/hotspot change: Bug: https://bugs.openjdk.java.net/browse/JDK-8159995 core webrev: http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8159995-unsafe-compare-and-swap-to-set-jdk/webrev/ hotspot webrev: http://cr.o

Re: RFR: jdk10: 8169646: Remove launcher's -d32/-d64 option

2017-05-07 Thread David Holmes
Hi Kumar, On 7/05/2017 1:21 AM, Kumar Srinivasan wrote: Hello, Please review the changes to remove the java launcher's data model options -d32/-d64, these options existed to support Solaris dual-mode operation, however for uniformity, these options were accepted by other platforms as well. Th

Re: Add support for Unicode versions of JNI_CreateJavaVM and JNI_GetDefaultJavaVMInitArgs on Windows platforms

2017-05-07 Thread David Holmes
Added back jdk10-dev as a bcc. Added hotspot-dev and core-libs-dev (for launcher) for follow up discussions. Hi John, On 8/05/2017 10:33 AM, John Platts wrote: I actually did a search through the code that implements JNI_CreateJavaVM, and I found that the conversion of the strings is done us

Re: tutorial on using Cleaner-based finalization

2017-05-07 Thread Peter Levart
Hi Rick, On 05/07/2017 08:59 PM, Rick Hillegas wrote: Thanks for investigating that sample case, Peter, and for providing a candidate solution. It is much appreciated. Your expert experience confirms my amateur hunch that this migration is a non-trivial re-factorization which merits its own mi

Re: tutorial on using Cleaner-based finalization

2017-05-07 Thread Rick Hillegas
Thanks for investigating that sample case, Peter, and for providing a candidate solution. It is much appreciated. Your expert experience confirms my amateur hunch that this migration is a non-trivial re-factorization which merits its own mini-project. I have logged a new technical debt issue to